mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
`enableDefensive()` updated only the live connection, so after `close()` and `open()` the defensive flag went back to the value passed to the constructor. Store the new value in the open configuration so that `open()` applies it again. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> Assisted-by: claude:opus-5.5 PR-URL: https://github.com/nodejs/node/pull/66404 Fixes: https://github.com/nodejs/node/issues/66403 Reviewed-By: Guilherme Araújo <arauujogui@gmail.com>
96 lines
2.7 KiB
JavaScript
96 lines
2.7 KiB
JavaScript
'use strict';
|
|
const { skipIfSQLiteMissing } = require('../common/index.mjs');
|
|
const { test } = require('node:test');
|
|
const assert = require('node:assert');
|
|
skipIfSQLiteMissing();
|
|
const { Database } = require('node:sqlite');
|
|
|
|
function checkDefensiveMode(db) {
|
|
function journalMode() {
|
|
return db.prepare('PRAGMA journal_mode').get().journal_mode;
|
|
}
|
|
|
|
assert.strictEqual(journalMode(), 'memory');
|
|
db.exec('PRAGMA journal_mode=OFF');
|
|
|
|
switch (journalMode()) {
|
|
case 'memory': return true; // journal_mode unchanged, defensive mode must be active
|
|
case 'off': return false; // journal_mode now 'off', so defensive mode not active
|
|
default: throw new Error('unexpected journal_mode');
|
|
}
|
|
}
|
|
|
|
test('by default, defensive mode is on', (t) => {
|
|
const db = new Database(':memory:');
|
|
t.assert.strictEqual(checkDefensiveMode(db), true);
|
|
});
|
|
|
|
test('when passing { defensive: true } as config, defensive mode is on', (t) => {
|
|
const db = new Database(':memory:', {
|
|
defensive: true
|
|
});
|
|
t.assert.strictEqual(checkDefensiveMode(db), true);
|
|
});
|
|
|
|
test('when passing { defensive: false } as config, defensive mode is off', (t) => {
|
|
const db = new Database(':memory:', {
|
|
defensive: false
|
|
});
|
|
t.assert.strictEqual(checkDefensiveMode(db), false);
|
|
});
|
|
|
|
test('defensive mode on after calling db.enableDefensive(true)', (t) => {
|
|
const db = new Database(':memory:');
|
|
db.enableDefensive(true);
|
|
t.assert.strictEqual(checkDefensiveMode(db), true);
|
|
});
|
|
|
|
test('defensive mode off after calling db.enableDefensive(false)', (t) => {
|
|
const db = new Database(':memory:', {
|
|
defensive: true
|
|
});
|
|
db.enableDefensive(false);
|
|
t.assert.strictEqual(checkDefensiveMode(db), false);
|
|
});
|
|
|
|
test('db.enableDefensive(true) persists across close() and open()', (t) => {
|
|
const db = new Database(':memory:', {
|
|
defensive: false
|
|
});
|
|
db.enableDefensive(true);
|
|
db.close();
|
|
db.open();
|
|
t.assert.strictEqual(checkDefensiveMode(db), true);
|
|
});
|
|
|
|
test('db.enableDefensive(false) persists across close() and open()', (t) => {
|
|
const db = new Database(':memory:', {
|
|
defensive: true
|
|
});
|
|
db.enableDefensive(false);
|
|
db.close();
|
|
db.open();
|
|
t.assert.strictEqual(checkDefensiveMode(db), false);
|
|
});
|
|
|
|
test('throws if options.defensive is provided but is not a boolean', (t) => {
|
|
t.assert.throws(() => {
|
|
new Database(':memory:', { defensive: 42 });
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "options.defensive" argument must be a boolean.',
|
|
});
|
|
});
|
|
|
|
test('enableLoadExtension() throws if database is not open', (t) => {
|
|
const db = new Database(':memory:', { allowExtension: true });
|
|
db.close();
|
|
|
|
t.assert.throws(() => {
|
|
db.enableLoadExtension(false);
|
|
}, {
|
|
code: 'ERR_INVALID_STATE',
|
|
message: 'database is not open',
|
|
});
|
|
});
|