mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
Ethan Arrowood
c3189d436e
Replaces the `for await (const _ of source) {}` discard idiom with
dump(), which says what it does and does not need an eslint-disable
for the unused loop variable. The eslint-disable directives and
comments that become redundant are removed with it.
Only files that already declare --experimental-stream-iter are
converted, so no test gains an experimental flag it did not already
opt into. Files still using the old idiom are left as they are;
converting them would change what those tests run under and belongs
in a separate discussion.
Loops that break early are left alone: those cancel the source rather
than reading it to completion, which is not what dump() does.
Assisted-by: Claude Opus 5
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: https://github.com/nodejs/node/pull/65598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
73 lines
2.3 KiB
JavaScript
73 lines
2.3 KiB
JavaScript
// Flags: --experimental-quic --experimental-stream-iter --no-warnings
|
|
|
|
// Test: stream stats fields.
|
|
// Verify that stream stats are populated with correct types and
|
|
// that bytesReceived/bytesSent reflect actual data transfer.
|
|
|
|
import { hasQuic, skip, mustCall } from '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import { dump } from 'node:stream/iter';
|
|
|
|
if (!hasQuic) {
|
|
skip('QUIC is not enabled');
|
|
}
|
|
|
|
const { listen, connect } = await import('../common/quic.mjs');
|
|
const { bytes } = await import('stream/iter');
|
|
|
|
const encoder = new TextEncoder();
|
|
const payload = encoder.encode('stream stats test data');
|
|
const payloadLength = payload.byteLength;
|
|
const serverDone = Promise.withResolvers();
|
|
|
|
const serverEndpoint = await listen(mustCall((serverSession) => {
|
|
serverSession.onstream = mustCall(async (stream) => {
|
|
const data = await bytes(stream);
|
|
assert.strictEqual(data.byteLength, payloadLength);
|
|
|
|
// Stream stats should reflect received bytes.
|
|
assert.strictEqual(stream.stats.bytesReceived, BigInt(payloadLength));
|
|
assert.strictEqual(typeof stream.stats.createdAt, 'bigint');
|
|
assert.strictEqual(typeof stream.stats.receivedAt, 'bigint');
|
|
|
|
// Send response.
|
|
stream.setBody(encoder.encode('response'));
|
|
await stream.closed;
|
|
|
|
// After close, bytesSent should reflect response.
|
|
assert.strictEqual(stream.stats.bytesSent, BigInt('response'.length));
|
|
|
|
serverSession.close();
|
|
serverDone.resolve();
|
|
});
|
|
}));
|
|
|
|
const clientSession = await connect(serverEndpoint.address);
|
|
await clientSession.opened;
|
|
|
|
const stream = await clientSession.createBidirectionalStream({
|
|
body: payload,
|
|
});
|
|
|
|
// Stats should have correct types before transfer completes.
|
|
assert.strictEqual(typeof stream.stats.createdAt, 'bigint');
|
|
assert.strictEqual(typeof stream.stats.bytesReceived, 'bigint');
|
|
assert.strictEqual(typeof stream.stats.bytesSent, 'bigint');
|
|
assert.strictEqual(typeof stream.stats.maxOffset, 'bigint');
|
|
|
|
// Verify toJSON works.
|
|
const json = stream.stats.toJSON();
|
|
assert.ok(json);
|
|
assert.strictEqual(typeof json.createdAt, 'string');
|
|
|
|
await dump(stream);
|
|
await stream.closed;
|
|
await serverDone.promise;
|
|
|
|
// After transfer, bytesSent should reflect the payload.
|
|
assert.strictEqual(stream.stats.bytesSent, BigInt(payloadLength));
|
|
assert.ok(stream.stats.bytesReceived > 0n);
|
|
|
|
await clientSession.closed;
|
|
await serverEndpoint.close();
|