mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
Ethan Arrowood
c3189d436e
Replaces the `for await (const _ of source) {}` discard idiom with
dump(), which says what it does and does not need an eslint-disable
for the unused loop variable. The eslint-disable directives and
comments that become redundant are removed with it.
Only files that already declare --experimental-stream-iter are
converted, so no test gains an experimental flag it did not already
opt into. Files still using the old idiom are left as they are;
converting them would change what those tests run under and belongs
in a separate discussion.
Loops that break early are left alone: those cancel the source rather
than reading it to completion, which is not what dump() does.
Assisted-by: Claude Opus 5
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: https://github.com/nodejs/node/pull/65598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
58 lines
1.6 KiB
JavaScript
58 lines
1.6 KiB
JavaScript
// Flags: --experimental-quic --experimental-stream-iter --no-warnings
|
|
|
|
// Test: many streams opened and closed rapidly.
|
|
// Open 50 bidirectional streams in rapid succession, each with a
|
|
// small body. All streams should close successfully and the server
|
|
// should receive all data.
|
|
|
|
import { hasQuic, skip, mustCall } from '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import { dump } from 'node:stream/iter';
|
|
|
|
if (!hasQuic) {
|
|
skip('QUIC is not enabled');
|
|
}
|
|
|
|
const { listen, connect } = await import('../common/quic.mjs');
|
|
const { bytes } = await import('stream/iter');
|
|
|
|
const streamCount = 50;
|
|
const encoder = new TextEncoder();
|
|
let serverReceived = 0;
|
|
const allReceived = Promise.withResolvers();
|
|
|
|
const serverEndpoint = await listen(mustCall((serverSession) => {
|
|
serverSession.onstream = mustCall(async (stream) => {
|
|
const data = await bytes(stream);
|
|
assert.strictEqual(data.byteLength, 5);
|
|
stream.writer.endSync();
|
|
await stream.closed;
|
|
if (++serverReceived === streamCount) {
|
|
serverSession.close();
|
|
allReceived.resolve();
|
|
}
|
|
}, streamCount);
|
|
}));
|
|
|
|
const clientSession = await connect(serverEndpoint.address);
|
|
await clientSession.opened;
|
|
|
|
// Open 50 streams rapidly, each with a small body.
|
|
const streams = [];
|
|
for (let i = 0; i < streamCount; i++) {
|
|
const stream = await clientSession.createBidirectionalStream({
|
|
body: encoder.encode('hello'),
|
|
});
|
|
streams.push(stream);
|
|
}
|
|
|
|
// Wait for all client streams to close.
|
|
await Promise.all(streams.map(async (stream) => {
|
|
await dump(stream);
|
|
await stream.closed;
|
|
}));
|
|
|
|
await allReceived.promise;
|
|
await clientSession.closed;
|
|
await serverEndpoint.close();
|