mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 10:15:07 +08:00
Ethan Arrowood
c3189d436e
Replaces the `for await (const _ of source) {}` discard idiom with
dump(), which says what it does and does not need an eslint-disable
for the unused loop variable. The eslint-disable directives and
comments that become redundant are removed with it.
Only files that already declare --experimental-stream-iter are
converted, so no test gains an experimental flag it did not already
opt into. Files still using the old idiom are left as they are;
converting them would change what those tests run under and belongs
in a separate discussion.
Loops that break early are left alone: those cancel the source rather
than reading it to completion, which is not what dump() does.
Assisted-by: Claude Opus 5
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: https://github.com/nodejs/node/pull/65598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
60 lines
1.8 KiB
JavaScript
60 lines
1.8 KiB
JavaScript
// Flags: --experimental-quic --experimental-stream-iter --no-warnings
|
|
|
|
// Test: second iterator rejects when first is active.
|
|
// Because [Symbol.asyncIterator]() is an async generator, creating the
|
|
// generator always succeeds. The lock check runs inside the body, so
|
|
// the ERR_INVALID_STATE manifests as a rejected .next() promise, not
|
|
// a synchronous throw on generator creation.
|
|
|
|
import { hasQuic, skip, mustCall } from '../common/index.mjs';
|
|
import * as assert from 'node:assert';
|
|
import { dump } from 'node:stream/iter';
|
|
|
|
if (!hasQuic) {
|
|
skip('QUIC is not enabled');
|
|
}
|
|
|
|
const { listen, connect } = await import('../common/quic.mjs');
|
|
|
|
const encoder = new TextEncoder();
|
|
|
|
const serverDone = Promise.withResolvers();
|
|
|
|
const serverEndpoint = await listen(mustCall((serverSession) => {
|
|
serverSession.onstream = mustCall(async (stream) => {
|
|
const iter1 = stream[Symbol.asyncIterator]();
|
|
// Advance the first iterator so the lock is set.
|
|
const first = await iter1.next();
|
|
assert.strictEqual(first.done, false);
|
|
|
|
// A second iterator can be created (generator object), but
|
|
// advancing it should reject because the lock is held.
|
|
const iter2 = stream[Symbol.asyncIterator]();
|
|
await assert.rejects(iter2.next(), {
|
|
code: 'ERR_INVALID_STATE',
|
|
});
|
|
|
|
// Drain the first iterator.
|
|
for (;;) {
|
|
const { done } = await iter1.next();
|
|
if (done) break;
|
|
}
|
|
|
|
stream.writer.endSync();
|
|
await stream.closed;
|
|
serverSession.close();
|
|
serverDone.resolve();
|
|
});
|
|
}));
|
|
|
|
const clientSession = await connect(serverEndpoint.address);
|
|
await clientSession.opened;
|
|
|
|
const stream = await clientSession.createBidirectionalStream({
|
|
body: encoder.encode('double iter test'),
|
|
});
|
|
await dump(stream);
|
|
await Promise.all([stream.closed, serverDone.promise]);
|
|
await clientSession.close();
|
|
await serverEndpoint.close();
|