mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
Ethan Arrowood
c3189d436e
Replaces the `for await (const _ of source) {}` discard idiom with
dump(), which says what it does and does not need an eslint-disable
for the unused loop variable. The eslint-disable directives and
comments that become redundant are removed with it.
Only files that already declare --experimental-stream-iter are
converted, so no test gains an experimental flag it did not already
opt into. Files still using the old idiom are left as they are;
converting them would change what those tests run under and belongs
in a separate discussion.
Loops that break early are left alone: those cancel the source rather
than reading it to completion, which is not what dump() does.
Assisted-by: Claude Opus 5
Signed-off-by: Ethan Arrowood <ethan@arrowood.dev>
PR-URL: https://github.com/nodejs/node/pull/65598
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
72 lines
2.5 KiB
JavaScript
72 lines
2.5 KiB
JavaScript
// Flags: --experimental-quic --experimental-stream-iter --no-warnings
|
|
|
|
// Test: flow control transport parameters.
|
|
// initialMaxData limits total connection-level data.
|
|
// initialMaxStreamDataBidiLocal limits stream data for locally
|
|
// initiated bidi streams (server perspective for server-opened).
|
|
// initialMaxStreamDataBidiRemote limits stream data for remotely
|
|
// initiated bidi streams (server perspective for client-opened).
|
|
// These tests verify that data transfers complete successfully even when
|
|
// flow control windows are very small, proving that flow control extension
|
|
// (MAX_DATA / MAX_STREAM_DATA) works correctly.
|
|
|
|
import { hasQuic, skip, mustCall } from '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import { dump } from 'node:stream/iter';
|
|
|
|
if (!hasQuic) {
|
|
skip('QUIC is not enabled');
|
|
}
|
|
|
|
const { listen, connect } = await import('../common/quic.mjs');
|
|
const { bytes, drainableProtocol: dp } = await import('stream/iter');
|
|
|
|
const encoder = new TextEncoder();
|
|
|
|
// Small initialMaxStreamDataBidiRemote — limits how much the
|
|
// client can send initially before the server extends flow control.
|
|
{
|
|
const message = 'a]'.repeat(2048); // 4KB, larger than the 1KB window
|
|
const expected = encoder.encode(message);
|
|
|
|
const serverDone = Promise.withResolvers();
|
|
|
|
const serverEndpoint = await listen(mustCall((serverSession) => {
|
|
serverSession.onstream = mustCall(async (stream) => {
|
|
const received = await bytes(stream);
|
|
assert.strictEqual(received.byteLength, expected.byteLength);
|
|
stream.writer.endSync();
|
|
await stream.closed;
|
|
serverSession.close();
|
|
serverDone.resolve();
|
|
});
|
|
}), {
|
|
// Very small stream window — forces multiple flow control extensions.
|
|
transportParams: { initialMaxStreamDataBidiRemote: 1024 },
|
|
});
|
|
|
|
const clientSession = await connect(serverEndpoint.address);
|
|
await clientSession.opened;
|
|
|
|
const stream = await clientSession.createBidirectionalStream({
|
|
budget: 512,
|
|
});
|
|
const w = stream.writer;
|
|
|
|
// Write in small chunks, respecting backpressure.
|
|
const chunkSize = 256;
|
|
for (let offset = 0; offset < expected.byteLength; offset += chunkSize) {
|
|
const chunk = expected.slice(offset, offset + chunkSize);
|
|
while (!w.writeSync(chunk)) {
|
|
const drain = w[dp]();
|
|
if (drain) await drain;
|
|
}
|
|
}
|
|
w.endSync();
|
|
|
|
await dump(stream);
|
|
await Promise.all([stream.closed, serverDone.promise]);
|
|
await clientSession.close();
|
|
await serverEndpoint.close();
|
|
}
|