mirror of
https://github.com/nodejs/node.git
synced 2026-10-28 18:25:13 +08:00
Matteo Collina
e5778f78c5
Previously, ClientRequest silently truncated responses that exceeded request.maxHeadersCount while llhttp continued using omitted headers. Reject these responses with HPE_HEADER_OVERFLOW so parser state and exposed headers cannot diverge. This is a semver-major behavior change. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/65010 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
104 lines
3.2 KiB
JavaScript
104 lines
3.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
let requests = 0;
|
|
let responses = 0;
|
|
|
|
const headers = {
|
|
host: 'example.com'
|
|
};
|
|
const N = 100;
|
|
for (let i = 0; i < N; ++i) {
|
|
headers[`key${i}`] = i;
|
|
}
|
|
|
|
function createRequestHeaders(count) {
|
|
const requestHeaders = {
|
|
host: 'example.com',
|
|
};
|
|
for (let i = 0; i < count; ++i) {
|
|
requestHeaders[`key${i}`] = i;
|
|
}
|
|
return requestHeaders;
|
|
}
|
|
|
|
const serverMaxAndExpected = [ // for server
|
|
[50, 50, 48],
|
|
[1500, 102, N],
|
|
[0, N + 2, N], // Host and Connection
|
|
];
|
|
let max = serverMaxAndExpected[requests][0];
|
|
let expected = serverMaxAndExpected[requests][1];
|
|
|
|
const server = http.createServer(common.mustCallAtLeast((req, res) => {
|
|
assert.strictEqual(Object.keys(req.headers).length, expected);
|
|
if (++requests < serverMaxAndExpected.length) {
|
|
max = serverMaxAndExpected[requests][0];
|
|
expected = serverMaxAndExpected[requests][1];
|
|
server.maxHeadersCount = max;
|
|
}
|
|
res.writeHead(200, { ...headers, 'Connection': 'close' });
|
|
res.end();
|
|
}));
|
|
server.maxHeadersCount = max;
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const clientMaxAndExpected = [ // for client
|
|
[200, 104],
|
|
[1200, 104],
|
|
[0, N + 4], // Host and Connection
|
|
];
|
|
doRequest();
|
|
|
|
function doRequest() {
|
|
const max = clientMaxAndExpected[responses][0];
|
|
const expected = clientMaxAndExpected[responses][1];
|
|
const requestHeaders =
|
|
createRequestHeaders(serverMaxAndExpected[requests][2]);
|
|
const req = http.request({
|
|
port: server.address().port,
|
|
headers: requestHeaders
|
|
}, common.mustCall((res) => {
|
|
assert.strictEqual(Object.keys(res.headers).length, expected);
|
|
res.on('end', function() {
|
|
if (++responses < clientMaxAndExpected.length) {
|
|
doRequest();
|
|
} else {
|
|
server.close();
|
|
}
|
|
});
|
|
res.resume();
|
|
}));
|
|
req.maxHeadersCount = max;
|
|
req.end();
|
|
}
|
|
}));
|
|
|
|
process.on('exit', function() {
|
|
assert.strictEqual(requests, serverMaxAndExpected.length);
|
|
assert.strictEqual(responses, serverMaxAndExpected.length);
|
|
});
|