Paul Bouchon 1b2de5e052 module: fix --check on ambiguous ESM files ...

A `.js` file with no `"type"` in the nearest package.json has no format
of its own, and `defaultGetFormat()` reports it as null. `--check`
passed that null straight to `wrapSafe()`, which parses as CommonJS.
Module syntax makes that parse bail out early, so the file was reported
as valid and `--check` exited 0 even though it is not valid JavaScript
under either goal.

At load time the goal for such a file is decided by looking for module
syntax in the source. Decide it the same way here, so the file is
parsed as a module and its real syntax error is reported. Files whose
format is known are unaffected, as are ambiguous files without module
syntax, which are still parsed as CommonJS.

Fixes: https://github.com/nodejs/node/issues/65202
Signed-off-by: Paul Bouchon <mail@bitpshr.net>
PR-URL: https://github.com/nodejs/node/pull/65203
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

2026-08-12 21:47:11 +00:00

..

bad_syntax_esm_ambiguous.js

module: fix --check on ambiguous ESM files

2026-08-12 21:47:11 +00:00

bad_syntax_shebang.js

node: add -c|--check CLI arg to syntax check script

2015-10-03 21:58:38 +10:00

bad_syntax.js

node: add -c|--check CLI arg to syntax check script

2015-10-03 21:58:38 +10:00

bad_syntax.mjs

esm: phase two of new esm implementation

2019-03-27 15:52:11 -04:00

good_syntax_shebang.js

node: add -c|--check CLI arg to syntax check script

2015-10-03 21:58:38 +10:00

good_syntax.js

node: add -c|--check CLI arg to syntax check script

2015-10-03 21:58:38 +10:00

good_syntax.mjs

lib: fix checking syntax of esm module

2021-12-19 23:33:34 +00:00

illegal_if_not_wrapped.js

src: wrap source before doing syntax check

2015-10-29 13:08:32 -05:00