mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity
34,113 Commits 74 Branches 969 Tags
fdf625bae8f8b29a25cbd7c8a5d8220af6292cea
Commit Graph
7854 Commits
Author SHA1 Message Date
Guy Bedford fdf625bae8 deps: update to cjs-module-lexer@1.2.2 
PR-URL: https://github.com/nodejs/node/pull/39402
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-17 12:59:21 -07:00
Rich Trott f1e936ff15 doc: add strategic initiatives from TSC repo 
This (along with a corresponding PR for the TSC repo) moves the
strategic initiatives from the TSC repository to the main core repo.
This will increase visibility for strategic initiatives. It will also
facilitate the proposed reduced centrality of TSC champions to strategic
plans.

In the process, I made the text less wordy. I moved the Build Resources
initiatve out of the active list, as discussed at the most recent TSC
meeting. I alphabetized the table entries. (Chronological order isn't
obvious to a reader if no dates are provided.)

Refs: https://github.com/nodejs/TSC/issues/962#issuecomment-880233678

PR-URL: https://github.com/nodejs/node/pull/39394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-07-17 06:46:39 -07:00
hemanth.hm 14b26e07bd repl: enable --experimental-repl-await /w opt-out 
Unflags top-level await for the REPL by enabling
--experimental-repl-await by default. Opt-out is
supported via --no-experimental-repl-await.

PR-URL: https://github.com/nodejs/node/pull/34733
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-07-16 15:14:26 -07:00
Rich Trott 7dbc0f74d0 doc: standardize on _pull request_ 
Sometimes we capitalize _pull request_ and sometimes we don't.
Standardize on lowercase based on Microsoft Style Guide, Chicago Manual
of Style, and GitHub's own docs and UI.

Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests
Refs: https://docs.github.com/en/github/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/merging-a-pull-request
Refs: https://docs.microsoft.com/en-us/style-guide/capitalization

PR-URL: https://github.com/nodejs/node/pull/39384
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-07-16 10:36:30 -07:00
Rich Trott 1efa8fe1aa doc: make minor edits to pull request text 
PR-URL: https://github.com/nodejs/node/pull/39383
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-16 06:35:14 -07:00
Daniel Bevenius cb3c02f8f6 doc: add docker-node and build-wg issue contents 
This commit add the contents that should go into the docker-node and
build issues when doing a security release.

PR-URL: https://github.com/nodejs/node/pull/39215
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-07-16 13:37:44 +02:00
Daniel Bevenius eb33cb4122 doc: add instructions for core vuln files 
This commit adds instructions for adding machine-readable json files to
the security-wg repo in the security release guide.

PR-URL: https://github.com/nodejs/node/pull/39220
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-16 13:20:09 +02:00
Rich Trott 0d42470798 doc: standardize on not capitalizing _collaborator_ 
Sometimes we capitalize _collaborator_ and sometimes not. After
consulting the Microsoft Style Guide and The Chicago Manual of Style,
I've concluded it is best to not capitalize it. For consistency, apply
that to our various .md files.

Refs: https://docs.microsoft.com/en-us/style-guide/capitalization

PR-URL: https://github.com/nodejs/node/pull/39379
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-15 17:21:39 -07:00
James M Snell 6cd12be347 fs: add FileHandle.prototype.readableWebStream() 
Adds an experimental `readableWebStream()` method to `FileHandle` that
returns a web `ReadableStream`

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39331
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-07-15 13:43:20 -07:00
legendecas 82b1b55122 process: add api to enable source-maps programmatically 
Add `process.setSourceMapsEnabled` to enable
source-maps programmatically.

PR-URL: https://github.com/nodejs/node/pull/39085
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-15 19:45:16 +08:00
James M Snell 09ad64d66d stream: add CompressionStream and DecompressionStream 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39348
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-07-14 10:52:59 -07:00
James M Snell 25e2f177cb stream: implement TextEncoderStream and TextDecoderStream 
Experimental as part of the web streams implementation

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39347
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-07-14 09:12:43 -07:00
Michaël Zasso 4a9fcb3534 2021-07-14, Version 16.5.0 (Current) 
Notable changes:

deps:
  * upgrade npm to 7.19.1 (npm team) https://github.com/nodejs/node/pull/39225
fs:
  * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) https://github.com/nodejs/node/pull/39028
stream:
  * (SEMVER-MINOR) implement Web Streams API (James M Snell) https://github.com/nodejs/node/pull/39062

PR-URL: https://github.com/nodejs/node/pull/39373
 2021-07-14 11:08:26 +02:00
Rich Trott 4011355d40 doc: edit guide on pull requests 
* Replace _PR_ with Pull Request
* Make some content more concise

PR-URL: https://github.com/nodejs/node/pull/39359
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-13 17:07:07 -07:00
James M Snell a99c230305 stream: implement streams to webstreams adapters 
Experimental adapters for the webstreams API

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39134
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-07-13 10:03:16 -07:00
Tobias Nießen 3bae79087c doc: fix typos in Web Streams API documentation 
PR-URL: https://github.com/nodejs/node/pull/39351
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-13 08:10:19 +02:00
Danielle Adams 223625a0b9 doc: add text about moving long commit lists out of PR description 
PR-URL: https://github.com/nodejs/node/pull/39186
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-07-12 21:13:08 -04:00
Rich Trott f0838a09f1 doc: do not use & for "and" in text 
This also changes a line in the man page to be sentence case.

Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters

PR-URL: https://github.com/nodejs/node/pull/39345
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-07-12 15:50:51 -07:00
Rich Trott 91ec27fb19 doc: do not use tilde for "about" or "approximately" 
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/special-characters

PR-URL: https://github.com/nodejs/node/pull/39344
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-07-12 15:47:20 -07:00
Rich Trott 5cccdccf88 doc: use consistent abbreviation formatting 
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/term-collections/bits-bytes-terms

PR-URL: https://github.com/nodejs/node/pull/39343
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-07-12 15:21:36 -07:00
Robert Nagy 09d8c0c8d2 stream: destroy readable on read error 
PR-URL: https://github.com/nodejs/node/pull/39342
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-07-12 12:08:43 +02:00
foxxyz 72f198b0b5 doc: replace outdated util.promisify timer examples with references 
PR-URL: https://github.com/nodejs/node/pull/39164
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-11 09:11:34 +02:00
Rich Trott 2631394516 doc: simplify CRAN mirror text in benchmark guide 
PR-URL: https://github.com/nodejs/node/pull/39287
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-08 07:00:52 -07:00
Rich Trott 21cda8ef92 doc: remove GitHub mark 
Judging from https://github.com/logos, we are misusing the GitHub mark.
That page indicates to not change the color (we change it from black to
green). Less clear, it says  "Use the Mark in social buttons to link to
your GitHub profile or project" which isn't exactly what we're doing but
also isn't not what we're doing?

This might be an indication of my eyesight getting worse as I get older,
but I think the size that we display the mark at by default makes it not
entirely recognizable as the GitHub mark. Lastly, there's the
philosophical issue of whether we should display a commercial entity's
mark on our web pages in this particular instance. (For me, the answer
is "maybe".)

All told, I think we can remove it without damaging usability on the
website, so let's do it.

PR-URL: https://github.com/nodejs/node/pull/39251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-07 20:42:23 -07:00
Rich Trott 6e1906c2f4 doc: remove emailing the TSC from offboarding doc 
Emailing the TSC seems superfluous. Removing it.

PR-URL: https://github.com/nodejs/node/pull/39280
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-07-07 15:29:24 -07:00
Jacob 6a4b4ce488 doc: add annotation to writeFile data as Object 
Fixes: https://github.com/nodejs/node/issues/39152

PR-URL: https://github.com/nodejs/node/pull/39167
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-07-07 21:38:20 +00:00
Rich Trott 92573721c7 doc: fix boldface punctuation for full sentences 
If an entire sentence is in boldface, then generally the terminating
punctuation should as well.

PR-URL: https://github.com/nodejs/node/pull/39278
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-07-07 11:01:08 -07:00
Cyrille Bourgois 9b68d84656 doc: fix constants usage in fs.access example 
PR-URL: https://github.com/nodejs/node/pull/39289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-07-07 09:00:09 +00:00
Michael Dawson 4de6f207dc doc: use "repository" in guides versus repo 
Fix remaining instances in the guides where we
use repo instead of repository.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/39198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2021-07-06 08:51:37 -04:00
Michael Dawson ce666d769d doc: update Node-api version matrix 
- add 14.x version in which Node-api version 8
  was added.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/39197
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2021-07-05 18:28:10 -04:00
Rich Trott 2fd687ae1f doc: remove onboarding-extras 
Migrate last bit of onboarding-extras content to collaborator-guide and
remove onboarding-extras.

PR-URL: https://github.com/nodejs/node/pull/39252
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-05 14:01:20 -07:00
Beth Griggs 70cf0dce4e 2021-07-05, Version 16.4.2 (Current) 
Notable changes:

Node.js 16.4.1 introduced a regression in the Windows installer on
non-English locales that is being fixed in this release. There is no
need to download this release if you are not using the Windows
installer.

PR-URL: https://github.com/nodejs/node/pull/39270
 2021-07-05 18:23:26 +01:00
Richard Lau ef3969542d 2021-07-05, Version v14.17.3 'Fermium' (LTS) 
Notable changes:

Node.js 14.17.2 introduced a regression in the Windows installer on
non-English locales that is being fixed in this release. There is no
need to download this release if you are not using the Windows
installer.

PR-URL: https://github.com/nodejs/node/pull/39269
 2021-07-05 17:03:09 +01:00
Richard Lau cf1abe4b88 2021-07-05, Version 12.22.3 'Erbium' (LTS) 
Notable changes:

Node.js 12.22.2 introduced a regression in the Windows installer on
non-English locales that is being fixed in this release. There is no
need to download this release if you are not using the Windows
installer.

PR-URL: https://github.com/nodejs/node/pull/39268
 2021-07-05 16:50:08 +01:00
Rich Trott 68548fd661 doc: fix color contrast for anchor marks in dark mode 
Currently, in its dark mode, our website background color is #090C15 and
our anchor marks are #707070 for a contrast ratio of 3.94 to 1, falling
short of the WCAG AA 4.5 to 1. This changes the mark color in dark mode
only to #7A7A7A for a color contrast of 4.55 to 1.

PR-URL: https://github.com/nodejs/node/pull/39168
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-07-04 19:57:42 -07:00
FrankEntriken 92fde1ea70 doc: rename datatypes to data types 
PR-URL: https://github.com/nodejs/node/pull/39209
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2021-07-03 16:54:21 -07:00
Rich Trott dcea251435 doc: normalize CSS variable names and indentation 
PR-URL: https://github.com/nodejs/node/pull/39199
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-07-03 10:27:14 -07:00
Rich Trott e8b086228a doc: remove unnecessary module format comments 
Now that the docs have toggles for CJS vs. ESM, there is no need to
include a comment explaining which module type is being used.

PR-URL: https://github.com/nodejs/node/pull/39219
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-07-03 10:25:52 -07:00
Rich Trott 975bbbc443 doc: use more consistent formatting for deprecations 
Most deprecations do not end with a full-stop/period, but three of them
do. Well, not anymore after this change.

PR-URL: https://github.com/nodejs/node/pull/39218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-07-03 07:45:58 -07:00
Rich Trott 5e8aeac93f doc: use "pull request" instead of "PR" in packages.md 
PR-URL: https://github.com/nodejs/node/pull/39213
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-07-03 07:43:09 -07:00
Rich Trott 9b99037798 doc: move v8.stopCoverage() to expected location in doc 
PR-URL: https://github.com/nodejs/node/pull/39212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-03 07:41:37 -07:00
Rich Trott 9ad96e2889 doc: move vm.measureMemory() to expected location in doc 
PR-URL: https://github.com/nodejs/node/pull/39211
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2021-07-03 07:35:20 -07:00
Beth Griggs 5ba2442e82 2021-07-01, Version 16.4.1 (Current) 
This is a security release.

Notable changes:

Vulnerabilities fixed:

- **CVE-2021-22918**: libuv upgrade - Out of bounds read (Medium)
- **CVE-2021-22921**: Windows installer - Node Installer Local Privilege Escalation (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/271
 2021-07-01 15:37:30 +01:00
Richard Lau 0969b9f0e8 2021-07-01, Version 14.17.2 'Fermium' (LTS) 
This is a security release.

Notable changes:

Vulnerabilities fixed:

- **CVE-2021-22918**: libuv upgrade - Out of bounds read (Medium)
- **CVE-2021-22921**: Windows installer - Node Installer Local Privilege Escalation (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/272
 2021-07-01 14:48:10 +01:00
Richard Lau 9b7eb82a42 2021-07-01, Version 12.22.2 'Erbium' (LTS) 
This is a security release.

Notable changes:

Vulnerabilities fixed:

- **CVE-2021-22918**: libuv upgrade - Out of bounds read (Medium)
- **CVE-2021-22921**: Windows installer - Node Installer Local Privilege Escalation (Medium)
- **CVE-2021-27290**: npm upgrade - ssri Regular Expression Denial of Service (ReDoS) (High)
- **CVE-2021-23362**: npm upgrade - hosted-git-info Regular Expression Denial of Service (ReDoS) (Medium)

PR-URL: https://github.com/nodejs-private/node-private/pull/270
 2021-07-01 14:41:48 +01:00
Daniel Bevenius 7ebf36ca98 doc: add cc oss-security@lists.openwall.com 
This commit adds step to CC oss-security@lists.openwall.com as part of
the security release process.

PR-URL: https://github.com/nodejs/node/pull/39191
Refs: https://github.com/nodejs/TSC/issues/1047
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-07-01 05:37:42 +02:00
Rich Trott 88425c7ae9 doc: remove instructions for unsupported Node.js versions 
Remove special V8 maintenance instructions for versions of Node.js prior
to 9.0.0. Perform other minor edits in nearby text.

PR-URL: https://github.com/nodejs/node/pull/39185
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2021-06-30 15:28:53 -07:00
Rich Trott 593212cd2c doc: remove obsolete cc recommendations 
In 2016, Ali added the instruction to cc him on particular V8 bugs and
the suggestion to contact him for certain problems. However, I'm pretty
sure Ali has not been working on V8 for 2+ years at this point. I'm
guessing those instructions are obsolete at this point. (I'll ping him
in the PR for this change to confirm, though.)

Also: Remove a parenthetical and add a comma, because I can't imagine
opening a separate pull request to add a comma. (OK, I'm lying, I
totally can and if anyone has done that in the past, it's probably me.)

PR-URL: https://github.com/nodejs/node/pull/39181
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-06-30 15:27:46 -07:00
Rich Trott b11d3f15b3 doc: use "repository" in maintaining-V8 doc 
Use "repository" instead of "repo". This also adjusts capitalization in
a header that was already being modified to use "repository" because
even I couldn't bring myself to put that in a separate commit.

PR-URL: https://github.com/nodejs/node/pull/39179
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-06-30 15:26:10 -07:00
Rich Trott ddc60c7858 doc: fix broken link in errors.md 
PR-URL: https://github.com/nodejs/node/pull/39200
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-06-30 15:22:36 -07:00