mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 10:15:07 +08:00
Code Activity
49,265 Commits 74 Branches 969 Tags
ec7a28f2e074f0ea16ecd4d2a3511b334fa4b0de
Commit Graph
3117 Commits
Author SHA1 Message Date
Node.js GitHub Bot 37c6a1f0a3 tools: update gyp-next to 0.22.4 
PR-URL: https://github.com/nodejs/node/pull/66988
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-10-27 21:17:23 +00:00
dependabot[bot] 79c1fc4fbb tools: bump remark-preset-lint-node 
Bumps the lint-md group in /tools/lint-md with 1 update: [remark-preset-lint-node](https://github.com/nodejs/remark-preset-lint-node).

Updates `remark-preset-lint-node` from 5.1.2 to 5.2.0
- [Release notes](https://github.com/nodejs/remark-preset-lint-node/releases)
- [Commits](https://github.com/nodejs/remark-preset-lint-node/compare/v5.1.2...v5.2.0)

---
updated-dependencies:
- dependency-name: remark-preset-lint-node
  dependency-version: 5.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: lint-md
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/67023
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-27 17:31:29 +00:00
Node.js GitHub Bot 8587d711a1 tools: update nixpkgs-unstable to 901c54c08bdc20e00c2b3c73716b97497b1 
PR-URL: https://github.com/nodejs/node/pull/66994
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2026-10-27 08:13:02 +01:00
Rafael Gonzaga 7abbd56cfd doc: document the alpha release process 
Document how to prepare, version, tag and promote the Alpha releases
introduced by the new release schedule, starting with Node.js 27, and
how the first Alpha and semver-major releases are prepared with
git node release.

Refs: https://github.com/nodejs/Release/issues/1187
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/66796
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-26 16:32:08 +00:00
Antoine du Hamel 1ae40765d6 Revert "build, doc: move to redesign" 
This reverts commit 18a9ba509a.

PR-URL: https://github.com/nodejs/node/pull/67015
Refs: https://github.com/nodejs/node/issues/66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-10-26 16:08:31 +01:00
Antoine du Hamel b0cf162cec Revert "tools: bump the doc group in /tools/doc with 4 updates" 
This reverts commit df775ec2ea.

PR-URL: https://github.com/nodejs/node/pull/67015
Refs: https://github.com/nodejs/node/issues/66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-10-26 16:08:29 +01:00
Antoine du Hamel 2f8cf853db Revert "tools: bump the doc group in /tools/doc with 4 updates" 
This reverts commit 28194a3037.

PR-URL: https://github.com/nodejs/node/pull/67015
Refs: https://github.com/nodejs/node/issues/66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-10-26 16:08:29 +01:00
Antoine du Hamel ec8e19d893 Revert "tools: bump the doc group in /tools/doc with 2 updates" 
This reverts commit 2192f7f916.

PR-URL: https://github.com/nodejs/node/pull/67015
Refs: https://github.com/nodejs/node/issues/66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-10-26 16:08:28 +01:00
Antoine du Hamel 0991bdb623 Revert "tools: bump the doc group in /tools/doc with 4 updates" 
This reverts commit 1bc3cdae37.

PR-URL: https://github.com/nodejs/node/pull/67015
Refs: https://github.com/nodejs/node/issues/66571
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-10-26 16:08:27 +01:00
Filip Skokan 21cfb2a4ad build: remove the bundled FIPS provider build 
--openssl-is-fips with bundled OpenSSL never worked: the
openssl-fipsmodule target had no dependency edge, so fipsinstall's
input was produced by nothing. Repairing it would not help, since a
FIPS provider built out of tree has no validation status.

Remove the machinery and restrict --openssl-is-fips to --shared-openssl.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/64777
Fixes: https://github.com/nodejs/node/issues/56733
Refs: https://github.com/nodejs/node/pull/64211
Refs: https://github.com/nodejs/node/pull/63966
Refs: https://github.com/nodejs/node/pull/53329
Refs: https://github.com/nodejs/node/pull/48950
Refs: https://github.com/nodejs/node/issues/45465
Refs: https://github.com/nodejs/node/issues/42827
Refs: https://github.com/nodejs/node/issues/47076
Refs: https://github.com/nodejs/node/pull/62862
Refs: https://github.com/nodejs/node/pull/38512
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
 2026-10-25 22:36:35 +01:00
Filip Skokan ee9ae88636 test,tools: drop OpenSSL 1.x-era FIPS leftovers 
The openssl_fips_*.cnf fixtures use OpenSSL 1.x syntax, and their test
branches can no longer run. Remove the fixtures and related version
gates while keeping the provider-backed FIPS assertions.

get_env_type() sniffed for a "-fips" version suffix that can no longer
occur, and the crypto-check lint rule listed a helper that no longer
exists.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/64777
Fixes: https://github.com/nodejs/node/issues/56733
Refs: https://github.com/nodejs/node/pull/64211
Refs: https://github.com/nodejs/node/pull/63966
Refs: https://github.com/nodejs/node/pull/53329
Refs: https://github.com/nodejs/node/pull/48950
Refs: https://github.com/nodejs/node/issues/45465
Refs: https://github.com/nodejs/node/issues/42827
Refs: https://github.com/nodejs/node/issues/47076
Refs: https://github.com/nodejs/node/pull/62862
Refs: https://github.com/nodejs/node/pull/38512
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
 2026-10-25 22:36:34 +01:00
Filip Skokan 34e3b90621 build: require OpenSSL 3 or later 
configure now fails when --shared-openssl points at OpenSSL 1.x rather
than failing later at compile or link time. The check skips BoringSSL,
whose version macros claim 1.1.1.

Stop setting the OpenSSL 1.1 API compatibility level for bundled builds.
ncrypto selects the supported API level directly.

Update the assembler capability check, shared-library test matrix,
package fallbacks, and internal version-number typing for the new
baseline.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/64777
Fixes: https://github.com/nodejs/node/issues/56733
Refs: https://github.com/nodejs/node/pull/64211
Refs: https://github.com/nodejs/node/pull/63966
Refs: https://github.com/nodejs/node/pull/53329
Refs: https://github.com/nodejs/node/pull/48950
Refs: https://github.com/nodejs/node/issues/45465
Refs: https://github.com/nodejs/node/issues/42827
Refs: https://github.com/nodejs/node/issues/47076
Refs: https://github.com/nodejs/node/pull/62862
Refs: https://github.com/nodejs/node/pull/38512
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
 2026-10-25 22:36:29 +01:00
Filip Skokan a2ce2c6def tls,tools: update BoringSSL pin and TLS errors 
Use BoringSSL 0.20261020.0 for shared-library builds and expose the
package wrapper's version to the matrix updater.

The new verifier no longer emits UNABLE_TO_VERIFY_LEAF_SIGNATURE
after Node's verification callback accepts a missing-issuer error.
Expect UNABLE_TO_GET_ISSUER_CERT_LOCALLY for the affected leaf
certificates and suggest --use-system-ca for that error.

Drop the SSL_get_server_tmp_key() fallback now that BoringSSL supplies
SSL_get_peer_tmp_key() as a compatibility stub.

Refs: https://boringssl-review.googlesource.com/c/boringssl/+/103849
Refs: https://github.com/electron/electron/pull/55110/changes/b457e70e339e8bb3066b210edfb6f96582cdb374
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/66922
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-10-24 22:04:13 +00:00
Filip Skokan b12bad4b11 build,deps,tools: prepare to update to OpenSSL 4.1 
Update the updater script and files under `deps/openssl/config` in
preparation for updating `deps/openssl` to OpenSSL 4.1.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/66758
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-23 23:47:23 +00:00
Chengzhong Wu ca277a6294 build,test: setup perfetto tests on windows build 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/66731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-10-23 22:01:33 +00:00
Lazizbek Ergashev 03cca65be3 src: fix build with --shared-brotli 
Assisted-by: Claude Code
Signed-off-by: lazerg <lazerg2@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66895
Fixes: https://github.com/nodejs/node/issues/66894
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-23 13:23:50 +00:00
Antoine du Hamel 5741b0ed04 build: error on incompatible quic configure flags 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66893
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-10-23 10:35:37 +00:00
StefanStojanovicandChengzhong Wu 4c294b3b27 build,win: fix Perfetto 
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Co-Authored-By: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/66876
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
 2026-10-23 10:09:22 +02:00
Antoine du Hamel d1ed17b708 build: remove default values for libname 
By setting a default value, we override the pkg-config value,
which is inconsistent with the other `--shared-*` flags.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66790
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-10-23 00:34:45 +02:00
Antoine du Hamel 6209c29dcf tools: disable error-on-warn on x64 macOS 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66925
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
 2026-10-22 14:48:22 +02:00
Antoine du Hamel a232998e0d tools: add --error-on-warn configure flag in test-shared.yml 
Given that this workflow compiles V8 and other libs separately, that
would allow us to detect any Node.js-specific warning that needs to be
addressed.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66751
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-10-22 10:18:19 +02:00
Ved Chaudhari 28b50fb016 build,win: fail fast in vcbuild without cargo 
On Windows, configure.py returns from check_compiler() before it gets
to the cargo and rustc check, so Temporal stays enabled even when no
Rust toolchain is installed. The build then runs for a long time and
fails in node_crates.vcxproj with MSB8066.

Check for cargo in vcbuild.bat before configuring and building, in the
same places deps/crates/cargo_build.py looks, and stop with a message
pointing to BUILDING.md. The check is skipped for nobuild, clean, and
when Temporal is disabled or provided as a shared library.

Assisted-by: a closed-source coding agent
Signed-off-by: vedchaudhari <vedc2853@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66858
Fixes: https://github.com/nodejs/node/issues/66848
Refs: https://github.com/nodejs/node/issues/63451
Reviewed-By: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-10-21 17:51:42 +00:00
Evgenii Kliuchnikov 8c5debbea4 deps: brotli: cherry-pick 0ed4268a4401abcb44720963 
Original commit message:

  Detect and report invalid stream earlier.

  PiperOrigin-RevId: 876198329

PR-URL: https://github.com/nodejs-private/node-private/pull/1002
Fixes: https://hackerone.com/reports/4107681
Refs: https://github.com/google/brotli/commit/0ed4268a4401abcb4472096340477cf4af7d1a2b
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
CVE-ID: CVE-2026-111497
 2026-10-21 13:00:47 +02:00
Antoine du Hamel 796a83a7ce build: do not pass vendored headers when building against shared libs 
And setup `test-shared.yml` so we can detect regressions.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66844
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-10-21 09:59:53 +02:00
Antoine du Hamel 678c5551b2 tools: reenable openssl 1.1.x and 3.0.x on test-shared.yml 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66711
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-10-20 18:59:14 +00:00
Antoine du Hamel ae223417d9 crypto: update root certificates to NSS 3.131.1 
This is the certdata.txt[0] from NSS 3.131.1.

Certificates removed:
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3

[0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_131_1_RTM/lib/ckfw/builtins/certdata.txt
a749e413-a6b5-45ca-827d-a943355e84c8

PR-URL: https://github.com/nodejs/node/pull/66877
Refs: https://groups.google.com/a/mozilla.org/g/dev-tech-crypto/c/vSxZxnOMMvs
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
 2026-10-20 18:57:03 +02:00
Ryan Aslett 1b5fc1479a tools: retry Gatekeeper check and stapling after notarization 
Apple's ticket service can lag behind notarytool reporting
"Accepted", which makes the spctl assessment fail with
"source=Unnotarized Developer ID" even though the package was
notarized. Retry spctl and stapler with exponential backoff
(up to ~7.5 minutes) before failing, and fail the script if
stapling does not succeed instead of ignoring its exit status.

Refs: https://github.com/nodejs/build/issues/4527
Signed-off-by: Ryan Aslett <raslett@linuxfoundation.org>
PR-URL: https://github.com/nodejs/node/pull/66855
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-20 13:48:24 +00:00
Node.js GitHub Bot d7b6fee8cc tools: update nixpkgs-unstable to f20cd90e28fe0403873f473b29e42662cd8 
PR-URL: https://github.com/nodejs/node/pull/66819
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2026-10-20 01:15:33 +00:00
Murat Kirazkaya 8175dc3c05 tools: add lint rule for unread benchmark n 
If a benchmark declares `n` in its configs, main() must read it.
nodejs/node#59872 renamed a config key from `num` to `n` but left
`{ num: n }` in main(), so `n` resolved to undefined and the
benchmark silently reported near-zero results until #62084 fixed
it.

The rule also found `async_hooks/async-resource-vs-destroy.js`,
which has declared `n: [1e6]` since it was added but never read
it. Remove the unused key.

Refs: https://github.com/nodejs/node/pull/59872
Refs: https://github.com/nodejs/node/pull/62084
Signed-off-by: Murat Kirazkaya <groophylifefor@gmail.com>
Assisted-by: Claude Code
PR-URL: https://github.com/nodejs/node/pull/66807
Refs: https://github.com/nodejs/performance/issues/187
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2026-10-19 15:51:08 +00:00
dependabot[bot] 1bc3cdae37 tools: bump the doc group in /tools/doc with 4 updates 
Bumps the doc group in /tools/doc with 4 updates: [@doc-kit/cli](https://github.com/nodejs/doc-kit/tree/HEAD/packages/cli), [@doc-kit/generator-react](https://github.com/nodejs/doc-kit/tree/HEAD/packages/react), [@node-core/doc-kit](https://github.com/nodejs/doc-kit/tree/HEAD/packages/node) and [@node-core/doc-kit-legacy](https://github.com/nodejs/doc-kit/tree/HEAD/packages/node-legacy).

Updates `@doc-kit/cli` from 1.0.4 to 1.0.5
- [Release notes](https://github.com/nodejs/doc-kit/releases)
- [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/cli/CHANGELOG.md)
- [Commits](https://github.com/nodejs/doc-kit/commits/@doc-kit/cli@1.0.5/packages/cli)

Updates `@doc-kit/generator-react` from 0.4.2 to 0.5.0
- [Release notes](https://github.com/nodejs/doc-kit/releases)
- [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/react/CHANGELOG.md)
- [Commits](https://github.com/nodejs/doc-kit/commits/@doc-kit/generator-react@0.5.0/packages/react)

Updates `@node-core/doc-kit` from 2.0.5 to 2.0.6
- [Release notes](https://github.com/nodejs/doc-kit/releases)
- [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/node/CHANGELOG.md)
- [Commits](https://github.com/nodejs/doc-kit/commits/@node-core/doc-kit@2.0.6/packages/node)

Updates `@node-core/doc-kit-legacy` from 1.0.4 to 1.1.0
- [Release notes](https://github.com/nodejs/doc-kit/releases)
- [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/node-legacy/CHANGELOG.md)
- [Commits](https://github.com/nodejs/doc-kit/commits/@node-core/doc-kit-legacy@1.1.0/packages/node-legacy)

---
updated-dependencies:
- dependency-name: "@doc-kit/cli"
  dependency-version: 1.0.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: doc
- dependency-name: "@doc-kit/generator-react"
  dependency-version: 0.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: doc
- dependency-name: "@node-core/doc-kit"
  dependency-version: 2.0.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: doc
- dependency-name: "@node-core/doc-kit-legacy"
  dependency-version: 1.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: doc
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/66798
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2026-10-19 08:36:58 +00:00
Filip Skokan e2d5522773 tools: tolerate non-UTF-8 test output 
Non-UTF-8 bytes in captured test output cause Execute() to raise
UnicodeDecodeError. CI reports can then attribute the failure to an
earlier, expected "Error: uncaught" message from a passing cctest.

Replace malformed UTF-8 in stdout and stderr so the runner reports test
results while preserving the child process exit status.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-10-16.md
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
PR-URL: https://github.com/nodejs/node/pull/66783
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2026-10-18 07:18:16 +00:00
Jiawen Geng 87db28b6ba build: remove nonexistent header from abseil.gyp 
This header was removed in the V8 15.2 update, but its entry was left
behind in the gyp source list.

Signed-off-by: Jiawen Geng <technicalcute@gmail.com>
Assisted-by: claude:opus-5.5
PR-URL: https://github.com/nodejs/node/pull/66583
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-10-14 05:35:27 +00:00
Node.js GitHub Bot d8d598b6d0 tools: update nixpkgs-unstable to 8edc0c72e3a38faf5434e40d1f19431125f 
PR-URL: https://github.com/nodejs/node/pull/66497
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2026-10-12 00:27:53 +02:00
dependabot[bot] 2192f7f916 tools: bump the doc group in /tools/doc with 2 updates 
Bumps the doc group in /tools/doc with 2 updates: [@doc-kit/generator-react](https://github.com/nodejs/doc-kit/tree/HEAD/packages/react) and [@node-core/doc-kit](https://github.com/nodejs/doc-kit/tree/HEAD/packages/node).

Updates `@doc-kit/generator-react` from 0.4.0 to 0.4.2
- [Release notes](https://github.com/nodejs/doc-kit/releases)
- [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/react/CHANGELOG.md)
- [Commits](https://github.com/nodejs/doc-kit/commits/@doc-kit/generator-react@0.4.2/packages/react)

Updates `@node-core/doc-kit` from 2.0.4 to 2.0.5
- [Release notes](https://github.com/nodejs/doc-kit/releases)
- [Changelog](https://github.com/nodejs/doc-kit/blob/main/packages/node/CHANGELOG.md)
- [Commits](https://github.com/nodejs/doc-kit/commits/@node-core/doc-kit@2.0.5/packages/node)

---
updated-dependencies:
- dependency-name: "@doc-kit/generator-react"
  dependency-version: 0.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: doc
- dependency-name: "@node-core/doc-kit"
  dependency-version: 2.0.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: doc
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/66632
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-10-11 18:55:43 +00:00
Antoine du Hamel ae5a0f40b5 tools: switch to PGP and SHA256 in ICU updater 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66469
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
 2026-10-09 23:50:12 +00:00
inoway46 7514ef8caf build: remove deleted V8 headers from metadata inputs 
Remove two inline headers deleted by the V8 15.2 update from the
postmortem-metadata inputs. Their remaining references prevent Ninja
from building the target.

Assisted-by: Codex
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66531
Refs: https://github.com/nodejs/node/pull/65161
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2026-10-07 16:08:46 -04:00
Richard Lau 60c7958b8e build: update flags for V8 CI 
Continue to use torque for now instead of metagen.
Sync unsupported clang flags with upstream builds.

Refs: https://github.com/ibmruntimes/v8-build/blob/main/bin/v8.sh
Signed-off-by: Richard Lau <richard.lau@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/66537
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2026-10-07 18:54:57 +00:00
Joyee Cheung 05c9b89d42 build: disable V8_USE_METAGEN_INSTANCE_TYPES 
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66537
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2026-10-07 18:54:55 +00:00
Joyee Cheung 18077b5d3a build: do not match v8_libplatform_headers when scraping sources 
Otherwise the target contains undefined symbols because there are
only header files in the list.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66537
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2026-10-07 18:54:53 +00:00
Shelley Vohr 06c6e36ee5 tools: lint thread_local in src 
Several Environments can share a thread, so state in src/ that belongs
to one of them cannot be kept in a thread_local. Add a cpplint rule
that rejects thread_local in src/ unless the declaration is marked with
NOLINTNEXTLINE(runtime/thread_local), and mark the existing uses, which
are per-thread by design.

Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66411
Refs: https://github.com/nodejs/node/pull/66239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2026-10-07 10:56:09 +00:00
Filipe Oliveira (Redis) a2b4f55d5b tools: copy hdr_histogram_internal.h in update-histogram.sh 
HdrHistogram_c 0.12.0 added a private header,
src/hdr_histogram_internal.h, which src/hdr_tests.h now includes.
update-histogram.sh copies a fixed list of files, so the automated
update to 0.12.0 would leave deps/histogram without it and fail to
compile. Add the header to the list.

Signed-off-by: fcostaoliveira <filipe@redis.com>
PR-URL: https://github.com/nodejs/node/pull/66528
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-10-07 09:51:15 +00:00
Node.js GitHub Bot 01008ba75d crypto: update root certificates to NSS 3.129 
This is the certdata.txt[0] from NSS 3.129.

This is the version of NSS that shipped in Firefox 157.0 on 2026-09-29.

[0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_129_RTM/lib/ckfw/builtins/certdata.txt

PR-URL: https://github.com/nodejs/node/pull/66496
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2026-10-06 01:39:42 +00:00
Joyee Cheung 88ec31414c Revert "deps,lib,tools: remove jitless and lite modes" 
Newer version of V8 no longer supports
--allow-overwriting-for-next-flag and there's no way to
override the preset flag now. Revert the commit to allow
users to opt-in into the flags if still necessary.

This reverts commit 7e39b8781a.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66516
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2026-10-05 11:25:07 +00:00
Joyee Cheung 1eead123e2 tools: increase constexpr step limit for MSVC STL 
When compiling with MSVC STL, the computation in V8 can exceed
the default limit of constexpr steps. Increasing it by 4 times to
give it more room.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:40:49 +02:00
StefanStojanovic ea86967557 build,win: do not quote cmd arguments 
Otherwise torque fails because the command was too long
(over 8192 characters).

Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:40:47 +02:00
Chengzhong Wu 30074a3cc8 build: fix cppgc_base perfetto source scraper 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:38:35 +02:00
Joyee Cheung b356886269 build: use ICU_UTIL_DATA_STATIC across V8 
ICU_UTIL_DATA_SHARED had been removed since
https://crrev.com/c/1513615, but Node.js still defined
it and relied on the removed path on Windows, so the ICU
initialization in mksnapshot had been silently failing
since then. https://crrev.com/c/7679153 made the failure
visible so the build started breaking on Windows. Fix it
by always using ICU_UTIL_DATA_STATIC since we already compile
the ICU data statically in.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:38:28 +02:00
Michaël Zasso 6d854b7338 tools: update V8 gypfiles for 15.1 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:38:10 +02:00
Michaël ZassoandJoyee Cheung 84de78ad23 tools: update V8 gypfiles for 15.0 
Co-Authored-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:38:06 +02:00
Michaël Zasso 60c6de2540 tools: update V8 gypfiles for 14.9 
Signed-Off-By: Michaël Zasso <targos@protonmail.com>
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65161
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-10-04 22:38:04 +02:00