mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-29 18:53:26 +08:00
Code Activity
33,270 Commits 59 Branches 971 Tags
bcb85adee603ccac68f675e94de4f7aa34e99aff
Commit Graph
13 Commits
Author SHA1 Message Date
Antoine du Hamel 839976669f tools: add support for mjs and cjs JS snippet linting 
Refs: https://github.com/nodejs/node/pull/37162
Refs: https://github.com/nodejs/remark-preset-lint-node/pull/176

PR-URL: https://github.com/nodejs/node/pull/37311
Refs: https://github.com/eslint/eslint-plugin-markdown/pull/172
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-06-11 09:30:18 +02:00
bcoe ee444473e9 errors: display original symbol name 
If symbol names array has been populated in source map, include
original symbol name in error message.

Fixes https://github.com/nodejs/node/issues/35325

PR-URL: https://github.com/nodejs/node/pull/36042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-06-11 09:29:17 +02:00
bcoe eee1d291cf module: refactor to use iterable-weak-map 
Using an iterable WeakMap (a data-structure that uses WeakRef and
WeakMap), we are able to: stop relying on Module._cache to
serialize source maps; stop requiring an error object when calling
findSourceMap().

PR-URL: https://github.com/nodejs/node/pull/35915
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-05-16 13:56:12 +02:00
Antoine du Hamel ad80e3de1e doc: fix 404 links in module.md 
PR-URL: https://github.com/nodejs/node/pull/37202
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-05-01 12:25:04 +02:00
Bruce A. MacNaughton 5770ae057e doc: fix module syncBuiltinESMExports example 
Fix failing code and add explanations of each assert.

PR-URL: https://github.com/nodejs/node/pull/34284
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-05-01 12:24:52 +02:00
Antoine du Hamel 7c9f3a9d0c doc: fix module.isPreloading documentation 
Fixes: https://github.com/nodejs/node/issues/36775

PR-URL: https://github.com/nodejs/node/pull/36944
Backport-PR-URL: https://github.com/nodejs/node/pull/36988
Refs: https://github.com/nodejs/node/pull/36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-25 08:22:22 +02:00
James M Snell 2413907a12 module: add isPreloading indicator 
Adds a `module.isPreloading` property that is `true` only during the
preload (`-r`) phase of Node.js bootstrap. This provides modules an
easy, non-hacky way of knowing if they are being loaded during preload.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36263
Backport-PR-URL: https://github.com/nodejs/node/pull/36988
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-25 08:22:12 +02:00
Antoine du Hamel ce789f1ca4 doc: use .md extension for internal links 
This helps catch broken links as part of the test suite. This also
improves the user experience when browsing the markdown files.

PR-URL: https://github.com/nodejs/node/pull/35191
Fixes: https://github.com/nodejs/node/issues/35189
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-10-06 11:54:24 -04:00
Rich Trott 1cf9934e4e doc: make minor improvements to module.md 
* sort references in ASCII order
* replace abbreviation
* split comma splice into two sentences and add appropriate punctuation
* replace future tense with present tense

PR-URL: https://github.com/nodejs/node/pull/35083
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2020-09-17 10:36:38 -04:00
Antoine du HAMEL 1a9ca52716 doc: add ESM examples in module API doc page 
PR-URL: https://github.com/nodejs/node/pull/34875
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2020-09-07 12:29:45 -04:00
Antoine du HAMEL bf7f492cb6 doc: rename module pages 
Using a "Modules:" prefix groups all the related pages together when
using alphabetical order.

Refs: https://github.com/nodejs/modules/issues/539

PR-URL: https://github.com/nodejs/node/pull/34663
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-08-24 12:19:59 +01:00
Rich Trott ef41ddf5cb doc: sort references lexically 
Keep references sorted in ASCII order in module.md.

PR-URL: https://github.com/nodejs/node/pull/34848
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
 2020-08-24 12:19:11 +01:00
Antoine du HAMEL 34430abd71 doc: move module core module doc to separate page 
The `module` core module is available for both CJS and ESM users, it
deserves its own page.

PR-URL: https://github.com/nodejs/node/pull/34747
Refs: https://github.com/nodejs/modules/issues/539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-08-20 15:05:23 +01:00