6 Commits
Author SHA1 Message Date
Ben Smith ed0d939dbc test: remove --harmony-sharedarraybuffer usage
This flag has been enabled by default since v8
7662e0634c3a057fa5d746912ee5af76e285c274.

Backport-PR-URL: https://github.com/nodejs/node/pull/21717
PR-URL: https://github.com/nodejs/node/pull/16343
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2018-08-16 11:38:51 +10:00
Rafal Leszczynski 36a0d3f0b1 test: cleanup test-buffer-sharedarraybuffer
remove third argument `0` from calls to `assert.deepStrictEqual`

PR-URL: https://github.com/nodejs/node/pull/15896
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2017-10-11 02:06:09 -04:00
James M Snell 91e96d8f08 lib,src: fix consistent spacing inside braces
PR-URL: #14162
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-09-20 12:32:17 -07:00
lena df3c2929b9 test: remove unnecessary require('buffer').Buffer
Remove unnecessary imports from:

* test/parallel/test-buffer-nopendingdep-map.js
* test/parallel/test-buffer-pending-deprecation.js
* test/parallel/test-buffer-sharedarraybuffer.js
* test/parallel/test-buffer-slow.js
* test/parallel/test-buffer-tojson.js
* test/parallel/test-buffer-zero-fill.js

Refs: https://github.com/nodejs/node/issues/13836
PR-URL: https://github.com/nodejs/node/pull/13851
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-07-18 19:56:38 +02:00
Ojas Shirekar 2154bc89d8 buffer: fix check for .buffer property
isSharedArrayBuffer in fromObject was missing obj.buffer
moved the 'length' in obj check so that it is checked first making
the code slightly more performant and able to handle SharedArrayBuffer
without relying on an explicit check.

Ref: https://github.com/nodejs/node/pull/8510
PR-URL: https://github.com/nodejs/node/pull/8739
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2016-10-07 00:57:35 +02:00
Ojas Shirekar 2a2ec9dbc3 buffer: add isSharedArrayBuffer checks
Fixes: https://github.com/nodejs/node/issues/8440
PR-URL: https://github.com/nodejs/node/pull/8510
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2016-09-17 04:55:09 -04:00