50 Commits
Author SHA1 Message Date
Shelley Vohr 6f38736d63 build: allow linking shared dependencies in the GN build
The GN build always compiles the bundled copies of brotli, c-ares,
HdrHistogram, llhttp, libuv, nghttp2, SQLite and zstd, so anyone
packaging a GN-built Node.js for a Linux distribution has no
counterpart to configure's --shared-* options.

Add node_shared_* args named after the GYP variables. When one is set,
that dependency's GN template defines its target as a group carrying a
pkg-config config instead of the bundled sources, so every existing
"deps/<name>" reference picks up the system library without further
changes, and config.gypi reports the choice like a GYP build does.

Refs: https://github.com/nodejs/node/pull/55903
Signed-off-by: Shelley Vohr <shelley.vohr@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65797
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2026-09-07 07:19:20 +00:00
Node.js GitHub Bot 5cbedc0e40 deps: update nghttp2 to 1.70.0
PR-URL: https://github.com/nodejs/node/pull/64939
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2026-08-04 01:01:02 +00:00
Node.js GitHub Bot 5320a1b96f deps: update nghttp2 to 1.69.0
PR-URL: https://github.com/nodejs/node/pull/62891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2026-04-29 12:30:00 +00:00
Antoine du Hamel fb2a02f1d1 deps: nghttp2: revert 7784fa979d0b
This commit reverts "Make error handling robust".
Without this revert, we are getting timeouts, crashes, and different
error codes in `parallel/test-http2-*`.

Refs: https://github.com/nghttp2/nghttp2/commit/7784fa979d0bcf801a35f1afbb25fb048d815cd7
Refs: https://github.com/nodejs/node/issues/60661
PR-URL: https://github.com/nodejs/node/pull/61136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2025-12-23 01:08:49 +00:00
nodejs-github-bot 1d54921552 deps: update nghttp2 to 1.68.0
PR-URL: https://github.com/nodejs/node/pull/61136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2025-12-23 01:08:49 +00:00
Antoine du Hamel 408aba6190 deps: nghttp2: revert 7784fa979d0b
This commit reverts "Make error handling robust".
Without this revert, we are getting timeouts, crashes, and different
error codes in `parallel/test-http2-*`.

Refs: https://github.com/nghttp2/nghttp2/commit/7784fa979d0bcf801a35f1afbb25fb048d815cd7
PR-URL: https://github.com/nodejs/node/pull/59790
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2025-11-10 12:46:10 +01:00
nodejs-github-bot 43eb6cb581 deps: update nghttp2 to 1.67.1
PR-URL: https://github.com/nodejs/node/pull/59790
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2025-11-10 12:46:08 +01:00
James M Snell 65a32bac18 deps: add ngtcp2 test binaries
The goal here is to add the ngtcp2 client and server
samples so that we can use them in CI to test our QUIC
implementation.

PR-URL: https://github.com/nodejs/node/pull/59946
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-09-27 12:17:49 -07:00
Node.js GitHub Bot 745f48d9f3 deps: update nghttp2 to 1.66.0
PR-URL: https://github.com/nodejs/node/pull/58786
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-06-24 01:04:25 +00:00
Node.js GitHub Bot d74daeab96 deps: update nghttp2 to 1.65.0
PR-URL: https://github.com/nodejs/node/pull/57269
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-06-07 09:30:45 +00:00
Node.js GitHub Bot ece37bc88c deps: update nghttp2 to 1.64.0
PR-URL: https://github.com/nodejs/node/pull/55559
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-10-29 02:11:33 +00:00
Shelley Vohr c35cbcde4b build: fix GN build for sqlite and nghttp2
PR-URL: https://github.com/nodejs/node/pull/55529
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Cheng Zhao <zcbenz@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-10-27 09:21:39 +00:00
Node.js GitHub Bot beabcec41c deps: update nghttp2 to 1.63.0
PR-URL: https://github.com/nodejs/node/pull/54589
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-08-29 10:15:03 +00:00
Node.js GitHub Bot 4648185867 deps: update nghttp2 to 1.62.1
PR-URL: https://github.com/nodejs/node/pull/52966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-06-06 14:30:24 +00:00
Node.js GitHub Bot 0ab891aeb8 deps: update nghttp2 to 1.62.0
PR-URL: https://github.com/nodejs/node/pull/52966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-06-06 14:30:24 +00:00
Node.js GitHub Bot 59d6725ef2 deps: update nghttp2 to 1.61.0
PR-URL: https://github.com/nodejs/node/pull/52395
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-04-16 21:22:12 +00:00
Node.js GitHub Bot 7f0b80525a deps: update nghttp2 to 1.60.0
PR-URL: https://github.com/nodejs/node/pull/51948
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-03-05 00:45:17 +00:00
Node.js GitHub Bot 68885d5126 deps: update nghttp2 to 1.59.0
PR-URL: https://github.com/nodejs/node/pull/51581
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2024-02-01 15:48:53 +00:00
Cheng Zhao df16c69983 doc: the GN files should use Node's license
PR-URL: https://github.com/nodejs/node/pull/50694
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
2023-12-28 20:27:05 +00:00
Cheng Zhao 32af45d241 build: add GN build files
PR-URL: https://github.com/nodejs/node/pull/47637
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-11-11 09:51:05 +00:00
Node.js GitHub Bot 9e30518107 deps: update nghttp2 to 1.58.0
PR-URL: https://github.com/nodejs/node/pull/50441
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-11-02 07:22:34 +00:00
James M Snell dc1c50b6e5 deps: update nghttp2 to 1.57.0
PR-URL: https://github.com/nodejs/node/pull/50121
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2023-10-11 17:00:54 +00:00
Node.js GitHub Bot c177ac0a7d deps: update nghttp2 to 1.56.0
PR-URL: https://github.com/nodejs/node/pull/49582
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-09-17 18:22:51 +00:00
Node.js GitHub Bot 6515b3ba65 deps: update nghttp2 to 1.55.1
PR-URL: https://github.com/nodejs/node/pull/48790
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-07-17 17:54:55 +00:00
Node.js GitHub Bot f9737b1b8c deps: update nghttp2 to 1.55.0
PR-URL: https://github.com/nodejs/node/pull/48746
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2023-07-14 09:37:47 +00:00
Node.js GitHub Bot 3538e1bcde deps: update nghttp2 to 1.53.0
PR-URL: https://github.com/nodejs/node/pull/47997
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2023-05-18 13:59:03 +00:00
Cheng Zhao 0d575fe61a gyp: put filenames in variables
PR-URL: https://github.com/nodejs/node/pull/46965
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2023-03-18 10:24:38 +01:00
Michaël Zasso 1aed454342 deps: update nghttp2 to 1.52.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.52.0
PR-URL: https://github.com/nodejs/node/pull/46636
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2023-02-22 17:21:46 +00:00
Yagiz Nizipli 1a83ad6a69 deps: update nghttp2 to 1.51.0
PR-URL: https://github.com/nodejs/node/pull/45537
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-11-25 11:07:40 +00:00
Yash Ladha 135fa65010 deps: update nghttp2 to 1.47.0
Added script to update nghttp2 in future. One can use
```sh
$ ./tools/update-nghttp2.sh 1.47.0
```

It will automatically copy and update the nghttps in deps.

Fixes: https://github.com/nodejs/node/issues/42089

PR-URL: https://github.com/nodejs/node/pull/42127
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-02-27 12:28:04 +00:00
thunder-coding 43291b98ed deps: update nghttp2 to v1.45.1
PR-URL: https://github.com/nodejs/node/pull/40206
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2021-09-27 02:34:00 +00:00
Michaël Zasso 6b18987033 deps: update nghttp2 to 1.42.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.42.0

PR-URL: https://github.com/nodejs/node/pull/36842
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-01-11 08:15:16 +01:00
James M Snell d3beb50da3 deps: update nghttp2 to 1.41.0
Fixes: https://hackerone.com/reports/446662
CVE-ID: CVE-2020-11080
PR-URL: https://github.com/nodejs-private/node-private/pull/204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2020-06-02 20:35:51 +02:00
gengjiawen 7ae13c360b deps: update nghttp2 to 1.40.0
PR-URL: https://github.com/nodejs/node/pull/30493
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2019-11-18 15:45:52 +01:00
Anna Henningsen fd148d38d2 deps: update nghttp2 to 1.39.2
This includes mitigations for CVE-2019-9512/CVE-2019-9515.

PR-URL: https://github.com/nodejs/node/pull/29122
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2019-08-15 09:50:14 +02:00
gengjiawen 447947aef4 deps: update nghttp2 to 1.39.1
PR-URL: https://github.com/nodejs/node/pull/28448
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2019-07-21 21:22:17 -07:00
Sam Roberts 90cf2d5f00 deps: use nghttp2's config.h on all platforms
Fix warnings about use of htonl(), etc. by including config.h for all
platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore
including <arpa/inet.h>, which defines the host to network byte order
conversion functions.

PR-URL: https://github.com/nodejs/node/pull/27283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
2019-04-22 12:08:17 -07:00
gengjiawen 2161690024 deps: update nghttp2 to 1.38.0
PR-URL: https://github.com/nodejs/node/pull/27295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
2019-04-22 22:44:15 +08:00
gengjiawen 5c2ee4ee8d deps: update nghttp2 to 1.37.0
PR-URL: https://github.com/nodejs/node/pull/26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2019-04-03 22:18:17 +08:00
James M Snell 8290015d0a deps: update nghttp2 to 1.34.0
Key new feature: RFC 8441 `:protocol` support

PR-URL: https://github.com/nodejs/node/pull/23284
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2018-10-08 08:41:18 -07:00
Anna Henningsen e007166009 deps: update to nghttp2 1.33.0
Refs: https://github.com/nghttp2/nghttp2/releases/tag/v1.33.0

PR-URL: https://github.com/nodejs/node/pull/22649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2018-09-05 10:43:09 +02:00
James M Snell 01bc5713f9 deps: update to nghttp2 1.32.0
This fixes CVE-2018-1000168.

PR-URL: https://github.com/nodejs-private/node-private/pull/117
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
2018-06-12 20:46:55 -04:00
Anna Henningsen 93bbe4e3ee deps,src: align ssize_t ABI between Node & nghttp2
Previously, we performed casts that are considered undefined behavior.
Instead, just define `ssize_t` for nghttp2 the same way we define it
for the rest of Node.

Also, remove a TODO comment that would probably also be *technically*
correct but shouldn’t matter as long as nobody is complaining.

PR-URL: https://github.com/nodejs/node/pull/18565
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2018-02-10 14:39:54 +01:00
James M Snell cfca536d8f deps: update nghttp2 to 1.29.0
PR-URL: https://github.com/nodejs/node/pull/17908
Refs: https://github.com/nodejs/node/issues/17746
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2017-12-30 10:02:40 -08:00
Ben Noordhuis 3c777bb37f deps: define BUILDING_NGHTTP2 during nghttp2 build
Define BUILDING_NGHTTP2 in order that NGHTTP2_EXTERN is properly defined
when building the nghttp2 static library.

Move NGHTTP2_STATICLIB out of node.gyp because it is a property of the
nghttp2 static library, not the node executable.

PR-URL: https://github.com/nodejs/node/pull/15487
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-09-24 12:17:03 -03:00
Anna Henningsen 97d34ddf56 deps: fixup nghttp2 version number
PR-URL: https://github.com/nodejs/node/pull/14955
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2017-08-24 01:27:06 +02:00
Anna Henningsen eb680964b4 deps: update nghttp2 to v1.25.0
PR-URL: https://github.com/nodejs/node/pull/14955
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2017-08-24 01:26:42 +02:00
Anna Henningsen 0d9afa0288 deps: cherry-pick eb306f463e from nghttp2 upstream
Original commit message:

  lib: add nghttp2_rcbuf_is_static()

  Add a `nghttp2_rcbuf_is_static()` method to tell whether a rcbuf
  is statically allocated.

  This can be useful for language bindings that wish to avoid
  creating duplicate strings for these buffers; concretely, I am
  planning to use this in the Node HTTP/2 module that is being
  introduced.

Ref: https://github.com/nghttp2/nghttp2/commit/eb306f463efea645de611de2bff0a8f823deb048
PR-URL: https://github.com/nodejs/node/pull/14808
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
2017-08-17 22:54:28 +02:00
Anna Henningsen afe68c1868 deps,tools: add missing nghttp2 license
Add `COPYING` from `nghttp2` and register it in
`tools/license-builder.sh`.

Also run `tools/license-builder.sh` and commit the
resulting `LICENSE` file.

Ref: https://github.com/nghttp2/nghttp2/blob/master/COPYING
PR-URL: https://github.com/nodejs/node/pull/14806
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2017-08-14 17:22:15 +02:00
James M Snell 71a1876f6c deps: add nghttp2 dependency
PR-URL: https://github.com/nodejs/node/pull/14239
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2017-08-04 12:55:39 -07:00