mirrors/node
0
0 Fork 0
mirror of https://github.com/nodejs/node.git synced 2026-10-28 18:25:13 +08:00
Code Activity
49,248 Commits 74 Branches 969 Tags
dependabot/github_actions/actions/setup-python-7.1.0
Commit Graph
32 Commits
Author SHA1 Message Date
Antoine du Hamel 796a83a7ce build: do not pass vendored headers when building against shared libs 
And setup `test-shared.yml` so we can detect regressions.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66844
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-10-21 09:59:53 +02:00
Antoine du Hamel 14e8f5bca4 tools: enable temporal by default in Nix integration 
So we can test it with `test-shared.yml`.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/66267
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
 2026-09-26 22:45:17 +00:00
Chengzhong Wu e7d8ab529b test: enable trace_events tests with perfetto 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/66068
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2026-09-24 17:30:20 +00:00
Antoine du Hamel eb40425de7 tools: disable fortify warnings in test-shared 
PR-URL: https://github.com/nodejs/node/pull/66020
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-09-18 17:45:02 +02:00
Antoine du Hamel f4db18ecf2 tools: clean up handling of shared libs in shell.nix 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65891
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
 2026-09-18 15:39:27 +00:00
Antoine du Hamel f3ae4554fe build: do not use bundled simdutf when built with --shared-simdutf 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65891
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
 2026-09-18 15:39:26 +00:00
Antoine du Hamel 6e85052f6e tools: do not download build tools when linting Nix files 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65961
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2026-09-12 12:47:03 +00:00
Antoine du Hamel 073e85d772 build: add --shared-perfetto flag 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65614
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-09-07 15:24:12 +02:00
Antoine du Hamel 32b5d0d0f1 tools: do not hardcode yamllint path 
Allows user to get `yamlllint` from other source than Pip (e.g. Nix).

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65747
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-09-04 22:21:58 +00:00
Antoine du Hamel 1e9fd9544e build: add --shared-highway configure flag 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65686
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-09-04 15:31:22 +02:00
Antoine du Hamel 0df3c02e8b build: add --shared-abseil configure flag 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65682
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-09-04 15:29:49 +02:00
Antoine du Hamel b0afbf5f0b tools: do not hardcode path to Ruff 
Allows user to get Ruff from other source than Pip (e.g. Nix).

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65681
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
 2026-09-02 14:25:07 +00:00
Antoine du Hamel 71ac33e63d tools: refactor shell.nix pkcs11 integration to its own section 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/65404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-08-21 17:04:49 +00:00
Filip Skokan 565c3daebf crypto: support loading private keys through STORE loaders 
Accept WHATWG URL objects in private-key inputs and load referenced keys
through OpenSSL STORE loaders. Pass optional property queries and
passphrases while preserving provider-owned EVP_PKEY objects for
ordinary KeyObject and CryptoKey operations.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63949
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2026-08-02 20:18:09 +00:00
Chengzhong Wu 83e5d82dd7 build: run perfetto build and test on GHA 
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
PR-URL: https://github.com/nodejs/node/pull/64721
Fixes: https://github.com/nodejs/diagnostics/issues/654
Refs: https://github.com/nodejs/node/pull/64565
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2026-08-02 14:31:03 +00:00
Antoine du Hamel 6909ea6db9 tools: pass the Temporal disable flag when disabled in shell.nix 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62733
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-04-16 14:29:38 +00:00
cjihrigandPaolo Insogna d0fa608c07 lib,src,test,doc: add node:ffi module 
PR-URL: https://github.com/nodejs/node/pull/62072
Co-authored-by: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
 2026-04-14 10:44:30 +01:00
Antoine du Hamel de5644cba8 tools: make v8.nix more stable 
If we only pass to the V8 builders the dependencies it actually needs,
we can avoid rebuilding the same version of V8 just because an unrelated
Node.js dependency has been updated.

PR-URL: https://github.com/nodejs/node/pull/62508
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2026-04-10 14:34:30 +00:00
Node.js GitHub Bot 5b5f069a27 tools: bump nixpkgs-unstable pin to e38213b91d3786389a446dfce4ff5a8aaf6 
PR-URL: https://github.com/nodejs/node/pull/62052
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2026-03-08 19:05:07 +00:00
Antoine du Hamel 798797aa89 tools: fix --node-builtin-modules-path value in shell.nix 
PR-URL: https://github.com/nodejs/node/pull/62102
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2026-03-06 15:20:51 +00:00
Antoine du Hamel 97c1312291 tools: remove custom logic for skipping test-strace-openat-openssl 
PR-URL: https://github.com/nodejs/node/pull/62038
Refs: https://github.com/nodejs/node/pull/61987
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2026-03-02 10:43:41 +01:00
Antoine du Hamel a5e534c21a test: skip test-url on --shared-ada builds 
PR-URL: https://github.com/nodejs/node/pull/62019
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2026-03-01 10:58:04 +00:00
Antoine du Hamel d5279e5157 tools: cache V8 build on test-shared workflow 
This commit makes the CI use the Nix/Cachix cache rather than the
sccache one for building V8 and its dependencies. This should speed up
the average test-shared build time and reduce the stress on the GHA
binary cache – at the expense of slower builds when touching a file used
to building V8.

PR-URL: https://github.com/nodejs/node/pull/61860
Refs: https://github.com/nodejs/node/issues/61436
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-02-19 07:35:21 +00:00
Antoine du Hamel ca3d4e0cd3 build: add --shared-lief configure flag 
PR-URL: https://github.com/nodejs/node/pull/61536
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2026-01-28 22:29:05 +01:00
Antoine du Hamel 150d154bf1 tools: move Quic dependencies behind ad-hoc flag 
Quic is now behind `--experimental-quic` build flag, its dependencies
should be included only if the user opts-in.

PR-URL: https://github.com/nodejs/node/pull/61446
Refs: https://github.com/nodejs/node/commit/853277a9e22a88307ca7b9fde0025635e368253c
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-01-27 22:20:16 +00:00
Antoine du Hamel 9e201e61fd tools: copyedit Nix files 
PR-URL: https://github.com/nodejs/node/pull/61447
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2026-01-22 00:00:53 +00:00
Antoine du Hamel af00e02e35 tools: add some options and comments to shell.nix 
PR-URL: https://github.com/nodejs/node/pull/60911
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-12-07 20:28:47 +00:00
Chengzhong WuandAntoine du Hamel 482b191727 build: ignore built-in temporal when building with shared lib 
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/60703
Refs: https://github.com/nodejs/node/issues/58730
Refs: https://github.com/nodejs/node/pull/60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-11-23 15:41:32 +00:00
Antoine du HamelandMichaël Zasso eb6cb5b827 build: add flag to compile V8 with Temporal support 
Refs: https://github.com/nodejs/node/issues/58730
Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/60701
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2025-11-19 22:57:41 +00:00
Antoine du Hamel c94047dfda tools: extract Nix dependency lists to separate files 
This should improve the readability, as well as the UX of cherry-picking
what dependency the user wants in their env.

PR-URL: https://github.com/nodejs/node/pull/60495
Reviewed-By: Jacob Smith <jacob@frende.me>
 2025-11-08 12:53:47 +00:00
Antoine du Hamel 7d52d9c5cb tools: pin OpenSSL to 3.5.4 on test-shared workflow 
PR-URL: https://github.com/nodejs/node/pull/60428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-10-30 12:06:55 +00:00
Antoine du Hamel 875a7bb8d2 tools: run CI with shared libs on GHA 
PR-URL: https://github.com/nodejs/node/pull/60121
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-10-17 12:33:45 +00:00