From dcbb21e06fe3255c127b7db2bd7d3b345b2aa33b Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sat, 20 Jun 2026 16:05:11 +0100 Subject: [PATCH] build: suppress compiler warnings for histogram Synchronize compiler flags in the gyp build and unofficial gn build of `deps/histogram`. Signed-off-by: Richard Lau PR-URL: https://github.com/nodejs/node/pull/63980 Fixes: https://github.com/nodejs/node/issues/63979 Reviewed-By: James M Snell Reviewed-By: Filip Skokan --- deps/histogram/histogram.gyp | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/deps/histogram/histogram.gyp b/deps/histogram/histogram.gyp index 3ab9bb070c6..5f2351c572a 100644 --- a/deps/histogram/histogram.gyp +++ b/deps/histogram/histogram.gyp @@ -13,6 +13,29 @@ 'xcode_settings': { 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden }, + 'conditions': [ + [ 'clang==1', { + 'conditions': [ + [ 'OS=="win"', { + 'msvs_settings': { + 'VCCLCompilerTool': { + 'AdditionalOptions': [ + '-Wno-atomic-alignment', + '-Wno-incompatible-pointer-types', + '-Wno-unused-function' + ], + }, + }, + }, { + 'cflags': [ + '-Wno-atomic-alignment', + '-Wno-incompatible-pointer-types', + '-Wno-unused-function' + ], + }], + ], + }], + ], 'include_dirs': ['src', 'include'], 'direct_dependent_settings': { 'include_dirs': [ 'src', 'include' ]