From 8c1a7d3172399a1bedc313c92016b5651a28aaa3 Mon Sep 17 00:00:00 2001 From: Yuya Inoue <65857152+inoway46@users.noreply.github.com> Date: Sat, 10 Oct 2026 22:49:13 +0900 Subject: [PATCH] quic: replace removed SetPrototypeV2 calls MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use SetPrototype when creating application options and transport parameter objects. V8 15.5 removed the deprecated SetPrototypeV2 wrapper, which delegated to SetPrototype, breaking QUIC builds. Assisted-by: Codex Signed-off-by: inoway46 PR-URL: https://github.com/nodejs/node/pull/66603 Refs: https://github.com/nodejs/node/pull/66537 Refs: https://github.com/nodejs/node/pull/66602 Reviewed-By: Tim Perry Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen --- src/quic/application.cc | 2 +- src/quic/transportparams.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/quic/application.cc b/src/quic/application.cc index 212a9984d1a..11753aeb90f 100644 --- a/src/quic/application.cc +++ b/src/quic/application.cc @@ -156,7 +156,7 @@ MaybeLocal Session::Application_Options::ToObject( static_assert(std::size(values) == std::size(names)); auto obj = tmpl->NewInstance(env->context(), values); - if (obj->SetPrototypeV2(env->context(), Null(env->isolate())).IsNothing()) { + if (obj->SetPrototype(env->context(), Null(env->isolate())).IsNothing()) { return {}; } return obj; diff --git a/src/quic/transportparams.cc b/src/quic/transportparams.cc index 3d2e333b32c..45e6abc3109 100644 --- a/src/quic/transportparams.cc +++ b/src/quic/transportparams.cc @@ -485,7 +485,7 @@ v8::MaybeLocal TransportParams::ToObject(Environment* env) const { } auto obj = tmpl->NewInstance(env->context(), values); - if (obj->SetPrototypeV2(env->context(), Null(env->isolate())).IsNothing()) { + if (obj->SetPrototype(env->context(), Null(env->isolate())).IsNothing()) { return {}; } return obj;