deps: always define V8_EXPORT_PRIVATE as no-op

dllexport introduces issues when compiling with MSVC.

PR-URL: https://github.com/nodejs/node/pull/47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
This commit is contained in:
Michaël Zasso authored and Node.js GitHub Bot committed 2023-03-31 14:15:28 +00:00
1 parent 295b2f3ff4
commit 6f5655a18e
2 files changed
+4 -4

No files matched your search

+1 -1
View File
@@ -36,7 +36,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.0',
'v8_embedder_string': '-node.1',
##### V8 defaults for Node.js #####
+3 -3
View File
@@ -389,9 +389,9 @@ bool is_inbounds(float_t v) {
// Setup for Windows shared library export.
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllexport)
#define V8_EXPORT_PRIVATE
#elif USING_V8_SHARED
#define V8_EXPORT_PRIVATE __declspec(dllimport)
#define V8_EXPORT_PRIVATE
#else
#define V8_EXPORT_PRIVATE
#endif // BUILDING_V8_SHARED
@@ -401,7 +401,7 @@ bool is_inbounds(float_t v) {
// Setup for Linux shared library export.
#if V8_HAS_ATTRIBUTE_VISIBILITY
#ifdef BUILDING_V8_SHARED
#define V8_EXPORT_PRIVATE __attribute__((visibility("default")))
#define V8_EXPORT_PRIVATE
#else
#define V8_EXPORT_PRIVATE
#endif