mirror of
https://github.com/milvus-io/milvus.git
synced 2026-10-29 01:16:06 +08:00
issue: #52114 Makes `ruff check` and `ruff format --check` pass over all of `tests/`, so the `Ruff (changed files only)` job stops failing PRs for violations they did not introduce (most recently #51903, which got 69 errors from an 8-line change). Almost all of this is mechanical. The behavioural changes are called out individually below: one `NameError` fix, three shadowed duplicate definitions, 13 assertion gaps, and two undefined names that only became visible once star imports were expanded. ### Layout Seven reviewable commits: | commit | what | files | |---|---|---| | 1 | `ruff format` | 170 | | 2 | `ruff check --fix` (safe fixes only, no `--unsafe-fixes`) | 156 | | 3 | F821 fix + `tests/ruff.toml` | 4 | | 4 | three shadowed duplicate definitions | 4 | | 5 | close 13 assertion gaps behind F841 | 7 | | 6 | expand star imports, re-enable F403/F405/F821 | 33 | | 7 | enable E402, E712, E722 | 16 | 1745 violations → 0. Only `tests/` is touched. ### The undefined-name bug `chaos/test_chaos_memory_stress.py`: `TestMemoryStressReplica.prepare_collection` referenced bare `nb` and `dim`. Those are class attributes, never module-level names, so the fixture raised `NameError` the moment it ran — and the line directly above it already used `self.dim`. Changed to `self.nb` / `self.dim`. This was the only F821 in `tests/`; **the rule stays enabled**. ### Three shadowed duplicate definitions Three places define the same name twice in the same scope. Python keeps the later one, so the earlier definition is dead while still reading as live code — a test that looks like it exists and never runs. **`restful_client/testcases/test_vector_operations.py` — `TestDeleteVector`** ```python @pytest.mark.L0 class TestDeleteVector(TestBase): # line 778 — shadowed, never ran def test_delete_vector_default(...) # 2x2 parametrized @pytest.mark.L1 class TestDeleteVector(TestBase): # line 838 — wins def test_delete_vector_with_invalid_api_key(...) def test_delete_vector_with_invalid_collection_name(...) def test_delete_vector_with_non_primary_key(...) ``` The second holds only negative cases, and the file already uses `TestInsertVectorNegative` / `TestSearchVectorNegative`, so this is a copy whose class name was never updated. Renamed it to `TestDeleteVectorNegative`. **This is the one to look at:** it brings back an `L0` case, so 4 parametrizations of `test_delete_vector_default` start running in PR CI. They have never executed, so if the restful delete path has drifted since they were written, this is where it surfaces. **`python_client/testcases/test_compaction.py` — `test_compact_after_delete`** Defined twice in `TestCompactionParams`, covering different things: the shadowed one (L3, `@parametrize("delete_pos", [1, tmp_nb // 2])`) covers *partial* deletes plus a compaction-plan check; the surviving one (L2) deletes everything. There is already a separate `test_compact_after_delete_all`, so partial-delete coverage existed only in the shadowed case and was not running. Renamed it to `test_compact_after_delete_partial`; the surviving definition is untouched. **`python_client/utils/util_pymilvus.py` — `add_vector_field`** Defined twice with different signatures: ```python def add_vector_field(entities, is_normal=False): # line 455 — shadowed ... entities.append(field) return entities def add_vector_field(nb, dimension=default_dim): # line 527 — wins field_name = gen_unique_str() field = {...} # built, then discarded return field_name # returns only the name ``` Removed the second — both the broken one and the one that was winning. Grepped the whole repo: **neither definition has a caller**; every `add_vector_field` hit is something else (`test_milvus_client_add_vector_field` test methods, the `Op.add_vector_field` enum member in `chaos/checker.py`, a `Checker` method of the same name). Dead-code removal, not an API change. **Net effect on what executes:** `test_delete_vector_default` ×4 (**L0**) and `test_compact_after_delete_partial` ×2 (L3) start running; nothing stops running; the 3 negative cases keep running under the new class name. Computed by parsing each file before and after and resolving shadowing the way Python does, not by reading the diff. F811 is now clean across `tests/` with no per-file suppressions. ### Star imports expanded, F403/F405/F821 re-enabled 33 of 307 files used `from utils.util_pymilvus import *` and friends. Inside those, pyflakes cannot tell a typo from a star-imported name — it downgrades everything unresolved to F405, and **F821 never fires**. The `NameError` fixed in commit 3 was only catchable because that file happens not to use a star import. The 379 F405 hits were only **58 distinct names**. All are now explicit, resolved by walking the star modules in source order (later import wins, matching Python). Names that `util_pymilvus` merely re-exports come from their real source now — `DataType` from `pymilvus`, `np` from `numpy`, `log` from `utils.util_log` — rather than being laundered through it. Turning F821 on immediately caught **two real undefined names**, both in `rate_limit/test_rate_limit.py` (L3, so it has never run in CI): ```python for collection_num in range(collectionRateLimit): # no such name # ^ the parametrize arg is `collection_rate_limit`, and it is # a string ("10"/"500"), so range() needs int(). # The same test uses the correct name 30 lines below. mil.uninstall(release_name, namespace=NAMESPACE) # no such name # ^ MilvusOperator.uninstall has exactly this signature, and other suites do the # same under `mic`/`milvus_op` — the instantiation was just missing. ``` Both fixed. `test_milvus_client_data_integrity_new.py` needed 15 `noqa` markers instead: its `prepare_data` fixture injects those names via `globals()[field] = ...`, which no static analysis can follow. That block has other problems — a `float is None` check against the builtin, an always-true `if "is null" or "IS NULL" in expression`, leftover `binbin_debug1` logging — but rewriting fixture logic does not belong here; noted in #52116. ### 13 assertion gaps closed Of ~80 F841 hits, most are harmless scratch values. 13 were a call whose result was bound and then never checked. Highlights: - `test_milvus_client_database.py`: two tests apply a non-existent property key (`data.replica.number`, note `data.` not `database.`), describe the database, and drop it without checking anything. Their docstrings say `actual: run successfully` / `nothing changed` — the intent was to prove nothing changed. Now asserted. - `test_milvus_client_alias.py`: two assertions were commented out, **and they were commented out for a reason** — `list_aliases()[0]` returns a dict, so `assert alias in aliases` would have tested dict keys. Rewritten against `[0]["aliases"]` (how the rest of the file does it) and re-enabled. In the skipped `alias_default` test the calls were also missing the required `collection_name` argument. The remaining ~65 F841 stay, and the rule stays off. ### E402, E712, E722 also enabled **E722** (37 sites): mechanical `except:` → `except Exception:`. Checked the two ways this could change behaviour, both empty: no bare-except try-block can raise `SystemExit`/`KeyboardInterrupt`, and **none calls `pytest.skip`/`fail`/`xfail`**. That second one matters — pytest's `Skipped` derives from `BaseException`, so a bare except silently eats it while `except Exception` would not. 0 of 37, so behaviour is unchanged. **E402** (5 sites): imports that were just in the wrong place — `import re` sat 70 lines into `check/param_check.py`, and the two `resource_group` modules imported `rich` after their module-level constants. Nothing to do with `sys.path`, which is what an earlier version of this description wrongly claimed. **E712** (5 sites), gone through one at a time rather than bulk-rewritten: | site | value | change | |---|---|---| | `test_milvus_client_partition.py` | `has_partition()` | → `is False` — stricter than `not result`, which would pass on `None` | | `test_restart.py` | JSON status flag | → `is True` | | `test_restart.py` | local `break_flag` | → plain truth test, it is a real bool | | `test_query.py` | wrapper `check_result` | → `is True` | | `test_milvus_client_ttl.py` | `hit.get(bool_field)` | **kept as `== False` + noqa** | That last one is the reason this rule cannot be bulk-fixed: `.get()` returns `None` for a missing field, so `not ...` would pass exactly where the assertion should fail, and `is False` would break on a numpy bool. ### What ruff.toml still disables | rule | n | reason | |---|---|---| | F841 | ~65 | tests deliberately keep call results; the 13 that were genuine assertion gaps are fixed above | | UP031 | 95 | pure style rewrite that catches no bugs, and 27 sites use `% (...)` tuples where it is not equivalent | Everything else pyflakes/pycodestyle checks is on, including `F401`, `F811` and `F821`, so new code cannot introduce dead, duplicate or undefined names. Tracked in #52116. ### Verification Not just "ruff is green" — the mechanical passes were checked for semantic drift: - **Format pass:** parsed all 307 files before and after and compared ASTs with string constants normalized away → **zero structural differences**. The only AST-visible deltas are 146 string-constant changes, every one whitespace-only (docstring indentation / trailing whitespace); zero non-whitespace string changes. - **Import removals:** 142 imports were dropped. For each, checked whether the bound name still appears anywhere in its file. 115 have no remaining reference at all. The 27 that still matched textually were each read by hand and are all comments (`# pdb.set_trace()`, the commented-out checker dict in `test_load_with_checker.py`), docstring prose (`"input random collection name"`, `"Tuple[List[Dict]]"`), string literals (`"Collection ID"`, the `"config"` dict key), a different binding (`from time import sleep`), or attribute access through another module (`ct.CaseLabel`, `np.random`). **No real reference was removed.** - **Python version:** the pyupgrade rewrites emit `datetime.UTC` (3.11+) and `X | None` (3.10+). `tests/.python-version` is 3.12, `tests/scripts/python-env.sh` defaults to 3.12, and `tests/docker/Dockerfile` is `python:3.12-bullseye`. - **`compileall`** over all 307 files under Python 3.12 passes. - No external reference to `TestDeleteVector`, `test_compact_after_delete`, or `add_vector_field` exists anywhere in the repo (`*.py`, `*.sh`, `*.yaml`, `*.json`). ### Conflict surface Of the 100 currently-open PRs, 9 touch `tests/*.py` and only **2** overlap with this change: #51903 (3 of its 5 files) and #51856 (1 file). The other 7 touch files that were already format-clean. Worth merging promptly to keep that number small. `.pre-commit-config.yaml` needs no change — it already runs with `--config=tests/ruff.toml`, so local hooks and CI stay in sync. --------- Signed-off-by: xiaofanluan <xf@hjjaq.com> Co-authored-by: xiaofanluan <xf@hjjaq.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
393 lines
16 KiB
Python
393 lines
16 KiB
Python
import os
|
|
import random
|
|
|
|
import pytest
|
|
from base.client_base import TestcaseBase
|
|
from common import common_func as cf
|
|
from common import common_type as ct
|
|
from common.common_type import CaseLabel, CheckTasks
|
|
|
|
prefix = "query_iter_"
|
|
|
|
|
|
class TestQueryIterator(TestcaseBase):
|
|
@pytest.mark.tags(CaseLabel.L0)
|
|
@pytest.mark.parametrize("primary_field", [ct.default_string_field_name, ct.default_int64_field_name])
|
|
@pytest.mark.parametrize("with_growing", [False, True])
|
|
def test_query_iterator_normal(self, primary_field, with_growing):
|
|
"""
|
|
target: test query iterator normal
|
|
method: 1. query iterator
|
|
2. check the result, expect pk
|
|
verify: no pk lost in interator results
|
|
3. query iterator with checkpoint file
|
|
4. iterator.next() for 10 times
|
|
5. delete some entities before calling a new query iterator
|
|
6. call a new query iterator with the same checkpoint file, with diff batch_size and output_fields
|
|
7. iterator.next() until the end
|
|
verify:
|
|
1. no pk lost in interator results for the 2 iterators
|
|
2. no dup pk in the 2 iterators
|
|
expected: query iterators successfully
|
|
"""
|
|
# 1. initialize with data
|
|
nb = 4000
|
|
batch_size = 200
|
|
collection_w, _, _, insert_ids, _ = self.init_collection_general(
|
|
prefix, True, is_index=False, nb=nb, is_flush=True, auto_id=False, primary_field=primary_field
|
|
)
|
|
collection_w.create_index(ct.default_float_vec_field_name, {"metric_type": "L2"})
|
|
collection_w.load()
|
|
# 2. query iterator
|
|
expr = "float >= 0"
|
|
collection_w.query_iterator(
|
|
batch_size,
|
|
expr=expr,
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={"count": nb, "pk_name": collection_w.primary_field.name, "batch_size": batch_size},
|
|
)
|
|
# 3. query iterator with checkpoint file
|
|
iterator_cp_file = f"/tmp/it_{collection_w.name}_cp"
|
|
iterator = collection_w.query_iterator(batch_size, expr=expr, iterator_cp_file=iterator_cp_file)[0]
|
|
iter_times = 0
|
|
first_iter_times = nb // batch_size // 2 # only iterate half of the data for the 1st time
|
|
pk_list1 = []
|
|
while iter_times < first_iter_times:
|
|
iter_times += 1
|
|
res = iterator.next()
|
|
if len(res) == 0:
|
|
iterator.close()
|
|
assert False, f"The iterator ends before {first_iter_times} times iterators: iter_times: {iter_times}"
|
|
break
|
|
for i in range(len(res)):
|
|
pk_list1.append(res[i][primary_field])
|
|
file_exist = os.path.isfile(iterator_cp_file)
|
|
assert file_exist is True, "The checkpoint file exists without iterator close"
|
|
|
|
# 4. try to delete and insert some entities before calling a new query iterator
|
|
delete_ids = random.sample(insert_ids[: nb // 2], 101) + random.sample(insert_ids[nb // 2 :], 101)
|
|
del_res, _ = collection_w.delete(expr=f"{primary_field} in {delete_ids}")
|
|
assert del_res.delete_count == len(delete_ids)
|
|
|
|
data = cf.gen_default_list_data(nb=333, start=nb)
|
|
collection_w.insert(data)
|
|
if not with_growing:
|
|
collection_w.flush()
|
|
|
|
# 5. call a new query iterator with the same checkpoint file to continue the first iterator
|
|
iterator2 = collection_w.query_iterator(
|
|
batch_size * 2,
|
|
expr=expr,
|
|
output_fields=[primary_field, ct.default_float_field_name],
|
|
iterator_cp_file=iterator_cp_file,
|
|
)[0]
|
|
while True:
|
|
res = iterator2.next()
|
|
if len(res) == 0:
|
|
iterator2.close()
|
|
break
|
|
for i in range(len(res)):
|
|
pk_list1.append(res[i][primary_field])
|
|
# 6. verify
|
|
assert len(pk_list1) == len(set(pk_list1)) == nb
|
|
file_exist = os.path.isfile(iterator_cp_file)
|
|
assert file_exist is False, "The checkpoint was deleted after the iterator close"
|
|
|
|
@pytest.mark.tags(CaseLabel.L1)
|
|
def test_query_iterator_using_default_batch_size(self):
|
|
"""
|
|
target: test query iterator normal
|
|
method: 1. query iterator
|
|
2. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
collection_w = self.init_collection_general(prefix, True)[0]
|
|
# 2. query iterator
|
|
collection_w.query_iterator(
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"count": ct.default_nb,
|
|
"pk_name": collection_w.primary_field.name,
|
|
"batch_size": ct.default_batch_size,
|
|
},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
@pytest.mark.parametrize("offset", [500, 1000, 1777])
|
|
def test_query_iterator_with_offset(self, offset):
|
|
"""
|
|
target: test query iterator normal
|
|
method: 1. query iterator
|
|
2. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
batch_size = 300
|
|
collection_w = self.init_collection_general(prefix, True, is_index=False)[0]
|
|
collection_w.create_index(ct.default_float_vec_field_name, {"metric_type": "L2"})
|
|
collection_w.load()
|
|
# 2. search iterator
|
|
expr = "int64 >= 0"
|
|
collection_w.query_iterator(
|
|
batch_size,
|
|
expr=expr,
|
|
offset=offset,
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"count": ct.default_nb - offset,
|
|
"pk_name": collection_w.primary_field.name,
|
|
"batch_size": batch_size,
|
|
},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
@pytest.mark.parametrize("vector_data_type", ct.all_dense_vector_types)
|
|
def test_query_iterator_output_different_vector_type(self, vector_data_type):
|
|
"""
|
|
target: test query iterator with output fields
|
|
method: 1. query iterator output different vector type
|
|
2. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
batch_size = 400
|
|
collection_w = self.init_collection_general(prefix, True, vector_data_type=vector_data_type)[0]
|
|
# 2. query iterator
|
|
expr = "int64 >= 0"
|
|
collection_w.query_iterator(
|
|
batch_size,
|
|
expr=expr,
|
|
output_fields=[ct.default_float_vec_field_name],
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={"count": ct.default_nb, "pk_name": collection_w.primary_field.name, "batch_size": batch_size},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
@pytest.mark.parametrize("batch_size", [10, 777, 2000])
|
|
def test_query_iterator_with_different_batch_size(self, batch_size):
|
|
"""
|
|
target: test query iterator normal
|
|
method: 1. query iterator
|
|
2. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
offset = 500
|
|
collection_w = self.init_collection_general(prefix, True, is_index=False)[0]
|
|
collection_w.create_index(ct.default_float_vec_field_name, {"metric_type": "L2"})
|
|
collection_w.load()
|
|
# 2. search iterator
|
|
expr = "int64 >= 0"
|
|
collection_w.query_iterator(
|
|
batch_size=batch_size,
|
|
expr=expr,
|
|
offset=offset,
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"count": ct.default_nb - offset,
|
|
"pk_name": collection_w.primary_field.name,
|
|
"batch_size": batch_size,
|
|
},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
@pytest.mark.parametrize("offset", [0, 10, 1000])
|
|
@pytest.mark.parametrize("limit", [0, 100, 10000])
|
|
def test_query_iterator_with_different_limit(self, limit, offset):
|
|
"""
|
|
target: test query iterator normal
|
|
method: 1. query iterator
|
|
2. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
collection_w = self.init_collection_general(prefix, True)[0]
|
|
# 2. query iterator
|
|
Count = limit if limit + offset <= ct.default_nb else ct.default_nb - offset
|
|
collection_w.query_iterator(
|
|
limit=limit,
|
|
expr="",
|
|
offset=offset,
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"count": max(Count, 0),
|
|
"pk_name": collection_w.primary_field.name,
|
|
"batch_size": ct.default_batch_size,
|
|
},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
def test_query_iterator_invalid_batch_size(self):
|
|
"""
|
|
target: test query iterator invalid limit and offset
|
|
method: query iterator using invalid limit and offset
|
|
expected: raise exception
|
|
"""
|
|
# 1. initialize with data
|
|
nb = 17000 # set nb > 16384
|
|
collection_w = self.init_collection_general(prefix, True, nb=nb)[0]
|
|
# 2. search iterator
|
|
expr = "int64 >= 0"
|
|
error = {"err_code": 1, "err_msg": "batch size cannot be less than zero"}
|
|
collection_w.query_iterator(batch_size=-1, expr=expr, check_task=CheckTasks.err_res, check_items=error)
|
|
|
|
@pytest.mark.tags(CaseLabel.L0)
|
|
@pytest.mark.parametrize("batch_size", [500])
|
|
@pytest.mark.parametrize("auto_id", [False])
|
|
def test_query_iterator_empty_expr_with_cp_file_for_times(self, auto_id, batch_size):
|
|
"""
|
|
target: verify 2 query iterators with/out checkpoint file works independently
|
|
method: 1. create a collection
|
|
2. query the 1st iterator with empty expr and checkpoint file
|
|
3. iterator.next() for some times
|
|
4. call a new query iterator with the same checkpoint file
|
|
expected: verify the 2nd iterator can get the whole results
|
|
"""
|
|
# 0. initialize with data
|
|
collection_w, _, _, insert_ids = self.init_collection_general(prefix, True, auto_id=auto_id)[0:4]
|
|
|
|
# 1. call a new query iterator and iterator for some times
|
|
iterator_cp_file = f"/tmp/it_{collection_w.name}_cp"
|
|
iterator = collection_w.query_iterator(batch_size=batch_size // 2, iterator_cp_file=iterator_cp_file)[0]
|
|
iter_times = 0
|
|
first_iter_times = ct.default_nb // batch_size // 2 // 2 # only iterate half of the data for the 1st time
|
|
while iter_times < first_iter_times:
|
|
iter_times += 1
|
|
res = iterator.next()
|
|
if len(res) == 0:
|
|
iterator.close()
|
|
assert False, f"The iterator ends before {first_iter_times} times iterators: iter_times: {iter_times}"
|
|
break
|
|
|
|
# 2. call a new query iterator to get all the results of the collection
|
|
collection_w.query_iterator(
|
|
batch_size=batch_size,
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"batch_size": batch_size,
|
|
"count": ct.default_nb,
|
|
"pk_name": collection_w.primary_field.name,
|
|
"exp_ids": insert_ids,
|
|
},
|
|
)
|
|
file_exist = os.path.isfile(iterator_cp_file)
|
|
assert file_exist is True, "The checkpoint exists if not iterator.close()"
|
|
iterator.close()
|
|
file_exist = os.path.isfile(iterator_cp_file)
|
|
assert file_exist is False, "The checkpoint was deleted after the iterator close"
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
@pytest.mark.parametrize("offset", [1000])
|
|
@pytest.mark.parametrize("batch_size", [500, 1000])
|
|
def test_query_iterator_expr_empty_with_random_pk_pagination(self, batch_size, offset):
|
|
"""
|
|
target: test query iterator with empty expression
|
|
method: create a collection using random pk, query empty expression with a limit
|
|
expected: return topK results by order
|
|
"""
|
|
# 1. initialize with data
|
|
collection_w, _, _, insert_ids = self.init_collection_general(prefix, True, random_primary_key=True)[0:4]
|
|
|
|
# 2. query with empty expr and check the result
|
|
exp_ids = sorted(insert_ids)
|
|
collection_w.query_iterator(
|
|
batch_size,
|
|
output_fields=[ct.default_string_field_name],
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"batch_size": batch_size,
|
|
"pk_name": collection_w.primary_field.name,
|
|
"count": ct.default_nb,
|
|
"exp_ids": exp_ids,
|
|
},
|
|
)
|
|
|
|
# 3. query with pagination
|
|
exp_ids = sorted(insert_ids)[offset:]
|
|
collection_w.query_iterator(
|
|
batch_size,
|
|
offset=offset,
|
|
output_fields=[ct.default_string_field_name],
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={
|
|
"batch_size": batch_size,
|
|
"pk_name": collection_w.primary_field.name,
|
|
"count": ct.default_nb - offset,
|
|
"exp_ids": exp_ids,
|
|
},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L1)
|
|
@pytest.mark.parametrize("primary_field", [ct.default_string_field_name, ct.default_int64_field_name])
|
|
def test_query_iterator_with_dup_pk(self, primary_field):
|
|
"""
|
|
target: test query iterator with duplicate pk
|
|
method: 1. insert entities with duplicate pk
|
|
2. query iterator
|
|
3. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
nb = 3000
|
|
collection_w = self.init_collection_general(
|
|
prefix, insert_data=False, is_index=False, auto_id=False, primary_field=primary_field
|
|
)[0]
|
|
# insert entities with duplicate pk
|
|
data = cf.gen_default_list_data(nb=nb)
|
|
for _ in range(3):
|
|
collection_w.insert(data)
|
|
collection_w.flush()
|
|
# create index
|
|
index_type = "HNSW"
|
|
index_params = {
|
|
"index_type": index_type,
|
|
"metric_type": ct.default_L0_metric,
|
|
"params": cf.get_index_params_params(index_type),
|
|
}
|
|
collection_w.create_index(ct.default_float_vec_field_name, index_params)
|
|
collection_w.load()
|
|
# 2. query iterator
|
|
collection_w.query_iterator(
|
|
check_task=CheckTasks.check_query_iterator,
|
|
check_items={"count": nb, "pk_name": collection_w.primary_field.name, "batch_size": ct.default_batch_size},
|
|
)
|
|
|
|
@pytest.mark.tags(CaseLabel.L2)
|
|
@pytest.mark.skip("issue #37109, need debug due to the resolution of the issue")
|
|
def test_query_iterator_on_two_collections(self):
|
|
"""
|
|
target: test query iterator on two collections
|
|
method: 1. create two collections
|
|
2. query iterator on the first collection
|
|
3. check the result, expect pk
|
|
expected: query successfully
|
|
"""
|
|
# 1. initialize with data
|
|
collection_w = self.init_collection_general(prefix, True)[0]
|
|
collection_w2 = self.init_collection_general(prefix, False, primary_field=ct.default_string_field_name)[0]
|
|
|
|
data = cf.gen_default_list_data(nb=ct.default_nb, primary_field=ct.default_string_field_name)
|
|
string_values = [cf.gen_str_by_length(20) for _ in range(ct.default_nb)]
|
|
data[2] = string_values
|
|
collection_w2.insert(data)
|
|
|
|
# 2. call a new query iterator and iterator for some times
|
|
batch_size = 150
|
|
iterator_cp_file = f"/tmp/it_{collection_w.name}_cp"
|
|
iterator2 = collection_w2.query_iterator(batch_size=batch_size // 2, iterator_cp_file=iterator_cp_file)[0]
|
|
iter_times = 0
|
|
first_iter_times = ct.default_nb // batch_size // 2 // 2 # only iterate half of the data for the 1st time
|
|
while iter_times < first_iter_times:
|
|
iter_times += 1
|
|
res = iterator2.next()
|
|
if len(res) == 0:
|
|
iterator2.close()
|
|
assert False, f"The iterator ends before {first_iter_times} times iterators: iter_times: {iter_times}"
|
|
break
|
|
|
|
# 3. query iterator on the second collection with the same checkpoint file
|
|
|
|
iterator = collection_w.query_iterator(batch_size=batch_size, iterator_cp_file=iterator_cp_file)[0]
|
|
print(iterator.next())
|