mirror of
https://github.com/microsoft/microsoft-ui-xaml.git
synced 2026-10-28 16:35:19 +08:00
## Fixes | Internal issue | Type | Change | |---|---|---| | https://task.ms/64475625 | Bug | Column headers are a templated, restylable `TableViewColumnHeader` with visual states | | https://task.ms/64475623 | Bug | Header typography comes from the header Style, not C++ local values | | https://task.ms/64143451 | Bug | Header column separators are always drawn (no new property); hide them by overriding `TabularSurfaceHeaderSeparatorBrush` | | https://task.ms/63996584 | Task | Column headers expose the UIA Transform pattern so UIA clients can resize columns | | https://task.ms/64475611 | Bug | Outer border uses new `TabularSurfaceOuterBorderBrush` (`CardStrokeColorDefault`); grid-line values were in #12349 | | https://task.ms/64475629 | Bug | Default group header uses theme tokens (SemiBold key style, 8px spacing); the item count inherits the header `Foreground` | | https://task.ms/64652961 | Task | Row recycling no longer regenerates cells or refreshes row chrome twice (scroll performance) | | https://task.ms/63790855 | Task | Sort: `CanSort` is enforced and `SortByColumn(column, None)` always clears; a sort through a source another table owns returns false; no spurious `Sorted`; an app-owned sort survives a `CanSort`/`CanUserSortColumns` opt-out | | https://task.ms/63787021 | Task | Cell automation-peer constructor validates its arguments; `BeginEdit` rolls back when it throws | Not changed: https://task.ms/64512732 (by design: Auto columns follow content width), https://task.ms/64475627 (design decision: keep chevron sort glyphs), https://task.ms/64513223 (investigation only; fix deferred). ## PR Type - [x] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no API changes) - [ ] Build related changes - [x] Documentation content changes - [ ] Other (please describe): ## Description Follow-up to #12349 (merged) and #12285. Column headers move from code-built Grids to a new templated `TableViewColumnHeader`, restylable through `TableView.ColumnHeaderStyle` or `TableViewColumn.HeaderStyle`. Header peers gain the UIA Transform pattern for column resize. Sort behavior is tightened around `CanSort`, opt-outs and shared `TableViewSource` ownership. Row recycling reuses cells. Outer border, header lines and the default group header follow Fluent tokens. Review-driven fixes included here: - The header Style's `TargetType` `TypeName` is kept alive while it is compared; a Style with only `BasedOn` typed is applied, and its setters are read before applying it seals the Style. Incompatible, untyped or cyclic `BasedOn` Styles are ignored with a debug diagnostic. - A header disabled by its Style reports `IsEnabled=false` and is not invokable through UIA. - UIA `Transform.Resize` converts physical pixels through the table's full visual scale (not only `RasterizationScale`), and a width change below the drag jitter deadband is written once, exactly. - Disabling a header in its High Contrast hover/pressed state keeps the disabled foreground (state order fixed); the disabled sort glyph follows the text brush across theme changes. - A `CanSort` opt-out made inside `BeginningEdit` is replayed after the edit it let open closes, and rebuilds headers even when a `Sorted` handler throws. - Header rebuilds caused by `Content`/`Header` or `Columns` changes keep focus in the header band, respect an app's own focus move, and release `UIElement` headers back to the app. - A disabled group header does not dim its item count twice. The count opacity follows `ContentTemplate` changes while the header is disabled. <details><summary>Product changes by file</summary> | File | +/- | What changed | Items | |---|---|---|---| | `TableView/TableView.cpp` (+ .h) | +684 / −382 | `RebuildHeaders` creates `TableViewColumnHeader` controls; applies `ColumnHeaderStyle`/`HeaderStyle` with TargetType/BasedOn checks; density MinHeight/Padding only when the Style doesn't set them<br>`ReleaseHeaderCells` and header-focus handling for removed/replaced columns, re-entrant rebuilds and app focus moves<br>Header bottom rule thickness set on `PART_HeaderRow`; header lines no longer follow `GridLinesVisibility`<br>Row prepare/clear refresh chrome once; `TryResizeColumnFromAutomation` writes small widths exactly | 64475625, 64475623, 64143451, 64652961, 63996584, 63790855 | | `TableView/TableViewColumnHeader.cpp` (+ .h; replaces `TableViewHeaderCell.h`) | +435 / −210 | New sealed templated `ContentControl` with read-only `Column`<br>Resolves `PART_ContentPresenter`, `PART_GridLine`, `PART_SortIndicatorHost`, `PART_ResizeGripperHost`; hosts the sort glyph and gripper<br>Drives `CommonStates`/`HighContrastStates`/`SortStates`; disabled sort glyph bound to the text brush | 64475625, 64475623 | | `TableView/TableViewRow.cpp` (+ .h) | +191 / −35 | Recycled rows keep their cells unless cell automation peers exist; chrome refreshed once; tooltips re-applied on recycle<br>`BeginCellEdit` restores display element, edit state and focus on throw | 64652961, 63787021 | | `TableView/TableView.xaml` | +128 / −18 | Default `TableViewColumnHeader` Style/template: typography setters, visual states, parts<br>Outer border uses `TabularSurfaceOuterBorderBrush`; header lines use `TabularSurfaceHeaderSeparatorBrush`<br>Group header: `TableViewGroupExpanderSpacing` (8), padding 8,8,12,8, key/count text styles, count inherits `Foreground` | 64475625, 64475623, 64475611, 64475629 | | `TableView/TableViewColumnHeaderAutomationPeer.cpp` (+ .h) | +127 / −9 | `ITransformProvider`: `Resize` converts physical px through the visual scale; `CanResize` tracks gripper availability (pinned → false)<br>`IsEnabled` follows the header; name read from the content presenter | 63996584, 64475625 | | `TableView/TableView_Sort.cpp` | +113 / −39 | `SortByColumn(None)` bypasses the `CanSort` gate; other sorts refused<br>Sort through a source owned by another table returns false; implicit clears keep the app's sort and raise no `Sorted`; app-lit columns left alone on opt-out | 63790855 | | `TableView/TableView_Layout.cpp` | +74 / −14 | Realized-row walk only when a visible Auto column exists<br>Transform `CanResize` changes raised for existing header peers | 64652961, 63996584 | | `TableView/TableView_Editing.cpp` | +63 / −15 | `BeginEdit` unwinds on throw; `CanSort` opt-out during `BeginningEdit` queued until the edit closes | 63787021, 63790855 | | `TableView/TableViewCellAutomationPeer.cpp` (+ .h, `TableViewCell.h`) | +48 / −0 | Public constructor throws `E_INVALIDARG` for null args, negative/out-of-range index or a foreign column; internal path uses `TrustedOwnerTag` | 63787021 | | `TableView/TableViewGroupHeader.cpp` (+ .h) | +39 / −0 | Default count's opacity is not applied twice when disabled | 64475629 | | `TableView/TableView.idl` | +31 / −13 | `TableViewColumnHeader`, `TableView.ColumnHeaderStyle`, `TableViewColumn.HeaderStyle`<br>`CanSort`/`SortByColumn`/`ToggleSortDirection`/`GridLinesVisibility` docs; cell-peer `E_INVALIDARG`; group-header parts | 64475625, 63790855, 64143451, 63787021 | | `TableView/TableView_Columns.cpp` | +19 / −0 | Releases removed columns' header cells; old `UIElement` `Header` returned to the app on change | 64475625 | | `TableView/TableViewColumn.cpp` | +7 / −0 | `HeaderStyle` change queues a header rebuild | 64475625 | | `TableView/TableViewSource.h` | +6 / −0 | `IsOwnedByOther` helper for sort sync | 63790855 | | `CommonStyles/TabularSurfaces_themeresources.xaml` | +5 / −2 | New `TabularSurfaceOuterBorderBrush` (Dark/Light/HC); group count opacity documented as secondary-over-primary text (0.77 Dark) | 64475611, 64475629 | | `TableView/TableView.vcxitems` | +2 / −1 | Swap `TableViewHeaderCell.h` for `TableViewColumnHeader.*` | 64475625 | | Generated / metadata (`Generated/TableView.properties.*`, `Generated/TableViewColumn.properties.*`, `dll-tabular/XamlMetadataProviderGenerated.h`) | +123 / −0 | Codegen for the new properties and type | 64475625 | **Total: 17 rows, 29 product files, +2117 / −738.** Also: 19 test files (+3718 / −32), 3 docs (+161 / −35), 6 sample files (+2 / −9). </details> ### New preview API (needs API review) - **`TableViewColumnHeader`**: sealed, templated `ContentControl`, created only by `TableView`. - Read-only `Column` property. - Template parts (optional): `PART_ContentPresenter`, `PART_GridLine`, `PART_SortIndicatorHost`, `PART_ResizeGripperHost`. - Visual state groups: `CommonStates`, `HighContrastStates`, `SortStates`. - **`TableView.ColumnHeaderStyle`**: Style applied to every column header. - **`TableViewColumn.HeaderStyle`**: per-column Style; wins over `TableView.ColumnHeaderStyle`. There is no `HeaderGridLinesVisibility` property. `GridLinesVisibility` affects body lines only; header lines are always drawn. To hide them, override `TabularSurfaceHeaderSeparatorBrush` with `Transparent`. ### Current Behavior - Headers are built in C++ with no template, no visual states and forced local typography, so apps can't restyle them. Header separators don't show. - Header peers report `HeaderItem` without Transform, so UIA clients can't resize columns. - `SortByColumn` ignores `CanSort`; `CanSort=false` on a sorted column leaves the sort in place; sorting through a source another table owns reports success; some implicit clears raise `Sorted(None)` while the app's sort remains. - The cell peer constructor accepts invalid arguments; a throw in `BeginEdit` leaves edit state half-open. - Recycling a row rebuilt every cell, refreshed chrome up to twice and invalidated the table's measure. - The outer border has no dedicated brush; the default group header uses raw weights and off-grid spacing. ### New Behavior - Headers use the templated `TableViewColumnHeader` (see API above); typography, padding and brushes come from Style setters. - Header peers implement `ITransformProvider` through the existing resize path (Min/Max clamping, scale conversion; pinned columns report `CanResize=false`). - `CanSort=false` blocks header clicks, `SortByColumn` (except `None`) and `ToggleSortDirection`, and clears the column's own active sort; sorts through a source owned by another table return false; `Sorted` is raised only when the table's sort state changes. - Cell peer constructor throws `E_INVALIDARG` on bad input; `BeginEdit` rolls back on failure. - Recycled rows reuse their cells unless cell automation peers exist; chrome refreshes once. > **Visible changes** > - Outer border uses `CardStrokeColorDefault`. > - Header lines are always shown, even when `GridLinesVisibility` is `None` or `Horizontal`. > - Group header restyled: 8px spacing; the count follows the header `Foreground`. > - Disabled header text and sort glyph dim. > - TableView samples no longer opt out of High Contrast backplates app-wide. ## Customer Impact Restylable column headers, visible header separators, Fluent-aligned outer border and group headers, UIA column resize for assistive technology, smoother scrolling and predictable sort events. ## Regression Potential - [ ] Low risk — isolated change, limited scope - [x] Medium risk — touches shared components or public APIs - [ ] High risk — architectural or breaking API change Header construction (focus restore, frozen columns, UIA peer, tooltips, resize, sort glyph) moved to a templated control. Sort event semantics are tighter: `CanSort` is enforced on programmatic sorts and fewer `Sorted` events fire. Outer border color and always-on header lines change visibly. Covered by new and existing tests. ## How Has This Been Tested? - [x] I have performed a self-review of my own code - [x] I have added tests to cover my changes - [x] Existing tests pass locally Full TableView API and interaction suites on test VMs: 877/882 pass at 224d10d5c; 3 Localization tests are [Ignore] and 2 intermittent failures passed 3/3 on rerun. Product, test apps and TableView sample apps build (x64 chk). Also covered: `VerifyDisabledGroupHeaderCountFollowsContentTemplateChanges`. Key new tests: - `VerifyColumnHeaderTemplateParts`, `VerifyColumnHeaderSortStates`, `VerifyColumnHeaderTypographyHasNoLocalValues` - `VerifyColumnHeaderStyleApplies`, `VerifyBasedOnOnlyColumnHeaderStyleApplies`, `VerifyIncompatibleColumnHeaderStyleIsIgnored` - `VerifyHeaderGridLinesShowWhateverTheBodyGridLines`, `VerifyTransparentHeaderSeparatorBrushHidesHeaderLines`, `VerifyGridLineAndOuterBorderBrushesMatchFluentStrokeTokens` - `VerifyDisablingHighContrastHoveredHeaderKeepsDisabledForeground`, `VerifyDefaultGroupHeaderCountInheritsForegroundThatFollowsStates` - `VerifyTransformResizeAccountsForAncestorScale`, `VerifyTransformResizeSmallWidthChangeWritesOnce`, `VerifyHeaderDisabledByStyleIsNotEnabledOrInvokable` - `VerifySortByColumnRespectsCanSort`, `VerifyImplicitClearKeepsSourceSort`, `VerifyUngatingKeepsAppLitColumnWithoutEvents`, `VerifySortOptOutDuringBeginningEditKeepsTheEditOpen` - `VerifyRecycledRowWithoutCellPeersReusesItsCells`, `VerifyHeaderFocusStaysInHeaderBandWhenColumnsReplaced`, `VerifyBeginEditThatThrowsRollsBackAndAllowsALaterEdit`, `VerifyCellPeerConstructorValidatesArguments` --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 94961bb8-d187-483c-bece-19e203752c67
325 lines
15 KiB
C#
325 lines
15 KiB
C#
// Copyright (c) Microsoft Corporation. All rights reserved.
|
|
// Licensed under the MIT License. See LICENSE in the project root for license information.
|
|
|
|
using Microsoft.UI.Private.Controls;
|
|
using Microsoft.UI.Xaml;
|
|
using Microsoft.UI.Xaml.Controls;
|
|
using Microsoft.UI.Xaml.Controls.Tabular;
|
|
using MUXControlsTestApp.Utilities;
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
|
|
using WEX.Logging.Interop;
|
|
using WEX.TestExecution;
|
|
using WEX.TestExecution.Markup;
|
|
|
|
using static Microsoft.UI.Xaml.Tests.MUXControls.ApiTests.TableViewTestHelpers;
|
|
using static Microsoft.UI.Xaml.Tests.MUXControls.ApiTests.TableViewShapingTestHelpers;
|
|
using static Microsoft.UI.Xaml.Tests.MUXControls.ApiTests.TableViewSortingTestHelpers;
|
|
using static Microsoft.UI.Xaml.Tests.MUXControls.ApiTests.TableViewSizingTestHelpers;
|
|
|
|
namespace Microsoft.UI.Xaml.Tests.MUXControls.ApiTests
|
|
{
|
|
// Handing a single-owner TableViewSource between tables (TableViewSource.idl), and the state that
|
|
// must not follow the source to its next owner.
|
|
[TestClass]
|
|
public class TableViewSourceOwnershipTests : TableViewApiTestBase
|
|
{
|
|
[TestMethod]
|
|
[TestProperty("Description", "Verifies an ItemsSource assigned while the previous source is being handed to a waiting table wins over the assignment that released it.")]
|
|
public void VerifyItemsSourceAssignedDuringHandoffWins()
|
|
{
|
|
TableView owner = null;
|
|
TableView waiter = null;
|
|
TableViewSource shared = null;
|
|
List<ShapedPerson> reentrant = null;
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
shared = TableViewSource.From(MakeShapedPeople());
|
|
owner = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
waiter = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
var host = new StackPanel();
|
|
host.Children.Add(owner);
|
|
host.Children.Add(waiter);
|
|
LoadContent(host);
|
|
});
|
|
|
|
SettleLayout(owner);
|
|
SettleLayout(waiter);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
Verify.AreEqual(0, GetRowsRepeater(waiter).ItemsSourceView?.Count ?? 0, "Precondition: the waiter is refused.");
|
|
|
|
reentrant = new List<ShapedPerson>
|
|
{
|
|
new ShapedPerson("Lena", "Engineer", "Platform"),
|
|
new ShapedPerson("Tom", "Designer", "Studio"),
|
|
};
|
|
|
|
// The waiter is handed the source synchronously from inside the owner's ItemsSource
|
|
// change, and an app reacting to that assigns the owner's ItemsSource again.
|
|
var repeater = GetRowsRepeater(waiter);
|
|
bool reassigned = false;
|
|
long token = repeater.RegisterPropertyChangedCallback(ItemsRepeater.ItemsSourceProperty, (sender, dp) =>
|
|
{
|
|
if (!reassigned && ((ItemsRepeater)sender).ItemsSource != null)
|
|
{
|
|
reassigned = true;
|
|
owner.ItemsSource = reentrant;
|
|
}
|
|
});
|
|
|
|
owner.ItemsSource = new List<ShapedPerson> { new ShapedPerson("Kai", "Architect", "Research") };
|
|
repeater.UnregisterPropertyChangedCallback(ItemsRepeater.ItemsSourceProperty, token);
|
|
|
|
Verify.IsTrue(reassigned, "Precondition: the waiter must claim the source during the owner's reassignment.");
|
|
Verify.AreSame(reentrant, owner.ItemsSource, "Precondition: the nested assignment is the owner's ItemsSource.");
|
|
});
|
|
|
|
SettleLayout(owner);
|
|
SettleLayout(waiter);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(new[] { "Lena", "Tom" }, RowValues(owner, person => person.Name),
|
|
"the owner must render the newest ItemsSource, not the one whose assignment released the shared source");
|
|
VerifySequence(SourceOrderNames, RowValues(waiter, person => person.Name),
|
|
"the waiter must render the source it claimed");
|
|
});
|
|
}
|
|
|
|
[TestMethod]
|
|
[TestProperty("Description", "Verifies a comparer sort a former owner left on a TableViewSource is cleared by the next owner and not driven by the former owner's later sorts.")]
|
|
public void VerifyComparerSortDoesNotFollowSourceToNextOwner()
|
|
{
|
|
TableView first = null;
|
|
TableView second = null;
|
|
TableViewSource shared = null;
|
|
StackPanel host = null;
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
shared = TableViewSource.From(MakeShapedPeople());
|
|
first = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
first.Columns[0].CustomSortComparer = new LengthThenOrdinalComparer();
|
|
host = new StackPanel();
|
|
host.Children.Add(first);
|
|
LoadContent(host);
|
|
});
|
|
|
|
SettleLayout(first);
|
|
RunOnUIThread.Execute(() =>
|
|
Verify.IsTrue(first.SortByColumn(first.Columns[0], SortDirection.Ascending), "Precondition: the comparer column sorts."));
|
|
SettleLayout(first);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(new[] { "Mei", "Asha", "Ines", "Owen", "Rafa", "Diego" }, RowValues(first, person => person.Name),
|
|
"precondition: the comparer orders the shared source");
|
|
|
|
// The same item objects, so ranks the first table computes later would also key the
|
|
// shared source if its comparer state were still attached there.
|
|
first.ItemsSource = TableViewSource.From(GetProjectedItems(first).Cast<ShapedPerson>().OrderBy(person => person.Name).ToList());
|
|
|
|
second = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
second.Columns[0].CustomSortComparer = new LengthThenOrdinalComparer();
|
|
host.Children.Add(second);
|
|
});
|
|
|
|
SettleLayout(first);
|
|
SettleLayout(second);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
Verify.IsTrue(first.SortByColumn(first.Columns[0], SortDirection.Descending), "The former owner sorts its new source."));
|
|
SettleLayout(first);
|
|
|
|
// Re-project the shared source so it re-reads whatever sort keys it still has.
|
|
RunOnUIThread.Execute(() => shared.Filter(item => Person(item).Name != "Asha"));
|
|
SettleLayout(second);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(new[] { "Diego", "Rafa", "Owen", "Ines", "Asha", "Mei" }, RowValues(first, person => person.Name),
|
|
"the former owner's new source follows its own comparer sort");
|
|
VerifySequence(new[] { "Diego", "Mei", "Rafa", "Ines", "Owen" }, RowValues(second, person => person.Name),
|
|
"the shared source must be unsorted once its new owner has dropped the former owner's comparer axis");
|
|
foreach (var column in second.Columns)
|
|
{
|
|
Verify.AreEqual(SortDirection.None, column.SortDirection,
|
|
"The new owner must not report a sort for an axis it cleared.");
|
|
}
|
|
});
|
|
}
|
|
|
|
[TestMethod]
|
|
[TestProperty("Description", "Verifies clearing a column on an unloaded table leaves the sort of the shared TableViewSource its new owner shows.")]
|
|
public void VerifyUnloadedTableClearKeepsSharedSourceSort()
|
|
{
|
|
TableView first = null;
|
|
TableView second = null;
|
|
TableViewSource shared = null;
|
|
StackPanel host = null;
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
shared = TableViewSource.From(MakeShapedPeople());
|
|
first = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
host = new StackPanel();
|
|
host.Children.Add(first);
|
|
LoadContent(host);
|
|
});
|
|
|
|
SettleLayout(first);
|
|
RunOnUIThread.Execute(() => shared.Sort("Name", SortDirection.Descending));
|
|
SettleLayout(first);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
Verify.AreEqual(SortDirection.Descending, first.Columns[0].SortDirection, "Precondition: the source sort lights the first table.");
|
|
host.Children.Remove(first);
|
|
second = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
host.Children.Add(second);
|
|
});
|
|
|
|
SettleLayout(second);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(Enumerable.Reverse(NameAscendingOrder).ToList(), RowValues(second, person => person.Name),
|
|
"precondition: the new owner shows the source sort");
|
|
first.SortByColumn(first.Columns[0], SortDirection.None);
|
|
Verify.AreEqual(SortDirection.None, first.Columns[0].SortDirection, "The unloaded table clears its own column.");
|
|
});
|
|
|
|
SettleLayout(second);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(Enumerable.Reverse(NameAscendingOrder).ToList(), RowValues(second, person => person.Name),
|
|
"a table that released the shared source must not clear the sort its new owner shows");
|
|
Verify.AreEqual(SortDirection.Descending, second.Columns[0].SortDirection, "The new owner keeps its indicator.");
|
|
});
|
|
}
|
|
|
|
[TestMethod]
|
|
[TestProperty("Description", "Verifies a clear made before the table first loads still holds after it loads.")]
|
|
public void VerifyClearBeforeLoadedStaysCleared()
|
|
{
|
|
TableView tableView = null;
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
tableView = CreateTableView(TableViewSource.From(MakeShapedPeople()), headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
Verify.IsTrue(tableView.SortByColumn(tableView.Columns[0], SortDirection.Descending), "Precondition: the unloaded table sorts.");
|
|
Verify.IsTrue(tableView.ClearSort(), "Precondition: the unloaded table clears its sort.");
|
|
LoadContent(tableView);
|
|
});
|
|
|
|
SettleLayout(tableView);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
Verify.AreEqual(SortDirection.None, tableView.Columns[0].SortDirection, "The cleared column must stay cleared once the table loads.");
|
|
VerifySequence(SourceOrderNames, RowValues(tableView, person => person.Name), "the rows must stay in source order");
|
|
});
|
|
}
|
|
|
|
[TestMethod]
|
|
[TestProperty("Description", "Verifies sorting an unloaded table leaves the shared TableViewSource its new owner shows unchanged.")]
|
|
public void VerifyUnloadedTableSortKeepsSharedSourceOrder()
|
|
{
|
|
TableView first = null;
|
|
TableView second = null;
|
|
TableViewSource shared = null;
|
|
StackPanel host = null;
|
|
int sortingCount = 0;
|
|
int sortedCount = 0;
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
shared = TableViewSource.From(MakeShapedPeople());
|
|
first = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
host = new StackPanel();
|
|
host.Children.Add(first);
|
|
LoadContent(host);
|
|
});
|
|
|
|
SettleLayout(first);
|
|
RunOnUIThread.Execute(() => shared.Sort("Name", SortDirection.Descending));
|
|
SettleLayout(first);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
Verify.AreEqual(SortDirection.Descending, first.Columns[0].SortDirection, "Precondition: the source sort lights the first table.");
|
|
host.Children.Remove(first);
|
|
second = CreateTableView(shared, headers: new[] { "Name", "Role" }, width: 500, height: 300);
|
|
host.Children.Add(second);
|
|
});
|
|
|
|
SettleLayout(second);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(Enumerable.Reverse(NameAscendingOrder).ToList(), RowValues(second, person => person.Name),
|
|
"precondition: the new owner shows the source sort");
|
|
first.Sorting += (s, e) => sortingCount++;
|
|
first.Sorted += (s, e) => sortedCount++;
|
|
Verify.IsFalse(first.SortByColumn(first.Columns[0], SortDirection.Ascending),
|
|
"A sort the shared source cannot take must report failure.");
|
|
});
|
|
|
|
SettleLayout(second);
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
VerifySequence(Enumerable.Reverse(NameAscendingOrder).ToList(), RowValues(second, person => person.Name),
|
|
"a table that released the shared source must not re-sort the rows its new owner shows");
|
|
Verify.AreEqual(SortDirection.Descending, second.Columns[0].SortDirection, "The new owner keeps its indicator.");
|
|
Verify.AreEqual(0, sortingCount, "A refused sort must not raise Sorting.");
|
|
Verify.AreEqual(0, sortedCount, "A refused sort must not raise Sorted.");
|
|
Verify.AreEqual(SortDirection.Descending, first.Columns[0].SortDirection, "A refused sort leaves the column state unchanged.");
|
|
});
|
|
}
|
|
}
|
|
|
|
[TestClass]
|
|
public class TableViewResizeCancelTests : TableViewApiTestBase
|
|
{
|
|
[TestMethod]
|
|
[TestProperty("Description", "Verifies a canceled resize applies gripper availability changes deferred while the drag was in flight.")]
|
|
public void VerifyCanceledResizeRefreshesGripperAvailability()
|
|
{
|
|
TableView tableView = null;
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
tableView = CreateResizableTable(
|
|
("Name", new GridLength(150.0, GridUnitType.Pixel)),
|
|
("Role", new GridLength(150.0, GridUnitType.Pixel)));
|
|
LoadContent(tableView);
|
|
});
|
|
|
|
IdleSynchronizer.Wait();
|
|
|
|
RunOnUIThread.Execute(() =>
|
|
{
|
|
var gripper = RequireGripper(tableView, 0);
|
|
var siblingGripper = RequireGripper(tableView, 1);
|
|
Verify.AreEqual(Visibility.Visible, siblingGripper.Visibility, "Precondition: the sibling column is resizable.");
|
|
|
|
gripper.BeginDrag();
|
|
// Pins the sibling while availability refreshes are held for the drag.
|
|
tableView.Columns[1].MinWidth = 150.0;
|
|
tableView.Columns[1].MaxWidth = 150.0;
|
|
gripper.EndDrag(true /* canceled */);
|
|
|
|
Verify.AreEqual(Visibility.Collapsed, siblingGripper.Visibility,
|
|
"A canceled drag must still apply the availability change it held back.");
|
|
});
|
|
}
|
|
}
|
|
}
|