Unexpected linter reports are found when verify fails, but accidentally
disabling or breaking a linter check (for example, when editing the
configuration files or updating golangci-lint) could only be detected manually
by adding code which triggers the linter.
Now test cases in hack/testdata/golangci-lint provide expected linter
messages to detect such regressions. The test in test/integration/golangci-lint
verifies that all of them are reported and also fails when there are unexpected
reports for things which we intentionally do not enforce.
The test also verifies that all enabled linters are either covered or
documented as not being tested via "<linter> untested" comments. Stale comments
like that also cause a test failure.
Patrick Ohly
8532934eab