mirror of
https://github.com/apache/kafka.git
synced 2026-10-28 16:35:34 +08:00
ashwinpankajandClaude Opus 4.7
de8482a4e2
## Summary Follow-up nits from @chia7712's review of #21337. None affects checker behaviour; grouped as a single small PR. JIRA: [KAFKA-20779](https://issues.apache.org/jira/browse/KAFKA-20779) ## Changes | # | File | Change | |---|------|--------| | 1 | `core/…/PublicApiViolation.java` | `equals` uses `Objects.equals(memberName, …)` instead of the ternary null-check. | | 2 | `core/…/CascadeValidator.java` | `asSuppression` omits `#member` when the finding has no `memberName`, so class-scope `INVALID_SUPERTYPE` suppressions no longer render as `…Owner#null`. Also uses ASCII hyphens in the description separator. | | 3 | `maven-plugin/…/KafkaInternalApiCheckerMojo.java` | Doc comments + `@param` tags on the class default ctor + six setters; `:maven-plugin:javadoc` is now warning-free. | | 4 | `api-checker/build.gradle` | Adds `testLogging { events "passed", "skipped", "failed" }` for consistency with the main Kafka build. | | 5 | `api-checker/README.md` | Documents `:maven-plugin:test`; layout tree shows the test folder. | Hooking `:api-checker:*:check` into the root `check` was dropped from this PR per review — Kafka's CI relies on `kafka.test.xml.output.dir` + `copyTestXml` to collect outputs from composite-included builds, so that wiring needs a proper follow-up rather than being folded in here. ## Test plan - [x] `./gradlew :api-checker:core:check :api-checker:gradle-plugins:check :api-checker:maven-plugin:check` — clean; all api-checker verification tasks pass. - [x] `./gradlew :api-checker:maven-plugin:javadoc` — zero warnings. Reviewers: Chia-Ping Tsai <chia7712@gmail.com> --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>