There are currently many failures on the amd64 darwin builders. Maybe ~half of these failures include a failed TestIssue18676 test due to a timed out command, which uses a hard-coded 10 second timeout. Watchflakes issue #67081 currently has ~350 failures for this test, with several every day recently that seem to be timeouts. Many other hard-coded test command timeouts were converted by Bryan to instead use testenv.Command, which uses a longer timeout based on the t.Deadline (and also takes into account test scaling for slow builders) and also usually gets a goroutine dump on most platforms. Hence, this CL replaces this hard-coded timeout with testenv.Command. Optimistically marking #67081 and older #44548 as fixed, though we'll see. Fixes #67081 Fixes #44548 Change-Id: Ic9e7607800e91b8d813cb4fb2b11b16bfb48b8c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/854987 Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: PJ Malloy <pjmalloy@google.com>
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 4.0 Attribution license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://go.dev/dl/.
After downloading a binary release, visit https://go.dev/doc/install for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://go.dev/doc/install/source for source installation instructions.
Contributing
Go is the work of thousands of contributors. We appreciate your help!
To contribute, please read the contribution guidelines at https://go.dev/doc/contribute.
Note that the Go project uses the issue tracker for bug reports and proposals only. See https://go.dev/wiki/Questions for a list of places to ask questions about the Go language.