mirror of
https://github.com/redis/go-redis.git
synced 2026-10-28 08:24:54 +08:00
Yingzi ZhangandNedyalko Dyakov
fecce1ac79
* fix(cmd): allow = in CLIENT INFO values Redis accepts "=" in a client name, a user name and lib-name, and go-redis puts Options.IdentitySuffix into lib-name. parseClientInfo split each field on every "=" and rejected a field with more than one, so ClientInfo and ACLLog failed with "unexpected client info data". Split each field at the first "=" only. * Update client_info_internal_test.go --------- Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
52 lines
2.1 KiB
Go
52 lines
2.1 KiB
Go
package redis
|
|
|
|
import "testing"
|
|
|
|
// TestParseClientInfoForwardCompatFlags pins that parseClientInfo (shared by
|
|
// CLIENT INFO and CLIENT LIST) tolerates client-flag characters it does not
|
|
// recognize instead of failing the whole reply. Previously an unrecognized
|
|
// flag character produced "redis: unexpected client info flags(...)" and broke
|
|
// CLIENT TRACKING tests. New flag characters can appear over time, so the
|
|
// parser must skip the ones it does not map while keeping the ones it does.
|
|
func TestParseClientInfoForwardCompatFlags(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
flags string
|
|
want ClientFlags // bits that must be set; unknown flags must not error
|
|
}{
|
|
{"single unknown", "m", 0},
|
|
{"multiple unknown", "go", 0},
|
|
{"known plus unknown", "tm", ClientTracking},
|
|
{"known combo plus unknown", "Btm", ClientTrackingBCAST | ClientTracking},
|
|
{"no-flag sentinel", "N", 0},
|
|
}
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
info, err := parseClientInfo("id=1 addr=127.0.0.1:6379 flags=" + tc.flags + " db=0")
|
|
if err != nil {
|
|
t.Fatalf("parseClientInfo(flags=%q) errored: %v", tc.flags, err)
|
|
}
|
|
if info.Flags&tc.want != tc.want {
|
|
t.Fatalf("flags=%q: Flags=%b, want bits %b set", tc.flags, info.Flags, tc.want)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestParseClientInfoEqualsInValue pins that a value can contain "=". Redis
|
|
// accepts "=" in a client name, a user name and lib-name, and go-redis puts
|
|
// Options.IdentitySuffix into lib-name, so the parser must split each field
|
|
// at the first "=" only.
|
|
func TestParseClientInfoEqualsInValue(t *testing.T) {
|
|
info, err := parseClientInfo("id=1 addr=127.0.0.1:6379 name=app=web user=a=b lib-name=go-redis(env=prod,go1.26.0) db=0")
|
|
if err != nil {
|
|
t.Fatalf("parseClientInfo errored: %v", err)
|
|
}
|
|
if info.Name != "app=web" || info.User != "a=b" || info.LibName != "go-redis(env=prod,go1.26.0)" {
|
|
t.Fatalf("Name=%q User=%q LibName=%q", info.Name, info.User, info.LibName)
|
|
}
|
|
if _, err := parseClientInfo("id=1 garbage db=0"); err == nil {
|
|
t.Fatal("a field without \"=\" must still return an error")
|
|
}
|
|
}
|