BREAKING CHANGE: `AdminService.UpdateUserLDAPMapping` and `UpdateTeamLDAPMapping` now take `UpdateUserLDAPMappingRequest` and `UpdateTeamLDAPMappingRequest` (with non-pointer `LDAPDN`) by value.
Fixes: #3103.
BREAKING-CHANGE: The following endpoints now take `owner` and `repo` (string) names instead of an integer repo ID:
ActionsService.ListEnvVariables
ActionsService.GetEnvVariable
ActionsService.CreateEnvVariable
ActionsService.UpdateEnvVariable
ActionsService.DeleteEnvVariable
This is a large breaking API change. It is unavoidable and necessary
to resolve#526. This breaking change is part of bump to libraryVersion 3.
It adds ctx context.Context as first parameter to all endpoint methods,
including Do.
Updating for this API change should be easy and the compiler will help
catch instances that need to be updated. For example:
main.go:193: not enough arguments in call to gh.Activity.MarkRepositoryNotificationsRead
have (string, string, time.Time)
want (context.Context, string, string, time.Time)
...
You should pass the available context as first parameter. If your code
does not have context.Context available and you want to maintain previous
normal behavior, use context.Background(). Don't pass nil context; use
context.TODO() instead if you wish to delay figuring out the best context
to use. Then you can address the TODO at a later time.
Refer to documentation of package context at https://godoc.org/context
for more information.
This commit also changes ./tests/fields to use context.Background()
instead of deprecated oauth2.NoContext.
Resolves#526.
Glenn Lewis