mirror of
https://github.com/electron/electron.git
synced 2026-10-28 11:44:46 +08:00
Shelley Vohr
ce43de584d
* refactor: give the borrowed SpellcheckServiceFactory Electron-side Profile stubs Electron compiles //chrome's SpellcheckServiceFactory, which derives from ProfileKeyedServiceFactory and builds a ProfileSelections. To link those two, chromium_src also compiled chrome/browser/profiles/ profile_keyed_service_factory.cc and profile_selections.cc and then patched the Profile calls out of them. Define the handful of members the factory needs in shell/browser/profiles instead: the constructors, a GetBrowserContextToUse() that returns the context it is given, and ProfileSelections construction. Nothing in Electron applies the selections. Removes remove_usage_of_incognito_apis_in_the_spellchecker.patch and the profile_selections.cc hunks of chore_patch_out_profile_methods.patch. * refactor: dock devtools through the currentDockState preference The DevTools frontend's DockController reads the currentDockState setting from the embedder's preference store when it initializes and docks itself through InspectorFrontendHost.setIsDocked(). InspectableWebContents serves that store, so it can resolve the requested dock side before loading the frontend and hand it out from GetPreferences()/GetPreference() instead of calling into a UI module the frontend was patched to expose as globalThis.EUI after load. The two specs that used EUI to switch panels import ui/legacy/legacy.js from the DevTools page instead. Removes devtools_frontend/chore_expose_ui_to_allow_electron_to_set_dock_side.patch.