mirror of
https://github.com/electron/electron.git
synced 2026-10-28 11:44:46 +08:00
* refactor: manage gin_helper callbacks with cppgc Build gin_helper callback holders on gin::internal::CallbackHolderBase, which wraps a cppgc managed object in v8::CppHeapExternal. This follows https://crrev.com/c/8485746, which is backported here as a Chromium patch until the next roll includes it. Because v8::CppHeapExternal is not a v8::Object, it has no creation context, so a FunctionTemplate or ObjectTemplate that caches a holder no longer retains a discarded context. This removes the need for the per-context template storage. * chore: address review feedback * chore: address review feedback