From bcc5c510df7abedb85fd11843e3607e9115c0566 Mon Sep 17 00:00:00 2001 From: "claude[bot]" <209825114+claude[bot]@users.noreply.github.com> Date: Sat, 17 Oct 2026 21:16:40 -0700 Subject: [PATCH] test: re-enable Node.js tests that now pass with BoringSSL (#55071) * test: re-enable Node.js tests that now pass with BoringSSL Most of these were disabled because BoringSSL behaved differently from OpenSSL. Upstream Node.js made the tests BoringSSL-aware in nodejs/node#63161 (v24.18.0) and fixed the ML-KEM expectations in nodejs/node#65966 (v24.22.0), so they now pass. The es-module/test-esm-wasm entry is a stale prefix: test.py matches entries as substrings of the path, so it was hiding 13 split files that pass. A few entries are dropped because the tests now skip themselves. parallel/test-cluster-primary-error, parallel/test-cluster-primary-kill, parallel/test-diagnostics-channel-memory-leak and parallel/test-worker-resource-limits move to the flaky list instead. Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M * test: keep two node tests disabled that crash on the testing build test-vm-compile-function-lineoffset hits a V8 Smi::IsValid debug check and test-domain-error-types segfaults under --stress-compaction. Co-Authored-By: Claude Opus 5.5 (1M context) Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M --------- Co-authored-by: Claude --- script/node-disabled-tests.json | 76 --------------------------------- script/node-flaky-tests.json | 4 ++ 2 files changed, 4 insertions(+), 76 deletions(-) diff --git a/script/node-disabled-tests.json b/script/node-disabled-tests.json index 09e38201ed..a20dfbd568 100644 --- a/script/node-disabled-tests.json +++ b/script/node-disabled-tests.json @@ -1,6 +1,4 @@ [ - "abort/test-abort-backtrace", - "es-module/test-esm-wasm", "es-module/test-esm-wasm-source-phase-dynamic", "es-module/test-esm-wasm-source-phase-identity", "es-module/test-esm-wasm-source-phase-no-execute", @@ -14,95 +12,22 @@ "parallel/test-bootstrap-modules", "parallel/test-child-process-fork-exec-path", "parallel/test-code-cache", - "parallel/test-cluster-primary-error", - "parallel/test-cluster-primary-kill", - "parallel/test-config-file", - "parallel/test-crypto-dh-stateless", - "parallel/test-crypto-fips", - "parallel/test-crypto-keygen", - "parallel/test-crypto-pqc-key-objects-ml-kem", - "parallel/test-crypto-secure-heap", - "parallel/test-diagnostics-channel-memory-leak", "parallel/test-domain-error-types", - "parallel/test-fs-utimes-y2K38", - "parallel/test-http2-clean-output", - "parallel/test-http2-https-fallback", - "parallel/test-http2-server-unknown-protocol", - "parallel/test-https-agent-session-reuse", - "parallel/test-https-client-renegotiation-limit", - "parallel/test-https-options-boolean-check", - "parallel/test-icu-env", - "parallel/test-icu-minimum-version", - "parallel/test-inspector-port-zero-cluster", - "parallel/test-inspector-tracing-domain", "parallel/test-module-loading-globalpaths", - "parallel/test-module-print-timing", "parallel/test-openssl-ca-options", "parallel/test-os-checked-function", "parallel/test-process-versions", - "parallel/test-repl-mode", "parallel/test-promise-swallowed-event", "parallel/test-repl-underscore", "parallel/test-runner-v8-deserializer", "parallel/test-snapshot", "parallel/test-strace-openat-openssl", - "parallel/test-sqlite-backup", "parallel/test-max-old-space-size-percentage", - "parallel/test-tls-alpn-server-client", - "parallel/test-tls-cli-min-version-1.0", - "parallel/test-tls-cli-max-version-1.2", - "parallel/test-tls-cli-max-version-1.3", - "parallel/test-tls-cli-min-version-1.1", - "parallel/test-tls-cli-min-version-1.2", - "parallel/test-tls-cli-min-version-1.3", - "parallel/test-tls-client-auth", - "parallel/test-tls-client-getephemeralkeyinfo", - "parallel/test-tls-client-mindhsize", - "parallel/test-tls-client-reject", - "parallel/test-tls-client-renegotiation-13", "parallel/test-tls-cnnic-whitelist", - "parallel/test-tls-disable-renegotiation", - "parallel/test-tls-empty-sni-context", - "parallel/test-tls-error-stack", - "parallel/test-tls-finished", - "parallel/test-tls-generic-stream", - "parallel/test-tls-getcipher", - "parallel/test-tls-getprotocol", - "parallel/test-tls-handshake-error", - "parallel/test-tls-handshake-exception", - "parallel/test-tls-hello-parser-failure", - "parallel/test-tls-honorcipherorder", - "parallel/test-tls-junk-closes-server", - "parallel/test-tls-junk-server", - "parallel/test-tls-key-mismatch", - "parallel/test-tls-max-send-fragment", - "parallel/test-tls-min-max-version", - "parallel/test-tls-multi-key", - "parallel/test-tls-multi-pfx", - "parallel/test-tls-no-cert-required", "parallel/test-tls-off-thread-cert-loading", - "parallel/test-tls-options-boolean-check", - "parallel/test-tls-passphrase", - "parallel/test-tls-psk-alpn-callback-exception-handling", - "parallel/test-tls-psk-circuit", - "parallel/test-tls-reduced-SECLEVEL-in-cipher", - "parallel/test-tls-server-failed-handshake-emits-clienterror", - "parallel/test-tls-set-ciphers", - "parallel/test-tls-set-ciphers-error", - "parallel/test-tls-set-default-ca-certificates-extra-override", - "parallel/test-tls-set-default-ca-certificates-recovery", - "parallel/test-tls-set-sigalgs", - "parallel/test-tls-socket-allow-half-open-option", - "parallel/test-tls-socket-failed-handshake-emits-error", - "parallel/test-tls-ticket", - "parallel/test-tls-ticket-cluster", "parallel/test-trace-events", - "parallel/test-tz-version", "parallel/test-warn-multipleResolves", "parallel/test-webcrypto-keygen", - "parallel/test-worker-no-sab", - "parallel/test-worker-resource-limits", - "parallel/test-zlib-unused-weak", "report/test-report-fatalerror-oomerror", "report/test-report-getreport", "report/test-report-signal", @@ -112,7 +37,6 @@ "report/test-report-worker", "report/test-report-writereport", "sea/test-single-executable", - "sequential/test-tls-connect", "wpt/test-webcrypto", "wasm-allocation/test-wasm-allocation" ] diff --git a/script/node-flaky-tests.json b/script/node-flaky-tests.json index a49b87b093..ac45cf551e 100644 --- a/script/node-flaky-tests.json +++ b/script/node-flaky-tests.json @@ -1,13 +1,17 @@ [ "parallel/test-cluster-bind-privileged-port", + "parallel/test-cluster-primary-error", + "parallel/test-cluster-primary-kill", "parallel/test-cluster-shared-handle-bind-privileged-port", "parallel/test-debugger-random-port-with-inspect-port", + "parallel/test-diagnostics-channel-memory-leak", "parallel/test-fetch", "parallel/test-heapsnapshot-near-heap-limit-by-api-in-worker", "parallel/test-heapsnapshot-near-heap-limit-worker", "parallel/test-inspector-multisession-ws", "parallel/test-inspector-stop-profile-after-done", "parallel/test-macos-app-sandbox", + "parallel/test-worker-resource-limits", "sequential/test-cpu-prof-default", "sequential/test-cpu-prof-dir-absolute", "sequential/test-cpu-prof-dir-and-name",