mirror of
https://github.com/coollabsio/coolify.git
synced 2026-10-29 01:54:37 +08:00
Andras BacsaiandClaude Opus 5.5
b850a06d26
Laravel writes bootstrap/cache/config.php in place, so the file is empty until the write ends. app:init rebuilds the cache on every container start while PHP-FPM already serves requests. A request could read the empty file (TypeError in LoadConfiguration), and OPcache with validate_timestamps=0 kept it, so every request failed until a restart. Write to a temporary file in the same directory and rename it over the target. A failed write now keeps the old file instead of an empty one. Fixes #12120 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
54 lines
1.7 KiB
PHP
54 lines
1.7 KiB
PHP
<?php
|
|
|
|
use App\Support\AtomicFilesystem;
|
|
use Illuminate\Foundation\Console\ConfigCacheCommand;
|
|
use Illuminate\Foundation\Console\RouteCacheCommand;
|
|
|
|
beforeEach(function () {
|
|
$this->directory = sys_get_temp_dir().'/atomic-filesystem-'.bin2hex(random_bytes(4));
|
|
mkdir($this->directory);
|
|
});
|
|
|
|
afterEach(function () {
|
|
array_map('unlink', glob($this->directory.'/*'));
|
|
rmdir($this->directory);
|
|
});
|
|
|
|
it('writes the config and route caches with the atomic filesystem', function (string $command) {
|
|
$files = (fn () => $this->files)->call(app($command));
|
|
|
|
expect($files)->toBeInstanceOf(AtomicFilesystem::class);
|
|
})->with([
|
|
'config:cache' => ConfigCacheCommand::class,
|
|
'route:cache' => RouteCacheCommand::class,
|
|
]);
|
|
|
|
it('replaces the file with a new complete file and leaves no temporary file', function () {
|
|
$path = $this->directory.'/config.php';
|
|
file_put_contents($path, '<?php return [];');
|
|
$oldInode = fileinode($path);
|
|
$previousUmask = umask(0022);
|
|
|
|
try {
|
|
$bytes = (new AtomicFilesystem)->put($path, "<?php return ['app' => ['name' => 'Coolify']];");
|
|
} finally {
|
|
umask($previousUmask);
|
|
}
|
|
|
|
clearstatcache();
|
|
expect($bytes)->toBe(46)
|
|
->and(require $path)->toBe(['app' => ['name' => 'Coolify']])
|
|
->and(fileinode($path))->not->toBe($oldInode)
|
|
->and(fileperms($path) & 0777)->toBe(0644)
|
|
->and(glob($this->directory.'/*'))->toBe([$path]);
|
|
});
|
|
|
|
it('does not write the file outside its directory', function () {
|
|
$path = $this->directory.'/missing/config.php';
|
|
|
|
expect(fn () => (new AtomicFilesystem)->put($path, '<?php return [];'))
|
|
->toThrow(RuntimeException::class, 'Could not create a temporary file');
|
|
|
|
expect(file_exists($path))->toBeFalse();
|
|
});
|