From 40cfca57475871d6abf5eb6e3db2b7e4ac72a126 Mon Sep 17 00:00:00 2001 From: Maksym Pavlenko Date: Mon, 26 Oct 2026 14:20:05 -0700 Subject: [PATCH] ci: pass TEST_RUNTIME explicitly to the runsc critest The runsc job runs on ubuntu-latest, which is moving to Ubuntu 26.04, whose sudo (sudo-rs) does not support -E ("preserving the entire environment is not supported, '-E' is ignored"). critest.sh then fails on the unset TEST_RUNTIME, the only variable the step did not pass explicitly. Pass it on the sudo command line with the others and drop -E. Signed-off-by: Maksym Pavlenko --- .github/workflows/ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b9d7fc5629..d3351d5711 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -765,8 +765,9 @@ jobs: cfg=$(mktemp /tmp/containerd-config-runsc-XXXXXX.toml) trap 'rm -f "$cfg"' EXIT script/runsc/write-containerd-runsc-config.sh "$cfg" "$CGROUP_DRIVER" - sudo -E \ + sudo \ CGROUP_DRIVER="$CGROUP_DRIVER" \ + TEST_RUNTIME="$TEST_RUNTIME" \ CONTAINERD_CONFIG_FILE="$cfg" \ GOMAXPROCS="$GOMAXPROCS" \ GOMEMLIMIT="$GOMEMLIMIT" \