`reviewdog` runs every runner concurrently in the repository root, and
two of them are `pnpm -C web exec eslint` and `pnpm -C docs exec
eslint`. Every `pnpm exec` writes two or three filesystem probe files
named `_tmp_<pid>_<hex>` into the directory it runs in and unlinks them
immediately, so `web/` and `docs/` gain and lose untracked files while
the `typos` runner is walking them.
Nothing ignores those names, so the walk yields one and the
`canonicalize()` in `walk_entry` then fails with `ENOENT`. Since v1.50.2
that no longer aborts the process, but it is still reported as an error,
which makes `typos` exit 1 rather than 0 or 2. `run_typos` reads any
other exit code as `typos` itself failing and emits `typos failed (exit
1): error: No such file or directory (os error 2)` against
`.reviewdog.yml`, so the linting step fails on a tree that has nothing
wrong with it. Nine of the last six hundred linting steps failed this
way, and the second `reviewdog` pass in `post-command` passed on the
same tree each time.
Excluding the name closes the window rather than narrowing it, since the
walker matches it against the `readdir` entry and never canonicalizes or
reads the path. Churning probe files through `web/`, `docs/` and
`internal/` while running `.buildkite/steps/lint.sh typos .` fails ten
times out of ten without the exclusion and zero times out of ten with
it.
`crate-ci/typos#1622` proposes skipping a vanished path during the walk
instead of reporting it, which would make this unnecessary, but it is
neither merged nor released.
Signed-off-by: Amir Zarrinkafsh <3339418+nightah@users.noreply.github.com>
`typos`, `yamllint` and `trufflehog` are run against the whole tree
rather than the staged files, and `ignore-hidden = false` means `typos`
descends into dot directories. A worktree created under
`.claude/worktrees/` is a checkout of this repository nested inside it,
and every exclude these three configure is a path from the root, so none
of them match the same file one level down. The nested checkout is
therefore scanned as though it had no excludes at all: 22 findings from
`typos`, 4275 from `yamllint`, and a private key under
`internal/configuration/test_resources/` tripping `trufflehog`, none of
which are about the change being committed.
`typos` runs with `-w`, so this is not only noise. It rewrote seven
third-party files in a nested checkout, `LDAP_ORGANISATION` to
`LDAP_ORGANIZATION` among them, which would have broken the `LDAP` suite
in a tree nobody had edited.
Ignoring `.claude/worktrees/` keeps those checkouts out of `git status`,
and covers `typos` on its own because it honours the ignore file.
`yamllint` and `trufflehog` do not, so both keep an explicit exclude,
and `typos` keeps one as well so that all three say the same thing
rather than one of them depending on a default. Only the worktrees are
ignored, since anything else a project keeps under `.claude/` is worth
both committing and linting.
The Go linters need nothing: a nested checkout carries its own `go.mod`,
so `./...` never reaches it.
This reworks several of our policies to better conform to the OSPS
Baseline. In addition it adjusts the way policies are shown to users,
improves clarity around usage of artificial intelligence, and makes
several quality of life improvements to our policies including adjusting
the location of all governance information and articulates test related
information.
Add the typos (crate-ci/typos) spell checker with en-US locale
configuration and integrate it into the lefthook pre-commit hooks and
reviewdog runner. Fix all existing spelling errors across documentation,
Go source, test files, configuration templates, and locale files
including en-GB to en-US normalization.
Closes#11607.
Amir Zarrinkafsh