mirror of
https://github.com/apache/arrow.git
synced 2026-10-28 16:47:19 +08:00
Hiroyuki Sato
6efe7b3833
### Rationale for this change This is the sub issue #44748. * SC2086: Double quote to prevent globbing and word splitting * SC2012: Use find instead of ls to better handle non-alphanumeric filenames ``` shellcheck ci/scripts/python_test_emscripten.sh In ci/scripts/python_test_emscripten.sh line 28: cd ${build_dir} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cd "${build_dir}" In ci/scripts/python_test_emscripten.sh line 31: pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1) ^---------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames. In ci/scripts/python_test_emscripten.sh line 34: python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node In ci/scripts/python_test_emscripten.sh line 37: python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^-----------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome For more information: https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ``` ### What changes are included in this PR? * SC2086: Quote variables. * SC2012: skip shellcheck. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #47402 Authored-by: Hiroyuki Sato <hiroysato@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
40 lines
1.5 KiB
Bash
Executable File
40 lines
1.5 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
# run tests against Chrome and node.js as representative
|
|
# WebAssembly platforms (i.e. one browser, one non-browser).
|
|
|
|
set -ex
|
|
|
|
build_dir=${1}/python
|
|
pyodide_dist_dir=${2}
|
|
|
|
cd "${build_dir}"
|
|
|
|
# note: this uses the newest wheel in dist
|
|
# shellcheck disable=SC2012
|
|
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)
|
|
|
|
echo "-------------- Running emscripten tests in Node ----------------------"
|
|
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node
|
|
|
|
echo "-------------- Running emscripten tests in Chrome --------------------"
|
|
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome
|
|
|