Files
nishad shabbir 61f24ce27b GH-52024: [Python] Fix the codec list in show_info() (#51753)
### Rationale for this change

`pa.show_info()` prints its Compression Codecs section from a hardcoded list:

```python
codecs = ["brotli", "bz2", "gzip", "lz4_frame", "lz4", "snappy", "zstd"]
```

That list has drifted from `_ensure_compression()` in `io.pxi`, which is what
actually decides which codec names work. Two problems follow:

- `lz4` and `lz4_frame` both map to `CCompressionType_LZ4_FRAME`, so the same
  codec is reported twice under two names.
- `lz4_raw` maps to `CCompressionType_LZ4` and is a separate codec, but it is
  not listed at all, even though `pa.Codec.is_available('lz4_raw')` is True.

So seven lines are printed for six codecs, and the codec that is missing is a
real one.

Before:

```
Compression Codecs:
  brotli              : Enabled
  bz2                 : Enabled
  gzip                : Enabled
  lz4_frame           : Enabled
  lz4                 : Enabled
  snappy              : Enabled
  zstd                : Enabled
```

After:

```
Compression Codecs:
  brotli              : Enabled
  bz2                 : Enabled
  gzip                : Enabled
  lz4                 : Enabled
  lz4_raw             : Enabled
  snappy              : Enabled
  zstd                : Enabled
```

### What changes are included in this PR?

One list in `python/pyarrow/__init__.py`: drop the duplicate `lz4_frame` and add
the missing `lz4_raw`. `lz4` is kept as the name for the frame codec since that
is the one the docstrings lead with (`'lz4' (or 'lz4_frame')`).

On deriving this programmatically rather than hardcoding it — agreed, that is
the better fix. The canonical mapping lives in `_ensure_compression()` in
`io.pxi`, and neither `Codec` nor the C++ `compression.h` currently exposes the
set of supported codecs, so it needs a new accessor on the Cython side for
`show_info()` to read. I am happy to do that here, with the caveat that I cannot
compile the Cython extension in my environment and would be relying on CI to
verify it. If you would prefer, I can keep this change minimal and open a
follow-up issue for the programmatic version. Let me know which you would rather
have.

### Are these changes tested?

Not by a new test. `show_info()` has no existing test coverage and its output is
a diagnostic print, so I did not want to pin the exact text without knowing
whether you would want that — happy to add one if you do.

Verified by applying the same change to an installed pyarrow and reading the
output back, and by walking every name `_ensure_compression()` accepts to
confirm which of them map onto the same C++ enum value:

```
bz2 -> BZ2, gzip -> GZIP, brotli -> BROTLI,
lz4 -> LZ4_FRAME, lz4_frame -> LZ4_FRAME,   # same codec, two names
lz4_raw -> LZ4,                             # distinct, was not listed
snappy -> SNAPPY, zstd -> ZSTD
```

### Are there any user-facing changes?

Only the output of `pa.show_info()`, which now lists each supported codec once
and includes `lz4_raw`. No API change.

### Was AI used for this PR?

In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR.

**PR code and description written by:**

- [x] Human
- [ ] AI

**Reviewed before submission by:**

- [x] Human
- [ ] AI
- [ ] Not reviewed

* GitHub Issue: #52024

Authored-by: nishad shabbir <nishadshabbir28@gmail.com>
Signed-off-by: Antoine Pitrou <antoine@python.org>
2026-10-19 14:24:36 +02:00

293 lines
8.2 KiB
Python

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
import os
import subprocess
import sys
import pytest
import pyarrow as pa
from pyarrow.lib import ArrowInvalid
def test_get_include():
include_dir = pa.get_include()
assert os.path.exists(os.path.join(include_dir, 'arrow', 'api.h'))
@pytest.mark.skipif('sys.platform != "win32"')
def test_get_library_dirs_win32():
assert any(os.path.exists(os.path.join(directory, 'arrow.lib'))
for directory in pa.get_library_dirs())
def test_cpu_count():
n = pa.cpu_count()
assert n > 0
try:
pa.set_cpu_count(n + 5)
assert pa.cpu_count() == n + 5
finally:
pa.set_cpu_count(n)
def test_io_thread_count():
n = pa.io_thread_count()
assert n > 0
try:
pa.set_io_thread_count(n + 5)
assert pa.io_thread_count() == n + 5
finally:
pa.set_io_thread_count(n)
@pytest.mark.processes
def test_env_var_io_thread_count():
# Test that the number of IO threads can be overridden with the
# ARROW_IO_THREADS environment variable.
code = """if 1:
import pyarrow as pa
print(pa.io_thread_count())
"""
def run_with_env_var(env_var):
env = os.environ.copy()
env['ARROW_IO_THREADS'] = env_var
res = subprocess.run([sys.executable, "-c", code], env=env,
capture_output=True)
res.check_returncode()
return res.stdout.decode(), res.stderr.decode()
out, err = run_with_env_var('17')
assert out.strip() == '17'
assert err == ''
for v in ('-1', 'z'):
out, err = run_with_env_var(v)
assert out.strip() == '8' # default value
assert "Invalid value for ARROW_IO_THREADS" in err.strip()
def test_build_info():
assert isinstance(pa.build_info.cpp_build_info, pa.CppBuildInfo)
assert isinstance(pa.cpp_version_info, pa.VersionInfo)
assert isinstance(pa.cpp_version, str)
assert isinstance(pa.__version__, str)
assert pa.build_info.cpp_build_info.version == pa.cpp_version
assert pa.build_info.cpp_build_info.version_info == pa.cpp_version_info
assert pa.build_info.cpp_build_info is pa.cpp_build_info
assert pa.build_info.cpp_build_info.build_type in (
'debug', 'release', 'minsizerel', 'relwithdebinfo')
assert isinstance(pa.build_info, pa.BuildInfo)
assert pa.build_info.build_type in (
'debug', 'release', 'minsizerel', 'relwithdebinfo')
# assert pa.version == pa.__version__ # XXX currently false
def test_runtime_info():
info = pa.runtime_info()
assert isinstance(info, pa.RuntimeInfo)
possible_simd_levels = ('none', 'sse4_2', 'avx', 'avx2', 'avx512')
assert info.simd_level in possible_simd_levels
assert info.detected_simd_level in possible_simd_levels
if info.simd_level != 'none':
env = os.environ.copy()
env['ARROW_USER_SIMD_LEVEL'] = 'none'
code = f"""if 1:
import pyarrow as pa
info = pa.runtime_info()
assert info.simd_level == 'none', info.simd_level
assert info.detected_simd_level == {info.detected_simd_level!r},\
info.detected_simd_level
"""
subprocess.check_call([sys.executable, "-c", code], env=env)
def test_show_info(capsys):
pa.show_info()
out = capsys.readouterr().out
# Which codecs and modules are enabled depends on how PyArrow was built,
# so only the labels are checked, not their status.
assert "Compression Codecs:" in out
codecs = [line.split(":")[0].strip()
for line in out.split("Compression Codecs:")[1].splitlines()
if ":" in line]
# "lz4" is an alias for "lz4_frame", so naming both listed one codec
# twice and left out lz4_raw.
assert codecs == ["brotli", "bz2", "gzip", "lz4_frame", "lz4_raw",
"snappy", "zstd"]
for section in ("Platform:", "Memory:", "Optional modules:",
"Filesystems:"):
assert section in out
@pytest.mark.processes
def test_import_at_shutdown():
# GH-38626: importing PyArrow at interpreter shutdown would crash
code = """if 1:
import atexit
def import_arrow():
import pyarrow
atexit.register(import_arrow)
"""
subprocess.check_call([sys.executable, "-c", code])
@pytest.mark.skipif(sys.platform == "win32",
reason="Path to timezone database is not configurable "
"on non-Windows platforms")
def test_set_timezone_db_path_non_windows():
# set_timezone_db_path raises an error on non-Windows platforms
with pytest.warns(FutureWarning, match="deprecated"):
with pytest.raises(ArrowInvalid,
match="Arrow was set to use OS timezone "
"database at compile time"):
pa.set_timezone_db_path("path")
@pytest.mark.parametrize('klass', [
pa.Field,
pa.Schema,
pa.ChunkedArray,
pa.RecordBatch,
pa.Table,
pa.Buffer,
pa.Array,
pa.Tensor,
pa.DataType,
pa.ListType,
pa.LargeListType,
pa.FixedSizeListType,
pa.ListViewType,
pa.LargeListViewType,
pa.UnionType,
pa.SparseUnionType,
pa.DenseUnionType,
pa.StructType,
pa.Time32Type,
pa.Time64Type,
pa.TimestampType,
pa.Decimal32Type,
pa.Decimal64Type,
pa.Decimal128Type,
pa.Decimal256Type,
pa.DictionaryType,
pa.FixedSizeBinaryType,
pa.NullArray,
pa.NumericArray,
pa.IntegerArray,
pa.FloatingPointArray,
pa.BooleanArray,
pa.Int8Array,
pa.Int16Array,
pa.Int32Array,
pa.Int64Array,
pa.UInt8Array,
pa.UInt16Array,
pa.UInt32Array,
pa.UInt64Array,
pa.ListArray,
pa.LargeListArray,
pa.MapArray,
pa.FixedSizeListArray,
pa.UnionArray,
pa.BinaryArray,
pa.StringArray,
pa.BinaryViewArray,
pa.StringViewArray,
pa.FixedSizeBinaryArray,
pa.DictionaryArray,
pa.Date32Array,
pa.Date64Array,
pa.TimestampArray,
pa.Time32Array,
pa.Time64Array,
pa.DurationArray,
pa.Decimal128Array,
pa.Decimal256Array,
pa.StructArray,
pa.RunEndEncodedArray,
pa.Scalar,
pa.BooleanScalar,
pa.Int8Scalar,
pa.Int16Scalar,
pa.Int32Scalar,
pa.Int64Scalar,
pa.UInt8Scalar,
pa.UInt16Scalar,
pa.UInt32Scalar,
pa.UInt64Scalar,
pa.HalfFloatScalar,
pa.FloatScalar,
pa.DoubleScalar,
pa.Decimal128Scalar,
pa.Decimal256Scalar,
pa.Date32Scalar,
pa.Date64Scalar,
pa.Time32Scalar,
pa.Time64Scalar,
pa.TimestampScalar,
pa.DurationScalar,
pa.StringScalar,
pa.BinaryScalar,
pa.FixedSizeBinaryScalar,
pa.BinaryViewScalar,
pa.StringViewScalar,
pa.ListScalar,
pa.LargeListScalar,
pa.ListViewScalar,
pa.LargeListViewScalar,
pa.MapScalar,
pa.FixedSizeListScalar,
pa.UnionScalar,
pa.StructScalar,
pa.DictionaryScalar,
pa.RunEndEncodedScalar,
pa.RecordBatchReader,
pa.ipc.Message,
pa.ipc.MessageReader,
pa.MemoryPool,
pa.LoggingMemoryPool,
pa.ProxyMemoryPool,
pa.Device,
pa.MemoryManager,
pa.OpaqueArray,
pa.OpaqueScalar,
pa.OpaqueType,
pa.Bool8Array,
pa.Bool8Scalar,
pa.Bool8Type,
pa.JsonArray,
pa.JsonScalar,
pa.JsonType,
])
def test_extension_type_constructor_errors(klass):
# ARROW-2638: prevent calling extension class constructors directly
msg = f"Do not call {klass.__name__}'s constructor directly, use .* instead."
with pytest.raises(TypeError, match=msg):
klass()