mirror of
https://github.com/apache/arrow.git
synced 2026-10-29 00:56:31 +08:00
Hyukjin Kwon
7151dcd6fa
### Rationale for this change
968e6ea488 added incorrect bitmask examples for `SQL_SUPPORTED_TRANSACTIONS_ISOLATION_LEVELS`.
https://github.com/apache/arrow/blob/968e6ea488c939c0e1f2bfe339a5a9ed1aed603e/format/FlightSql.proto#L588-L590
The bitmask incorrectly mapped bit 2 (value 4 = `\b100`) to `SQL_TRANSACTION_REPEATABLE_READ` instead of `SQL_TRANSACTION_READ_COMMITTED`, and omitted `SQL_TRANSACTION_READ_COMMITTED` entirely. According to the enum definition:
https://github.com/apache/arrow/blob/968e6ea488c939c0e1f2bfe339a5a9ed1aed603e/format/FlightSql.proto#L820-L826
The correct bit-to-enum mapping should be:
- Bit 0 (value 1) = `SQL_TRANSACTION_NONE` (enum value 0)
- Bit 1 (value 2) = `SQL_TRANSACTION_READ_UNCOMMITTED` (enum value 1)
- Bit 2 (value 4) = `SQL_TRANSACTION_READ_COMMITTED` (enum value 2)
- Bit 3 (value 8) = `SQL_TRANSACTION_REPEATABLE_READ` (enum value 3)
- Bit 4 (value 16) = `SQL_TRANSACTION_SERIALIZABLE` (enum value 4)
### What changes are included in this PR?
- Added `SQL_TRANSACTION_READ_COMMITTED` properly in the comments.
- `SQL positioned commands` (presumably copied and pasted from other places) -> `SQL transaction isolation levels` for `SQL_SUPPORTED_TRANSACTIONS_ISOLATION_LEVELS`
- `SQL positioned commands` (presumably copied and pasted from other places) -> `SQL UNIONs` for `SQL_SUPPORTED_UNIONS`
- ... and a lot of other similar typo fixes.
### Are these changes tested?
No, I did not test as they are comment-only.
### Are there any user-facing changes?
No, dev-only.
Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
53 lines
1.5 KiB
Plaintext
53 lines
1.5 KiB
Plaintext
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
include "Schema.fbs";
|
|
|
|
namespace org.apache.arrow.flatbuf;
|
|
|
|
/// ----------------------------------------------------------------------
|
|
/// Arrow File metadata
|
|
///
|
|
|
|
table Footer {
|
|
version: org.apache.arrow.flatbuf.MetadataVersion;
|
|
|
|
schema: org.apache.arrow.flatbuf.Schema;
|
|
|
|
dictionaries: [ Block ];
|
|
|
|
recordBatches: [ Block ];
|
|
|
|
/// User-defined metadata
|
|
custom_metadata: [ KeyValue ];
|
|
}
|
|
|
|
struct Block {
|
|
|
|
/// Index to the start of the RecordBatch (note this is past the Message header)
|
|
offset: long;
|
|
|
|
/// Length of the metadata
|
|
metaDataLength: int;
|
|
|
|
/// Length of the data (this is aligned so there can be a gap between this and
|
|
/// the metadata).
|
|
bodyLength: long;
|
|
}
|
|
|
|
root_type Footer;
|