mirror of
https://github.com/apache/arrow.git
synced 2026-10-28 16:47:19 +08:00
### Rationale for this change Reproducible builds are a requirement to be able to add automated signing. We would like to be able to do automated signing for our Linux packages too as discussed here: https://github.com/apache/arrow/issues/47058#issuecomment-3243601724 ### What changes are included in this PR? Some minor changes to our build to fix some Reproducible tests errors found. The main addition is adding a new step to our Linux Packaging GitHub actions workflow to run reprotest on the rake tasks to build the packages and compare the artifacts built. ### Are these changes tested? Yes on CI as part of the APT Packaging Linux jobs. ### Are there any user-facing changes? * GitHub Issue: #49988 Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com> Co-authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
43 lines
1.6 KiB
Diff
43 lines
1.6 KiB
Diff
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
From 252064718ccbeec5e4dee45d017036a84ab0c61c Mon Sep 17 00:00:00 2001
|
|
From: Sutou Kouhei <kou@clear-code.com>
|
|
Date: Sat, 31 Jan 2026 21:18:30 +0900
|
|
Subject: [PATCH] Don't embed compiler flags for reproducible builds
|
|
|
|
---
|
|
google/cloud/internal/build_info.cc.in | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/google/cloud/internal/build_info.cc.in b/google/cloud/internal/build_info.cc.in
|
|
index 3251870130..d120f580de 100644
|
|
--- a/google/cloud/internal/build_info.cc.in
|
|
+++ b/google/cloud/internal/build_info.cc.in
|
|
@@ -30,7 +30,7 @@ std::string compiler() {
|
|
// NOLINTNEXTLINE(readability-identifier-naming)
|
|
std::string compiler_flags() {
|
|
static char const kCompilerFlags[] =
|
|
- R"""(@CMAKE_CXX_FLAGS@ ${CMAKE_CXX_FLAGS_${GOOGLE_CLOUD_CPP_BUILD_TYPE_UPPER}})""";
|
|
+ R"""(REDACTED FOR REPRODUCIBLE BUILDS)""";
|
|
return kCompilerFlags;
|
|
}
|
|
|
|
--
|
|
2.51.0
|
|
|