mirror of
https://github.com/apache/arrow.git
synced 2026-10-29 00:56:31 +08:00
Sutou Kouhei
93b63e8f3b
ARROW-9171 and ARROW-17231 are also fixed.
Our CMake packages are broken. For example, `find_package(Parquet)`
doesn't work without specifying `CMAKE_MODULE_PATH`.
`find_package(${PACKAGE})` searches
`${PREFIX}/${PACKAGE}/${PACKAGE}Config.cmake` or
`${PREFIX}/${PACKAGE}/Find${PACKAGE}.cmake`. But our .cmake files are
always installed `${PREFIX}/arrow/`. So `find_package(Parquet)` can't find
`${PREFIX}/arrow/FindParquet.cmake` because "`/arrow/`" isn't
"`/${PACKAGE}`".
This change fixes this by installing `${PACKAGE}Config.cmake` to
`${PREFIX}/${PACKAGE}/` instead of `${PREFIX}/arrow/`.
This also removes all `Find${PACKAGE}.cmake`. We only provides
`${PACKAGE}Config.cmake`. Our `Find${PACKAGE}.cmake` can find `${PACKAGE}`
by CMake, pkg-config or manual .so/.h search. But we don't need to
support pkg-config nor manual .so/.h search. We can use
`${PACKAGE}Config.cmake` to support CMake package search. So this
removes all `Find${PACKAGE}.cmake`.
This also introduces namespace to our CMake targets. For example,
`arrow_shared` is exported as `Arrow::arrow_shared` and
`parquet_static` is exported as `Parquet::parquet_static`. But no
namespace targets such as `arrow_shared` and `parquet_static` are
still also exported for keeping backward compatibility. But this
requires CMake 3.18 or later for users because `add_library(ALIAS)`
for non-global `IMPORTED` library is available since CMake 3.18.
(`Plasma::plasma-store-server` target is also added for
`plasma-store-server` executable.)
FYI: We can resolve this problem by using `COMPONENTS` feature of
`find_package()`. For example, `find_package(Arrow COMPONENTS
Parquet)` is used instead of `find_package(Parquet)`. With
`COMPONENTS`, `${PACKAGE}` is always "Arrow". So we can still install
our .cmake files to `${PREFIX}/arrow/`. But this approach breaks
backward compatibility. So I choose `${PREFIX}/${PACKAGE}/*.cmake`
approach.
Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
64 lines
2.1 KiB
CMake
64 lines
2.1 KiB
CMake
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
if(gflagsAlt_FOUND)
|
|
return()
|
|
endif()
|
|
|
|
set(find_package_args)
|
|
if(gflagsAlt_FIND_VERSION)
|
|
list(APPEND find_package_args ${gflagsAlt_FIND_VERSION})
|
|
endif()
|
|
if(gflagsAlt_FIND_QUIETLY)
|
|
list(APPEND find_package_args QUIET)
|
|
endif()
|
|
find_package(gflags ${find_package_args})
|
|
if(gflags_FOUND)
|
|
set(gflagsAlt_FOUND TRUE)
|
|
return()
|
|
endif()
|
|
|
|
# TODO: Support version detection.
|
|
|
|
if(gflags_ROOT)
|
|
find_library(gflags_LIB
|
|
NAMES gflags
|
|
PATHS ${gflags_ROOT}
|
|
PATH_SUFFIXES ${ARROW_LIBRARY_PATH_SUFFIXES}
|
|
NO_DEFAULT_PATH)
|
|
find_path(GFLAGS_INCLUDE_DIR
|
|
NAMES gflags/gflags.h
|
|
PATHS ${gflags_ROOT}
|
|
NO_DEFAULT_PATH
|
|
PATH_SUFFIXES ${ARROW_INCLUDE_PATH_SUFFIXES})
|
|
else()
|
|
find_library(gflags_LIB NAMES gflags)
|
|
find_path(GFLAGS_INCLUDE_DIR
|
|
NAMES gflags/gflags.h
|
|
PATH_SUFFIXES ${ARROW_INCLUDE_PATH_SUFFIXES})
|
|
endif()
|
|
|
|
find_package_handle_standard_args(gflagsAlt REQUIRED_VARS gflags_LIB GFLAGS_INCLUDE_DIR)
|
|
|
|
if(gflagsAlt_FOUND)
|
|
add_library(gflags::gflags UNKNOWN IMPORTED)
|
|
set_target_properties(gflags::gflags
|
|
PROPERTIES IMPORTED_LOCATION "${gflags_LIB}"
|
|
INTERFACE_INCLUDE_DIRECTORIES "${GFLAGS_INCLUDE_DIR}")
|
|
set(GFLAGS_LIBRARIES gflags::gflags)
|
|
endif()
|