mirror of
https://github.com/apache/arrow.git
synced 2026-10-28 16:47:19 +08:00
Hiroyuki Sato
397b3d0023
### Rationale for this change This is the sub issue #44748. * SC2046: Quote this to prevent word splitting. * SC2128: Expanding an array without an index only gives the element in the index 0. * SC2086: Double quote to prevent globbing and word splitting. ``` In generate_corpuses.sh line 32: ARROW_ROOT=$(cd $(dirname "$BASH_SOURCE")/../../..; pwd) ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting. ^----------^ SC2128 (warning): Expanding an array without an index only gives the first element. In generate_corpuses.sh line 43: ${OUT}/arrow-ipc-generate-fuzz-corpus -stream ${CORPUS_DIR} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${OUT}"/arrow-ipc-generate-fuzz-corpus -stream ${CORPUS_DIR} In generate_corpuses.sh line 45: IPC_INTEGRATION_FILES=$(find ${ARROW_ROOT}/testing/data/arrow-ipc-stream/integration -name "*.stream") ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: IPC_INTEGRATION_FILES=$(find "${ARROW_ROOT}"/testing/data/arrow-ipc-stream/integration -name "*.stream") In generate_corpuses.sh line 49: cp --backup=numbered ${IPC_INTEGRATION_FILES} ${CORPUS_DIR} ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cp --backup=numbered "${IPC_INTEGRATION_FILES}" ${CORPUS_DIR} In generate_corpuses.sh line 50: ${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/arrow-ipc-stream-fuzz_seed_corpus.zip ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${ARROW_CPP}"/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} "${OUT}"/arrow-ipc-stream-fuzz_seed_corpus.zip In generate_corpuses.sh line 53: ${OUT}/arrow-ipc-generate-fuzz-corpus -file ${CORPUS_DIR} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${OUT}"/arrow-ipc-generate-fuzz-corpus -file ${CORPUS_DIR} In generate_corpuses.sh line 54: IPC_INTEGRATION_FILES=$(find ${ARROW_ROOT}/testing/data/arrow-ipc-stream/integration -name "*.arrow_file") ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: IPC_INTEGRATION_FILES=$(find "${ARROW_ROOT}"/testing/data/arrow-ipc-stream/integration -name "*.arrow_file") In generate_corpuses.sh line 56: cp --backup=numbered ${IPC_INTEGRATION_FILES} ${CORPUS_DIR} ^----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cp --backup=numbered "${IPC_INTEGRATION_FILES}" ${CORPUS_DIR} In generate_corpuses.sh line 57: ${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/arrow-ipc-file-fuzz_seed_corpus.zip ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${ARROW_CPP}"/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} "${OUT}"/arrow-ipc-file-fuzz_seed_corpus.zip In generate_corpuses.sh line 60: ${OUT}/arrow-ipc-generate-tensor-fuzz-corpus -stream ${CORPUS_DIR} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${OUT}"/arrow-ipc-generate-tensor-fuzz-corpus -stream ${CORPUS_DIR} In generate_corpuses.sh line 61: ${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/arrow-ipc-tensor-stream-fuzz_seed_corpus.zip ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${ARROW_CPP}"/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} "${OUT}"/arrow-ipc-tensor-stream-fuzz_seed_corpus.zip In generate_corpuses.sh line 66: ${OUT}/parquet-arrow-generate-fuzz-corpus ${CORPUS_DIR} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${OUT}"/parquet-arrow-generate-fuzz-corpus ${CORPUS_DIR} In generate_corpuses.sh line 68: cp ${ARROW_CPP}/submodules/parquet-testing/data/*.parquet ${CORPUS_DIR} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cp "${ARROW_CPP}"/submodules/parquet-testing/data/*.parquet ${CORPUS_DIR} In generate_corpuses.sh line 69: cp ${ARROW_CPP}/submodules/parquet-testing/bad_data/*.parquet ${CORPUS_DIR} ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cp "${ARROW_CPP}"/submodules/parquet-testing/bad_data/*.parquet ${CORPUS_DIR} In generate_corpuses.sh line 70: ${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/parquet-arrow-fuzz_seed_corpus.zip ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${ARROW_CPP}"/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} "${OUT}"/parquet-arrow-fuzz_seed_corpus.zip In generate_corpuses.sh line 75: ${OUT}/parquet-generate-encoding-fuzz-corpus ${CORPUS_DIR} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${OUT}"/parquet-generate-encoding-fuzz-corpus ${CORPUS_DIR} In generate_corpuses.sh line 76: ${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/parquet-encoding-fuzz_seed_corpus.zip ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${ARROW_CPP}"/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} "${OUT}"/parquet-encoding-fuzz_seed_corpus.zip In generate_corpuses.sh line 84: ${OUT}/arrow-csv-generate-fuzz-corpus ${CORPUS_DIR} ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${OUT}"/arrow-csv-generate-fuzz-corpus ${CORPUS_DIR} In generate_corpuses.sh line 86: cp ${ARROW_ROOT}/testing/data/csv/*.csv ${CORPUS_DIR} ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: cp "${ARROW_ROOT}"/testing/data/csv/*.csv ${CORPUS_DIR} In generate_corpuses.sh line 89: ${ARROW_CPP}/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} ${OUT}/arrow-csv-fuzz_seed_corpus.zip ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting. Did you mean: "${ARROW_CPP}"/build-support/fuzzing/pack_corpus.py ${CORPUS_DIR} "${OUT}"/arrow-csv-fuzz_seed_corpus.zip For more information: https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2128 -- Expanding an array without an ind... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ... ``` ### What changes are included in this PR? * SC2046: Quote command substitutions to prevent word splitting. * SC2128: Specify an array index explicitly. * SC2086: Quote variables to prevent globbing and word splitting. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #51090 Authored-by: Hiroyuki Sato <hiroysato@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>