5 Commits
Author SHA1 Message Date
Raúl CumplidoandSutou Kouhei d6d9493dd0 GH-51494: [CI][C++] Detect Visual Studio installed path instead of hardcoding it (#51610)
### Rationale for this change

The Windows ARM job was failing on CMake configure. The real problem is that the Windows-11-arm64 GitHub runner updated VS Code from 2022 to 2026 here: https://github.com/actions/runner-images/issues/14592

The workflow was hardcoding `vcvarsall.bat` path and wasn't really setting those up.

### What changes are included in this PR?

Use vswhere to find VSCode installation path instead of manually setting it up.
I investigating using: https://github.com/ilammy/msvc-dev-cmd which is allowed by infra and used on nanoarrow and adbc but it feels unmaintained at the moment (No new releases in 3 years).

This has been changed everywhere where we were manually setting this path.

### Are these changes tested?

Yes via CI

### Are there any user-facing changes?

No

### Was AI used for this PR?

In accordance to the [AI generation guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code), please disclose below whether and how AI was used in this PR.

**PR code and description written by:**

- [x] Human
- [x] AI

AI used to analyze and first implementation.
Re-implemented on a second bash step from me as it's much cleaner and clearer.

**Reviewed before submission by:**

- [x] Human
- [ ] AI
- [ ] Not reviewed

* GitHub Issue: #51494

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2026-09-29 21:00:34 +09:00
Raúl Cumplido 98a92c2f5d GH-47583: [CI][Python] Enable PyArrow RelWithDebInfo build with assertions on Windows CI job (#50406)
### Rationale for this change

Running a PyArrow Windows build with Assertions enhances our coverage, keeping debug information can helps us on future investigations.

### What changes are included in this PR?

Run Windows CI job PyArrow build with RelWithDebInfo but remove `NDEBUG` so assertions are exercised.
We can't use DEBUG directly because otherwise we require linking with CPython debug build (Py_Debug).

### Are these changes tested?

Yes on CI, I've validated the flags for building are correct.

### Are there any user-facing changes?

No, this is only for our CI job.

* GitHub Issue: #47583

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
2026-07-09 14:47:48 +02:00
f1b21f1945 GH-36411: [Python] Use scikit-build-core as build backend for PyArrow and get rid of setup.py (#49259)
### Rationale for this change

Move our PyArrow build backend from setuptools and a custom setup.py to scikit-build-core which is just build backend for CMake related projects.

### What changes are included in this PR?

Move from setuptools to scikit-build-core and remove PyArrow setup.py. Update some of the build requirements and minor fixes.
A custom build backend has been also been created in order to wrap scikit-build-core in order to fix problems on License files for monorepos.
pyproject.toml metadata validation expects license files to exist before exercising the build backend that's why we create symlinks. Our thin build backend will just make those symlinks hard-links in order for license and notice files to contain the contents and be added as part of the sdist.

Remove flags that are not used anymore (were only part of setup.py) and documented and validated how the same flags have to be used now.

### Are these changes tested?

Yes all Python CI tests, wheels and sdist are successful.

### Are there any user-facing changes?

Yes, users building PyArrow will now require the new build dependencies to exercise the build and depending on the flags used they might require to use the new documented way of using those flags.

* GitHub Issue: #36411

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Rok Mihevc <rok@mihevc.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
2026-03-09 09:47:21 +01:00
Nate Prewitt 2b9ed291ac MINOR: [CI] Update Python CI to use Azure in Windows tests (#49240)
### Rationale for this change
This PR is a follow up to #49170 at the request of @ raulcd. This enables Azure in the Python Windows build CI.

### What changes are included in this PR?

This change adds `ARROW_AZURE=ON` in the python_build.bat script and propagates it to cmake and pyarrow.

### Are these changes tested?
This is should enable full test runs for PyArrow in `python_test.bat`.

### Are there any user-facing changes?
No, this should be purely a CI update for testing.

Authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
2026-02-12 14:21:23 +09:00
Raúl CumplidoandSutou Kouhei e1c6fd5304 GH-42137 [CI][Python] Add Python Windows GitHub Action and remove AppVeyor (#47567)
### Rationale for this change

There is currently a single CI job on AppVeyor. This is the only job on Windows for Python and it usually fails due to CI issues rather than Python real issues. We have more experience with GitHub actions and debugging AppVeyor is usually challenging.

### What changes are included in this PR?

Create a Python Windows job that runs on GitHub actions. The job builds Arrow CPP and PyArrow and it tests PyArrow.

Also removes the CI related files for AppVeyor

### Are these changes tested?

Yes, via CI.

### Are there any user-facing changes?

No

* GitHub Issue: #42137

Lead-authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
2025-09-17 09:48:52 +00:00