This commit is contained in:
François Saint-Jacques committed 2019-05-27 15:40:42 -04:00
1 parent 8334c68f7f
commit d8e779aabe
9 files changed
+23 -40

No files matched your search

+1 -2
View File
@@ -140,8 +140,7 @@ static void BuildBooleanArrayNoNulls(
state.SetBytesProcessed(state.iterations() * kBytesProcessed);
}
static void BuildBinaryArray(
benchmark::State& state) { // NOLINT non-const reference
static void BuildBinaryArray(benchmark::State& state) { // NOLINT non-const reference
for (auto _ : state) {
BinaryBuilder builder;
+2 -3
View File
@@ -203,9 +203,8 @@ BENCHMARK(BuildStringDictionary);
constexpr int kHashBenchmarkLength = 1 << 22;
#define ADD_HASH_ARGS(WHAT) \
WHAT->Args({kHashBenchmarkLength, 1 << 10}) \
->Args({kHashBenchmarkLength, 10 * 1 << 10}) \
#define ADD_HASH_ARGS(WHAT) \
WHAT->Args({kHashBenchmarkLength, 1 << 10})->Args({kHashBenchmarkLength, 10 * 1 << 10})
ADD_HASH_ARGS(BENCHMARK(UniqueInt64NoNulls));
ADD_HASH_ARGS(BENCHMARK(UniqueInt64WithNulls));
+2 -4
View File
@@ -76,16 +76,14 @@ static void BenchmarkConversion(benchmark::State& state, // NOLINT non-const re
constexpr size_t num_rows = 10000;
static void Int64Conversion(
benchmark::State& state) { // NOLINT non-const reference
static void Int64Conversion(benchmark::State& state) { // NOLINT non-const reference
auto parser = BuildInt64Data(num_rows);
auto options = ConvertOptions::Defaults();
BenchmarkConversion(state, *parser, int64(), options);
}
static void FloatConversion(
benchmark::State& state) { // NOLINT non-const reference
static void FloatConversion(benchmark::State& state) { // NOLINT non-const reference
auto parser = BuildFloatData(num_rows);
auto options = ConvertOptions::Defaults();
+4 -8
View File
@@ -56,8 +56,7 @@ static void BenchmarkCSVChunking(benchmark::State& state, // NOLINT non-const r
state.SetBytesProcessed(state.iterations() * csv_size);
}
static void ChunkCSVQuotedBlock(
benchmark::State& state) { // NOLINT non-const reference
static void ChunkCSVQuotedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = true;
@@ -67,8 +66,7 @@ static void ChunkCSVQuotedBlock(
BenchmarkCSVChunking(state, csv, options);
}
static void ChunkCSVEscapedBlock(
benchmark::State& state) { // NOLINT non-const reference
static void ChunkCSVEscapedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row_escaped, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = false;
@@ -121,8 +119,7 @@ static void BenchmarkCSVParsing(benchmark::State& state, // NOLINT non-const re
state.SetBytesProcessed(state.iterations() * csv_size);
}
static void ParseCSVQuotedBlock(
benchmark::State& state) { // NOLINT non-const reference
static void ParseCSVQuotedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = true;
@@ -131,8 +128,7 @@ static void ParseCSVQuotedBlock(
BenchmarkCSVParsing(state, csv, num_rows, options);
}
static void ParseCSVEscapedBlock(
benchmark::State& state) { // NOLINT non-const reference
static void ParseCSVEscapedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row_escaped, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = false;
+1 -4
View File
@@ -82,10 +82,7 @@ static void Writer_Unbuffered(benchmark::State& state) {
}
// Vary chunk write size from 256 bytes to 64K
BENCHMARK(Writer_Buffered)
->RangeMultiplier(16)
->Range(1 << 8, 1 << 16)
->UseRealTime();
BENCHMARK(Writer_Buffered)->RangeMultiplier(16)->Range(1 << 8, 1 << 16)->UseRealTime();
BENCHMARK(Writer_Unbuffered)
->RangeMultiplier(4)
+5 -6
View File
@@ -111,9 +111,9 @@ int64_t StreamingCompress(Codec* codec, const std::vector<uint8_t>& data,
return compressed_size;
}
static void StreamingCompression(
Compression::type compression, const std::vector<uint8_t>& data,
benchmark::State& state) { // NOLINT non-const reference
static void StreamingCompression(Compression::type compression,
const std::vector<uint8_t>& data,
benchmark::State& state) { // NOLINT non-const reference
std::unique_ptr<Codec> codec;
ABORT_NOT_OK(Codec::Create(compression, &codec));
@@ -126,9 +126,8 @@ static void StreamingCompression(
}
template <Compression::type COMPRESSION>
static void StreamingCompression(
benchmark::State& state) { // NOLINT non-const reference
auto data = MakeCompressibleData(8 * 1024 * 1024); // 8 MB
static void StreamingCompression(benchmark::State& state) { // NOLINT non-const reference
auto data = MakeCompressibleData(8 * 1024 * 1024); // 8 MB
StreamingCompression(COMPRESSION, data, state);
}
+2 -4
View File
@@ -60,8 +60,7 @@ static void DetectUIntWidthNoNulls(
state.SetBytesProcessed(state.iterations() * values.size() * sizeof(uint64_t));
}
static void DetectUIntWidthNulls(
benchmark::State& state) { // NOLINT non-const reference
static void DetectUIntWidthNulls(benchmark::State& state) { // NOLINT non-const reference
const auto values = GetUIntSequence(0x12345);
const auto valid_bytes = GetValidBytes(0x12345);
@@ -84,8 +83,7 @@ static void DetectIntWidthNoNulls(
state.SetBytesProcessed(state.iterations() * values.size() * sizeof(uint64_t));
}
static void DetectIntWidthNulls(
benchmark::State& state) { // NOLINT non-const reference
static void DetectIntWidthNulls(benchmark::State& state) { // NOLINT non-const reference
const auto values = GetIntSequence(0x12345, -0x1234);
const auto valid_bytes = GetValidBytes(0x12345);
+1 -2
View File
@@ -195,8 +195,7 @@ static void TrieLookupFound(benchmark::State& state) { // NOLINT non-const refe
BenchmarkTrieLookups(state, {"N/A", "null", "-1.#IND", "N/A"});
}
static void TrieLookupNotFound(
benchmark::State& state) { // NOLINT non-const reference
static void TrieLookupNotFound(benchmark::State& state) { // NOLINT non-const reference
BenchmarkTrieLookups(state, {"None", "1.0", "", "abc"});
}
+5 -7
View File
@@ -74,14 +74,13 @@ static void ValidateTinyAscii(benchmark::State& state) { // NOLINT non-const re
BenchmarkUTF8Validation(state, tiny_valid_ascii, true);
}
static void ValidateTinyNonAscii(
benchmark::State& state) { // NOLINT non-const reference
static void ValidateTinyNonAscii(benchmark::State& state) { // NOLINT non-const reference
BenchmarkUTF8Validation(state, tiny_valid_non_ascii, true);
}
static void ValidateSmallAscii(
benchmark::State& state) { // NOLINT non-const reference
BenchmarkUTF8Validation(state, valid_ascii, true); }
static void ValidateSmallAscii(benchmark::State& state) { // NOLINT non-const reference
BenchmarkUTF8Validation(state, valid_ascii, true);
}
static void ValidateSmallAlmostAscii(
benchmark::State& state) { // NOLINT non-const reference
@@ -93,8 +92,7 @@ static void ValidateSmallNonAscii(
BenchmarkUTF8Validation(state, valid_non_ascii, true);
}
static void ValidateLargeAscii(
benchmark::State& state) { // NOLINT non-const reference
static void ValidateLargeAscii(benchmark::State& state) { // NOLINT non-const reference
auto s = MakeLargeString(valid_ascii, 100000);
BenchmarkUTF8Validation(state, s, true);
}