Incorportate review comments

This commit is contained in:
Uwe L. Korn committed 2016-06-03 22:29:36 +02:00
1 parent 0fbed3f2c5
commit be6415c393
2 files changed
+3 -5

No files matched your search

+3 -4
View File
@@ -109,16 +109,15 @@ Status FileReader::Impl::ReadFlatColumn(int i, std::shared_ptr<Array>* out) {
}
Status FileReader::Impl::ReadFlatTable(std::shared_ptr<Table>* table) {
const std::string name = reader_->descr()->schema()->name();
const std::string& name = reader_->descr()->schema()->name();
std::shared_ptr<Schema> schema;
RETURN_NOT_OK(FromParquetSchema(reader_->descr(), &schema));
std::vector<std::shared_ptr<Column>> columns;
std::vector<std::shared_ptr<Column>> columns(reader_->num_columns());
for (int i = 0; i < reader_->num_columns(); i++) {
std::shared_ptr<Array> array;
RETURN_NOT_OK(ReadFlatColumn(i, &array));
auto column = std::make_shared<Column>(schema->field(i), array);
columns.push_back(column);
columns[i] = std::make_shared<Column>(schema->field(i), array);
}
*table = std::make_shared<Table>(name, schema, columns);
-1
View File
@@ -35,7 +35,6 @@ class TestParquetIO(unittest.TestCase):
def tearDown(self):
rmtree(self.temp_directory)
def test_single_int64_column(self):
filename = os.path.join(self.temp_directory, 'single_int64_column.parquet')
data = [A.from_pylist(range(5))]