mirror of
https://github.com/apache/arrow.git
synced 2026-10-28 16:47:19 +08:00
Incorportate review comments
This commit is contained in:
1 parent
0fbed3f2c5
commit
be6415c393
2 files changed
+3
-5
No files matched your search
@@ -109,16 +109,15 @@ Status FileReader::Impl::ReadFlatColumn(int i, std::shared_ptr<Array>* out) {
|
||||
}
|
||||
|
||||
Status FileReader::Impl::ReadFlatTable(std::shared_ptr<Table>* table) {
|
||||
const std::string name = reader_->descr()->schema()->name();
|
||||
const std::string& name = reader_->descr()->schema()->name();
|
||||
std::shared_ptr<Schema> schema;
|
||||
RETURN_NOT_OK(FromParquetSchema(reader_->descr(), &schema));
|
||||
|
||||
std::vector<std::shared_ptr<Column>> columns;
|
||||
std::vector<std::shared_ptr<Column>> columns(reader_->num_columns());
|
||||
for (int i = 0; i < reader_->num_columns(); i++) {
|
||||
std::shared_ptr<Array> array;
|
||||
RETURN_NOT_OK(ReadFlatColumn(i, &array));
|
||||
auto column = std::make_shared<Column>(schema->field(i), array);
|
||||
columns.push_back(column);
|
||||
columns[i] = std::make_shared<Column>(schema->field(i), array);
|
||||
}
|
||||
|
||||
*table = std::make_shared<Table>(name, schema, columns);
|
||||
|
||||
@@ -35,7 +35,6 @@ class TestParquetIO(unittest.TestCase):
|
||||
def tearDown(self):
|
||||
rmtree(self.temp_directory)
|
||||
|
||||
|
||||
def test_single_int64_column(self):
|
||||
filename = os.path.join(self.temp_directory, 'single_int64_column.parquet')
|
||||
data = [A.from_pylist(range(5))]
|
||||
|
||||
Reference in new issue
Block a user