Replace ARROW_EXPORT with ARROW_FLIGHT_EXPORT

cpp/src/arrow/flight/client.h

@@ -68,24 +68,35 @@ class ARROW_FLIGHT_EXPORT FlightClientOptions {
 
 /// \brief A RecordBatchReader exposing Flight metadata and cancel
 /// operations.
-class ARROW_EXPORT FlightStreamReader : public MetadataRecordBatchReader {
+class ARROW_FLIGHT_EXPORT FlightStreamReader : public MetadataRecordBatchReader {
  public:
   /// \brief Try to cancel the call.
   virtual void Cancel() = 0;
 };
 
+// Silence warning
+// "non dll-interface class RecordBatchReader used as base for dll-interface class"
+#ifdef _MSC_VER
+#pragma warning(push)
+#pragma warning(disable : 4275)
+#endif
+
 /// \brief A RecordBatchWriter that also allows sending
 /// application-defined metadata via the Flight protocol.
-class ARROW_EXPORT FlightStreamWriter : public ipc::RecordBatchWriter {
+class ARROW_FLIGHT_EXPORT FlightStreamWriter : public ipc::RecordBatchWriter {
  public:
   virtual Status WriteWithMetadata(const RecordBatch& batch,
                                    std::shared_ptr<Buffer> app_metadata,
                                    bool allow_64bit = false) = 0;
 };
 
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
+
 /// \brief A reader for application-specific metadata sent back to the
 /// client during an upload.
-class ARROW_EXPORT FlightMetadataReader {
+class ARROW_FLIGHT_EXPORT FlightMetadataReader {
  public:
   virtual ~FlightMetadataReader();
   /// \brief Read a message from the server.

cpp/src/arrow/flight/server.h

@@ -74,13 +74,6 @@ class ARROW_FLIGHT_EXPORT RecordBatchStream : public FlightDataStream {
   std::unique_ptr<RecordBatchStreamImpl> impl_;
 };
 
-// Silence warning
-// "non dll-interface class RecordBatchReader used as base for dll-interface class"
-#ifdef _MSC_VER
-#pragma warning(push)
-#pragma warning(disable : 4275)
-#endif
-
 /// \brief A reader for IPC payloads uploaded by a client. Also allows
 /// reading application-defined metadata via the Flight protocol.
 class ARROW_FLIGHT_EXPORT FlightMessageReader : public MetadataRecordBatchReader {
@@ -89,10 +82,6 @@ class ARROW_FLIGHT_EXPORT FlightMessageReader : public MetadataRecordBatchReader
   virtual const FlightDescriptor& descriptor() const = 0;
 };
 
-#ifdef _MSC_VER
-#pragma warning(pop)
-#endif
-
 /// \brief A writer for application-specific metadata sent back to the
 /// client during an upload.
 class ARROW_FLIGHT_EXPORT FlightMetadataWriter {

cpp/src/arrow/flight/test-util.h

@@ -132,7 +132,7 @@ class ARROW_FLIGHT_EXPORT BatchIterator : public RecordBatchReader {
 // A FlightDataStream that numbers the record batches
 /// \brief A basic implementation of FlightDataStream that will provide
 /// a sequence of FlightData messages to be written to a gRPC stream
-class ARROW_EXPORT NumberingStream : public FlightDataStream {
+class ARROW_FLIGHT_EXPORT NumberingStream : public FlightDataStream {
  public:
   explicit NumberingStream(std::unique_ptr<FlightDataStream> stream);
 

cpp/src/arrow/flight/types.h

@@ -280,9 +280,16 @@ class ARROW_FLIGHT_EXPORT ResultStream {
   virtual Status Next(std::unique_ptr<Result>* info) = 0;
 };
 
+// Silence warning
+// "non dll-interface class RecordBatchReader used as base for dll-interface class"
+#ifdef _MSC_VER
+#pragma warning(push)
+#pragma warning(disable : 4275)
+#endif
+
 /// \brief A RecordBatchReader that also exposes application-defined
 /// metadata from the Flight protocol.
-class ARROW_EXPORT MetadataRecordBatchReader : public RecordBatchReader {
+class ARROW_FLIGHT_EXPORT MetadataRecordBatchReader : public RecordBatchReader {
  public:
   virtual ~MetadataRecordBatchReader() = default;
 
@@ -290,6 +297,10 @@ class ARROW_EXPORT MetadataRecordBatchReader : public RecordBatchReader {
                                   std::shared_ptr<Buffer>* app_metadata) = 0;
 };
 
+#ifdef _MSC_VER
+#pragma warning(pop)
+#endif
+
 // \brief Create a FlightListing from a vector of FlightInfo objects. This can
 // be iterated once, then it is consumed
 class ARROW_FLIGHT_EXPORT SimpleFlightListing : public FlightListing {