mirrors/arrow
0
0 Fork 0
mirror of https://github.com/apache/arrow.git synced 2026-10-29 17:15:39 +08:00
Code Activity

Address comments

Browse Source
This commit is contained in:
François Saint-Jacques committed 2019-05-30 08:30:45 -04:00
1 parent 4a570ab90f
commit 83780304d6
2 files changed
+28 -23
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

cpp/src/arrow/builder-benchmark.cc
+19 -15
View File
@@ -55,21 +55,6 @@ constexpr int64_t kBytesProcessed = kRounds * kBytesProcessPerRound;
static const char* kBinaryString = "12345678";
static arrow::util::string_view kBinaryView(kBinaryString);
// This benchmarks acts as a reference to the native std::vector
// implementation. It appends kRounds chunks into a vector.
static void ReferenceBuildVectorNoNulls(
benchmark::State& state) { // NOLINT non-const reference
for (auto _ : state) {
std::vector<int64_t> builder;
for (int i = 0; i < kRounds; i++) {
builder.insert(builder.end(), kData.cbegin(), kData.cend());
}
}
state.SetBytesProcessed(state.iterations() * kBytesProcessed);
}
static void BuildIntArrayNoNulls(benchmark::State& state) { // NOLINT non-const reference
for (auto _ : state) {
Int64Builder builder;
@@ -366,8 +351,27 @@ static void ArrayDataConstructDestruct(
// Benchmark declarations
//
#ifdef ARROW_WITH_BENCHMARKS_REFERENCE
// This benchmarks acts as a reference to the native std::vector
// implementation. It appends kRounds chunks into a vector.
static void ReferenceBuildVectorNoNulls(
benchmark::State& state) { // NOLINT non-const reference
for (auto _ : state) {
std::vector<int64_t> builder;
for (int i = 0; i < kRounds; i++) {
builder.insert(builder.end(), kData.cbegin(), kData.cend());
}
}
state.SetBytesProcessed(state.iterations() * kBytesProcessed);
}
BENCHMARK(ReferenceBuildVectorNoNulls);
#endif
BENCHMARK(BuildBooleanArrayNoNulls);
BENCHMARK(BuildIntArrayNoNulls);
cpp/src/arrow/csv/parser-benchmark.cc
+9 -8
View File
@@ -28,13 +28,14 @@
namespace arrow {
namespace csv {
// Can't have static str.
// Linter stipulates:
// >> For a static/global string constant, use a C style string instead
const char* one_row = "abc,\"d,f\",12.34,\n";
const char* one_row_escaped = "abc,d\\,f,12.34,\n";
size_t num_rows = (1024 * 8) / strlen(one_row);
size_t num_rows = (1024 * 64) / strlen(one_row);
static std::string BuildCsvData(const std::string& row, size_t repeat) {
static std::string BuildCSVData(const std::string& row, size_t repeat) {
std::stringstream ss;
for (size_t i = 0; i < repeat; ++i) {
ss << row;
@@ -57,7 +58,7 @@ static void BenchmarkCSVChunking(benchmark::State& state, // NOLINT non-const r
}
static void ChunkCSVQuotedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row, num_rows);
auto csv = BuildCSVData(one_row, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = true;
options.escaping = false;
@@ -67,7 +68,7 @@ static void ChunkCSVQuotedBlock(benchmark::State& state) { // NOLINT non-const
}
static void ChunkCSVEscapedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row_escaped, num_rows);
auto csv = BuildCSVData(one_row_escaped, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = false;
options.escaping = true;
@@ -78,7 +79,7 @@ static void ChunkCSVEscapedBlock(benchmark::State& state) { // NOLINT non-const
static void ChunkCSVNoNewlinesBlock(
benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row_escaped, num_rows);
auto csv = BuildCSVData(one_row_escaped, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = true;
options.escaping = false;
@@ -120,7 +121,7 @@ static void BenchmarkCSVParsing(benchmark::State& state, // NOLINT non-const re
}
static void ParseCSVQuotedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row, num_rows);
auto csv = BuildCSVData(one_row, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = true;
options.escaping = false;
@@ -129,7 +130,7 @@ static void ParseCSVQuotedBlock(benchmark::State& state) { // NOLINT non-const
}
static void ParseCSVEscapedBlock(benchmark::State& state) { // NOLINT non-const reference
auto csv = BuildCsvData(one_row_escaped, num_rows);
auto csv = BuildCSVData(one_row_escaped, num_rows);
auto options = ParseOptions::Defaults();
options.quoting = false;
options.escaping = true;