This commit is contained in:
Micah Kornfield authored and Antoine Pitrou committed 2019-07-02 17:58:29 +02:00
1 parent 85786efb12
commit 74d563cd73
4 files changed
+6 -4

No files matched your search

+2 -1
View File
@@ -160,7 +160,8 @@ bool IsPythonError(const Status& status) {
return false;
}
auto detail = status.detail();
return detail != nullptr && detail->type_id() == kErrorDetailTypeId;
bool result = detail != nullptr && detail->type_id() == kErrorDetailTypeId;
return result;
}
} // namespace py
-2
View File
@@ -31,7 +31,6 @@ Status::Status(StatusCode code, std::string msg, std::shared_ptr<StatusDetail> d
state_->code = code;
state_->msg = std::move(msg);
if (detail != nullptr) {
std::cerr << "!!!!!!non null detail" << detail;
state_->detail = std::move(detail);
}
}
@@ -42,7 +41,6 @@ void Status::CopyFrom(const Status& s) {
state_ = nullptr;
} else {
state_ = new State(*s.state_);
std::cerr << "!!!!copy_from " << state_->detail;
}
}
+3
View File
@@ -51,6 +51,9 @@ class PlasmaStatusDetail : public arrow::StatusDetail {
case PlasmaErrorCode::PlasmaObjectAlreadySealed:
type = "Plasma object is already sealed";
break;
default:
type = "Unknown plasma error";
break;
}
return std::string(type);
}
+1 -1
View File
@@ -1207,7 +1207,7 @@ cdef extern from "arrow/python/api.h" namespace "arrow::py" nogil:
shared_ptr[CDataType] GetPrimitiveType(Type type)
shared_ptr[CDataType] GetTimestampType(TimeUnit unit)
cdef c_bool IsPythonError(const CStatus& status)
c_bool IsPythonError(const CStatus& status)
object PyHalf_FromHalf(npy_half value)
cdef cppclass PyConversionOptions: