Restore all C++ files prior to IWYU edits so we can deal with issues in some other PR

Change-Id: I7eb1ee7357d1331dd08dcf9fc8882bb649799906

cpp/src/arrow/array.cc

@@ -21,6 +21,7 @@
 #include <cstdint>
 #include <cstring>
 #include <limits>
+#include <set>
 #include <sstream>
 #include <utility>
 
@@ -28,7 +29,6 @@
 #include "arrow/compare.h"
 #include "arrow/pretty_print.h"
 #include "arrow/status.h"
-#include "arrow/type_fwd.h"
 #include "arrow/type_traits.h"
 #include "arrow/util/bit-util.h"
 #include "arrow/util/checked_cast.h"

cpp/src/arrow/array.h

@@ -18,21 +18,22 @@
 #ifndef ARROW_ARRAY_H
 #define ARROW_ARRAY_H
 
+#include <cmath>
 #include <cstdint>
-#include <iosfwd>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <utility>
 #include <vector>
 
 #include "arrow/buffer.h"
 #include "arrow/type.h"
+#include "arrow/type_fwd.h"
 #include "arrow/type_traits.h"
 #include "arrow/util/bit-util.h"
 #include "arrow/util/checked_cast.h"
 #include "arrow/util/macros.h"
 #include "arrow/util/visibility.h"
+#include "arrow/visitor.h"
 
 namespace arrow {
 
@@ -44,10 +45,12 @@ using BufferVector = std::vector<std::shared_ptr<Buffer>>;
 // first time, the null count will be computed. See ARROW-33
 constexpr int64_t kUnknownNullCount = -1;
 
-class ArrayVisitor;
 class MemoryPool;
 class Status;
 
+template <typename T>
+struct Decimal;
+
 // ----------------------------------------------------------------------
 // Generic array data container
 

cpp/src/arrow/buffer.h

@@ -19,7 +19,6 @@
 #define ARROW_BUFFER_H
 
 #include <algorithm>
-#include <array>
 #include <cstdint>
 #include <cstring>
 #include <memory>

cpp/src/arrow/builder.cc

@@ -19,6 +19,7 @@
 #include <algorithm>
 #include <cstdint>
 #include <cstring>
+#include <limits>
 #include <numeric>
 #include <sstream>
 #include <utility>
@@ -26,6 +27,7 @@
 
 #include "arrow/array.h"
 #include "arrow/buffer.h"
+#include "arrow/compare.h"
 #include "arrow/status.h"
 #include "arrow/type.h"
 #include "arrow/type_traits.h"

cpp/src/arrow/builder.h

@@ -21,11 +21,10 @@
 #include <algorithm>
 #include <array>
 #include <cstdint>
-#include <iterator>
+#include <functional>
 #include <limits>
 #include <memory>
 #include <string>
-#include <type_traits>
 #include <vector>
 
 #include "arrow/buffer.h"
@@ -36,18 +35,22 @@
 #include "arrow/util/bit-util.h"
 #include "arrow/util/hash.h"
 #include "arrow/util/macros.h"
-#include "arrow/util/type_traits.h"
 #include "arrow/util/visibility.h"
 
 namespace arrow {
 
 class Array;
-struct ArrayData;
 class Decimal128;
 
 constexpr int64_t kBinaryMemoryLimit = std::numeric_limits<int32_t>::max() - 1;
 constexpr int64_t kListMaximumElements = std::numeric_limits<int32_t>::max() - 1;
 
+namespace internal {
+
+struct ArrayData;
+
+}  // namespace internal
+
 constexpr int64_t kMinBuilderCapacity = 1 << 5;
 
 /// Base class for all data array builders.

cpp/src/arrow/compare.cc

@@ -19,19 +19,15 @@
 
 #include "arrow/compare.h"
 
-#include <cmath>
 #include <cstdint>
-#include <cstring>
-#include <limits>
 #include <memory>
-#include <string>
-#include <type_traits>
 #include <vector>
 
 #include "arrow/array.h"
 #include "arrow/status.h"
 #include "arrow/tensor.h"
 #include "arrow/type.h"
+#include "arrow/type_traits.h"
 #include "arrow/util/bit-util.h"
 #include "arrow/util/checked_cast.h"
 #include "arrow/util/logging.h"

cpp/src/arrow/compare.h

@@ -28,6 +28,7 @@ namespace arrow {
 
 class Array;
 class DataType;
+class Status;
 class Tensor;
 
 /// Returns true if the arrays are exactly equal

cpp/src/arrow/io/file.cc

@@ -36,7 +36,6 @@
 #include <cerrno>
 #include <cstdint>
 #include <cstring>
-#include <memory>
 #include <mutex>
 #include <sstream>
 

cpp/src/arrow/memory_pool-test.cc

@@ -22,7 +22,6 @@
 #include "arrow/memory_pool-test.h"
 #include "arrow/memory_pool.h"
 #include "arrow/status.h"
-#include "arrow/test-util.h"
 
 namespace arrow {
 

cpp/src/arrow/pretty_print.cc

@@ -15,12 +15,10 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include <cstdint>
-#include <iostream>
 #include <memory>
+#include <ostream>
 #include <sstream>
 #include <string>
-#include <type_traits>
 #include <vector>
 
 #include "arrow/array.h"

cpp/src/arrow/record_batch.h

@@ -23,14 +23,13 @@
 #include <string>
 #include <vector>
 
+#include "arrow/array.h"
 #include "arrow/type.h"
 #include "arrow/util/macros.h"
 #include "arrow/util/visibility.h"
 
 namespace arrow {
 
-class Array;
-struct ArrayData;
 class KeyValueMetadata;
 class Status;
 

cpp/src/arrow/table.cc

@@ -33,8 +33,6 @@
 
 namespace arrow {
 
-class MemoryPool;
-
 // ----------------------------------------------------------------------
 // ChunkedArray and Column methods
 

cpp/src/arrow/table.h

@@ -32,7 +32,6 @@
 namespace arrow {
 
 class KeyValueMetadata;
-class MemoryPool;
 class Status;
 
 /// \class ChunkedArray

cpp/src/arrow/table_builder-test.cc

@@ -15,16 +15,16 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include <cstdint>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "gtest/gtest.h"
 
-#include "arrow/builder.h"
+#include "arrow/array.h"
 #include "arrow/record_batch.h"
 #include "arrow/status.h"
+#include "arrow/table.h"
 #include "arrow/table_builder.h"
 #include "arrow/test-common.h"
 #include "arrow/test-util.h"

cpp/src/arrow/table_builder.cc

@@ -17,13 +17,17 @@
 
 #include "arrow/table_builder.h"
 
+#include <algorithm>
+#include <cstdlib>
 #include <memory>
+#include <sstream>
 #include <utility>
 
 #include "arrow/array.h"
 #include "arrow/builder.h"
 #include "arrow/record_batch.h"
 #include "arrow/status.h"
+#include "arrow/table.h"
 #include "arrow/type.h"
 #include "arrow/util/logging.h"
 

cpp/src/arrow/table_builder.h

@@ -20,6 +20,7 @@
 
 #include <cstdint>
 #include <memory>
+#include <string>
 #include <vector>
 
 #include "arrow/status.h"
@@ -32,11 +33,12 @@ namespace arrow {
 class ArrayBuilder;
 class MemoryPool;
 class RecordBatch;
+class Schema;
 
 /// \class RecordBatchBuilder
 /// \brief Helper class for creating record batches iteratively given a known
 /// schema
-class ARROW_EXPORT RecordBatchBuilder {
+class RecordBatchBuilder {
  public:
   /// \brief Create an initialize a RecordBatchBuilder
   /// \param[in] schema The schema for the record batch

cpp/src/arrow/tensor.cc

@@ -25,6 +25,7 @@
 #include <vector>
 
 #include "arrow/compare.h"
+#include "arrow/status.h"
 #include "arrow/type.h"
 #include "arrow/util/checked_cast.h"
 #include "arrow/util/logging.h"

cpp/src/arrow/type.h

@@ -23,7 +23,6 @@
 #include <memory>
 #include <ostream>
 #include <string>
-#include <type_traits>
 #include <unordered_map>
 #include <vector>
 

cpp/src/arrow/util/compression_zlib.cc

@@ -28,7 +28,6 @@
 
 #include "arrow/status.h"
 #include "arrow/util/logging.h"
-#include "arrow/util/macros.h"
 
 namespace arrow {