Files
RustPython/Lib/test
Changjoon 2da3a96d19 Short-circuit identity in rich_compare_bool for Eq/Ne (PyObject_RichCompareBool parity) (#7734)
* Short-circuit identity in rich_compare_bool for Eq/Ne (PyObject_RichCompareBool parity)

CPython distinguishes two comparison entry points (Objects/object.c):
- PyObject_RichCompare returns the raw __eq__ / __ne__ result; no
  identity short-circuit
- PyObject_RichCompareBool returns bool; identity implies equality
  (and inequality is false on identity), short-circuiting before
  dispatch

Collection membership / equality (x in [x], [nan] == [nan], set/dict
comparisons) go through the bool variant and rely on the short-circuit.
RustPython's rich_compare_bool skipped the identity check, so a buggy
or raising __eq__ propagated even when the operand was the same object.

Add an identity short-circuit at the top of rich_compare_bool for Eq
(returns true) and Ne (returns false). Ordering ops fall through to
_cmp because Python does not guarantee reflexivity for </<=/>/>=.
_cmp itself is untouched, so == / != operators continue to invoke
__eq__ / __ne__ exactly as before.

Unmasks test_dictviews.TestDictViews.test_compare_error.

Verified byte-identical with CPython 3.14.4 across 53 scenarios in 10
categories (collection membership / equality / ordering ops / NaN /
hash collision / dict views / list-set-dict ops). 14-module regression
sweep ~2,402 tests passes with no regressions.

* Route proxy comparisons through PyObject_RichCompare

The identity short-circuit added to rich_compare_bool exposed a latent
bug in three proxy types (weakref, weakproxy, mappingproxy): they were
delegating their __eq__ to the bool variant on referents, while CPython
uses PyObject_RichCompare so the referent's __eq__ runs even when the
referents share identity.

Fixes test_weak_keyed_cascading_deletes which depends on key __eq__
firing during dict deletion to trigger a side-effect that mutates the
key list.
2026-04-30 04:45:23 +09:00
..
2026-03-01 11:36:46 +09:00
2025-08-24 10:36:07 +03:00
2026-02-18 03:10:40 +09:00
2025-04-30 14:33:52 +09:00
2026-02-02 00:43:07 +09:00
2026-02-04 09:53:02 +09:00
2023-04-20 15:36:28 +09:00
2023-03-02 15:01:12 +09:00
2026-02-05 00:21:34 +09:00
2022-10-18 03:26:29 +09:00
2026-01-21 20:44:26 +09:00
2023-03-01 18:06:50 +09:00
2026-03-01 11:36:46 +09:00
2026-02-02 02:02:12 +09:00
2026-02-13 22:15:52 +09:00
2026-01-25 15:20:05 +09:00
2025-03-31 18:49:08 +09:00
2026-02-14 18:27:31 +02:00
2026-02-13 13:36:33 +02:00
2026-02-13 13:36:33 +02:00
2026-02-13 14:13:30 +09:00
2026-01-18 21:33:37 +09:00
2025-03-26 02:24:01 -05:00
2024-06-24 19:00:54 +09:00
2026-02-18 00:43:49 +09:00
2026-02-11 16:50:23 +09:00
2026-01-30 16:39:33 +02:00
2026-02-08 20:36:35 +09:00
2026-01-17 19:22:00 +09:00
2025-09-01 11:19:00 +03:00
2026-02-10 00:48:22 +09:00
fix
2026-02-12 01:01:35 +09:00
2026-02-06 00:15:18 +09:00
2026-02-13 13:36:33 +02:00
2026-03-03 15:20:36 +01:00
2026-03-12 13:24:29 +01:00
2026-02-11 18:38:10 +09:00
2026-02-03 22:10:31 +09:00
2026-02-06 00:15:18 +09:00
2026-02-01 19:45:06 -05:00
2023-03-02 05:56:34 +09:00
2026-03-06 06:00:08 +09:00
2026-02-13 13:55:05 +09:00
2026-02-14 18:19:57 +02:00
2026-03-23 13:10:51 +09:00
2026-03-21 22:49:09 +09:00
2026-01-25 00:18:55 +09:00
2026-01-25 00:18:55 +09:00
2026-01-26 10:40:22 +09:00
2026-03-03 20:00:50 +09:00
2026-02-06 00:15:18 +09:00
2025-04-28 12:29:21 +09:00
2026-02-03 22:10:31 +09:00
2026-03-12 18:08:56 +09:00
2025-08-31 11:58:21 +03:00
2026-02-06 01:14:55 +09:00
2026-02-13 13:36:33 +02:00
2026-02-27 09:44:41 +01:00
2026-04-14 13:04:50 +02:00
2026-02-04 18:32:45 +09:00
2026-03-03 19:57:50 +09:00
2026-02-28 22:50:51 +09:00
2026-02-06 00:15:18 +09:00
2026-01-25 00:18:55 +09:00
2026-02-27 10:05:21 +01:00
2025-04-21 21:11:42 -07:00
2026-02-04 09:53:02 +09:00
2026-01-31 20:51:53 -05:00
2025-12-12 10:37:40 +09:00
2026-02-15 09:02:24 +09:00
2026-02-03 22:10:31 +09:00
2026-02-05 23:50:08 +09:00
2026-02-14 21:40:04 +09:00
2026-03-01 11:36:46 +09:00
2026-02-14 09:18:09 +09:00
2025-03-26 23:12:21 -05:00
2026-03-01 10:42:37 +09:00
2026-03-21 22:49:09 +09:00
2026-03-23 11:31:30 +09:00
2026-02-11 16:57:51 +09:00
2026-02-27 22:59:41 +09:00
2026-03-21 22:49:09 +09:00
2025-06-22 22:36:13 +09:00
2026-02-27 16:53:55 +09:00
2026-03-08 18:06:23 +09:00
2026-03-03 21:58:46 +09:00
2026-02-02 01:20:23 +09:00
2025-01-17 18:04:25 -08:00
2026-01-25 00:18:55 +09:00
2026-01-25 00:18:55 +09:00
2026-02-13 13:44:28 +09:00
2026-01-25 00:18:55 +09:00
2026-02-06 00:15:18 +09:00
2025-12-20 12:17:11 +09:00
2026-02-13 13:42:22 +09:00
2026-01-25 00:18:55 +09:00
2026-02-15 23:44:23 +09:00
2026-02-27 09:49:35 +01:00
2026-02-14 18:18:53 +02:00
2026-03-05 17:25:59 +09:00
2023-04-20 15:36:28 +09:00