Files
youknowdot 1ee9a29062 Preserve explicit AST source positions through compilation (#9138)
* Preserve explicit AST column locations through code generation

Assisted-by: OpenAI Codex:model version unavailable

* Remove obsolete location bindings after span migration

Assisted-by: OpenAI Codex:model version unavailable

* Propagate inconsistent AST span provenance without panicking

Assisted-by: OpenAI Codex:model version unavailable

* Preserve mapped positions when exporting optimized Pass nodes

Assisted-by: OpenAI Codex:model version unavailable

* Consolidate AST location regressions and satisfy strict compiler lints

Assisted-by: OpenAI Codex:model version unavailable

* Consolidate equivalent AST literal location cases

Replace the six-way literal-only optimizer matrix with one optimized-AST round-trip, preserving all assertions. Keep the distinct normalized-range identity, explicit Pass provenance, and synthetic format-spec regressions.

Validation: all four appended location cases passed using the verified final-f6a RustPython binary with unchanged native sources. Ran normal pre-commit hooks; no Cargo build or full cyclic snippet suite.

Assisted-by: OpenAI Codex:model version unavailable

* Reuse Ruff source locations in AST conversion

Replace redundant PySourceLocation, Row, and Column wrappers with the compiler-core re-export of Ruff SourceLocation. Use UTF-8 byte coordinates and retain the empty-source fallback. Share the normalized range conversion while preserving caller validation and signed semantic metadata.

Validation so far: independent source and boundary review, rustfmt, and git diff --check. Runtime validation follows after the shared build target is released.

Assisted-by: OpenAI Codex:model version unavailable

* Preserve the first AST preprocessing location error

Share first-error recording between generated-node allocation and synthetic-pass coordinate overflow. Exercise both real compiler-state failure paths in both orders using one MAX_ID location entry.

Validation: focused compiler-state regression, strict codegen all-target Clippy, unchanged full-source seals, rustfmt, and normal pre-commit hooks. No interpreter runtime or broad suite rerun for this error-only change.

Assisted-by: OpenAI Codex:model version unavailable
2026-10-16 10:13:59 +09:00

266 lines
7.6 KiB
Python

import ast
import copy
print(ast)
source = """
def foo():
print('bar')
pass
"""
n = ast.parse(source)
print(n)
print(n.body)
print(n.body[0].name)
assert n.body[0].name == "foo"
foo = n.body[0]
assert foo.lineno == 2
print(foo.body)
assert len(foo.body) == 2
print(foo.body[0])
print(foo.body[0].value.func.id)
assert foo.body[0].value.func.id == "print"
assert foo.body[0].lineno == 3
assert foo.body[1].lineno == 4
n = ast.parse("3 < 4 > 5\n")
assert n.body[0].value.left.value == 3
assert "Lt" in str(n.body[0].value.ops[0])
assert "Gt" in str(n.body[0].value.ops[1])
assert n.body[0].value.comparators[0].value == 4
assert n.body[0].value.comparators[1].value == 5
n = ast.parse("from ... import a\n")
print(n)
i = n.body[0]
assert i.level == 3
assert i.module is None
assert i.names[0].name == "a"
assert i.names[0].asname is None
# Regression: parsed AST identifier fields are interned, matching CPython.
name_literal = "x"
name = ast.parse("x").body[0].value
assert name.id is name_literal
name.extra = object()
replacement = copy.replace(name)
assert replacement.id is name.id
assert replacement.ctx is name.ctx
assert not hasattr(replacement, "extra")
function_name = "f"
function = ast.parse("def f(): pass").body[0]
assert function.name is function_name
async_function = ast.parse("async def f(): pass").body[0]
assert async_function.name is function_name
# Regression test for issue #4862:
# A cyclic AST fed to compile() used to overflow the Rust stack and SIGSEGV.
# After the fix, the recursion guard in ast_from_object raises RecursionError,
# matching CPython's behavior. Covers both Box<T> descents (UnaryOp, BinOp,
# Call, Attribute) and Vec<T> descents (List, Tuple).
import warnings
def _cyclic_cases():
# Box<Expr> descents
u = ast.UnaryOp(op=ast.Not(), operand=None, lineno=0, col_offset=0)
u.operand = u
yield "UnaryOp", u
b = ast.BinOp(
op=ast.Add(),
left=None,
right=ast.Constant(value=0, lineno=0, col_offset=0),
lineno=0,
col_offset=0,
)
b.left = b
yield "BinOp", b
c = ast.Call(func=None, args=[], keywords=[], lineno=0, col_offset=0)
c.func = c
yield "Call", c
a = ast.Attribute(value=None, attr="x", ctx=ast.Load(), lineno=0, col_offset=0)
a.value = a
yield "Attribute", a
# Vec<Expr> descents
lst = ast.List(ctx=ast.Load(), lineno=0, col_offset=0)
lst.elts = [lst]
yield "List", lst
tup = ast.Tuple(ctx=ast.Load(), lineno=0, col_offset=0)
tup.elts = [tup]
yield "Tuple", tup
with warnings.catch_warnings():
warnings.simplefilter("ignore")
for name, node in _cyclic_cases():
try:
compile(ast.Expression(node), "<cyclic>", "eval")
raise AssertionError(f"cyclic {name} should raise RecursionError")
except RecursionError:
pass # expected; matches CPython
# Python 3.15 rejects omitted required fields and unknown constructor keywords.
from testutils import assert_raises
with assert_raises(TypeError) as exc:
ast.Name()
assert (
str(exc.exception)
== "ast.Name.__init__ missing 1 required positional argument: 'id'"
)
with assert_raises(TypeError) as exc:
ast.BinOp()
assert str(exc.exception) == (
"ast.BinOp.__init__ missing 3 required positional arguments: 'left', 'op', and 'right'"
)
with assert_raises(TypeError) as exc:
ast.BinOp(op=ast.Add())
assert str(exc.exception) == (
"ast.BinOp.__init__ missing 2 required positional arguments: 'left' and 'right'"
)
with assert_raises(TypeError) as exc:
ast.Name(id="x", extra=True)
assert (
str(exc.exception) == "ast.Name.__init__ got an unexpected keyword argument 'extra'"
)
with assert_raises(TypeError) as exc:
ast.Name("x", id="y")
assert str(exc.exception) == "ast.Name got multiple values for argument 'id'"
# Constructor defaults and explicit placeholders still work.
assert ast.Name("x").ctx is ast.Name("y").ctx
assert isinstance(ast.Name("x").ctx, ast.Load)
assert ast.FunctionDef(name="f", args=ast.arguments()).returns is None
assert ast.Module().body == []
assert ast.Module().body is not ast.Module().body
assert ast.BinOp(left=None, op=None, right=None).left is None
class FieldsWithoutTypes(ast.AST):
_fields = ("value",)
assert not hasattr(FieldsWithoutTypes(), "value")
assert FieldsWithoutTypes(value=1).value == 1
class IncompleteFieldTypes(ast.AST):
_fields = ("value",)
_field_types = {}
with assert_raises(TypeError) as exc:
IncompleteFieldTypes()
assert (
str(exc.exception)
== "Field 'value' is missing from IncompleteFieldTypes._field_types"
)
for key in ("a'b", "line\nbreak"):
with assert_raises(TypeError) as exc:
ast.Name(id="x", **{key: 1})
assert str(exc.exception) == (
f"ast.Name.__init__ got an unexpected keyword argument {key!r}"
)
# Explicit AST positions must survive normalized Rust navigation ranges.
import dis
def store_positions(tree):
code = compile(tree, "<ast-columns>", "exec").co_consts[0]
return [
tuple(instruction.positions)
for instruction in dis.get_instructions(code)
if instruction.opname == "STORE_FAST"
]
# These two nodes have the same normalized navigation range but different
# semantic columns. Position metadata must therefore use node identity.
tree = ast.parse("def f():\n x = 1\n y = 2\n")
first, second = tree.body[0].body
for statement in (first, second):
for node in ast.walk(statement):
if hasattr(node, "lineno"):
node.lineno = node.end_lineno = 2
first.targets[0].col_offset = first.targets[0].end_col_offset = 0
second.targets[0].col_offset = second.targets[0].end_col_offset = -1
assert store_positions(tree) == [(2, 2, 0, 0), (2, 2, None, None)]
def set_location(node, line, col, end_col):
node.lineno = node.end_lineno = line
node.col_offset = col
node.end_col_offset = end_col
return node
# Outbound conversion must not merge or drop explicitly supplied literal nodes.
values = [set_location(ast.Constant(value=s), 1, -1, -1) for s in ("a", "", "b")]
joined = set_location(ast.JoinedStr(values=values), 1, 0, 8)
result = compile(
ast.Expression(body=joined),
"<locations>",
"eval",
ast.PyCF_ONLY_AST | ast.PyCF_OPTIMIZED_AST,
optimize=0,
)
assert [node.value for node in result.body.values] == ["a", "", "b"]
assert all(node.col_offset == node.end_col_offset == -1 for node in result.body.values)
# The replacement Pass derives from the statement, not its string value.
tree = ast.parse('def f():\n "doc"\n')
set_location(tree.body[0].body[0], 2, -1, -1)
set_location(tree.body[0].body[0].value, 2, 4, 9)
result = compile(
tree, "<locations>", "exec", ast.PyCF_ONLY_AST | ast.PyCF_OPTIMIZED_AST, optimize=2
)
replacement = result.body[0].body[0]
assert isinstance(replacement, ast.Pass)
assert (
replacement.lineno,
replacement.end_lineno,
replacement.col_offset,
replacement.end_col_offset,
) == (2, 2, -1, 3)
# The optimizer's generated format spec is an artificial Constant; the argument
# and the outer expression retain their own distinct source locations.
tree = ast.parse("'%3s' % (value,)", mode="eval")
set_location(tree.body, 1, -1, -1)
set_location(tree.body.right.elts[0], 1, 8, 13)
result = compile(
tree, "<locations>", "eval", ast.PyCF_ONLY_AST | ast.PyCF_OPTIMIZED_AST, optimize=0
)
formatted = result.body.values[0]
assert (result.body.col_offset, result.body.end_col_offset) == (-1, -1)
assert (formatted.col_offset, formatted.end_col_offset) == (8, 13)
assert isinstance(formatted.format_spec, ast.Constant)
assert formatted.format_spec.value == ">3"
spec = formatted.format_spec
assert (spec.lineno, spec.end_lineno, spec.col_offset, spec.end_col_offset) == (
-1,
-1,
-1,
-1,
)