Files
RustPython/extra_tests/snippets/stdlib_csv.py
Jeong, YunWon d5d19e0611 Fix 33 reproduced fuzzing and static-review defects (#8514)
* mmap: guard move() against dest/src past the mapping size

An offset larger than the mapping made `size - dest` underflow, producing
an out-of-range slice index panic. Check the high side first, as write() does.

Assisted-by: Claude

* exceptions: keep ImportError name/path/name_from out of an empty instance dict

ImportError.__reduce__ unwrapped get_arg(0), which is None when the exception
was constructed with no positional argument, aborting on pickle.dumps(ImportError()).
Fall back to the full args tuple there, and expose name/path/name_from as class
attributes defaulting to None so a bare ImportError() reduces to (cls, ()).

Assisted-by: Claude

* asyncio: stop unwrapping the _current_tasks downcast in current_task()

_asyncio._current_tasks is a reassignable module attribute; the three sibling
functions already degrade gracefully when it is not a dict, current_task() did not.

Assisted-by: Claude

* asyncio: raise TypeError when FutureIter.throw()'s exception class returns a non-exception

exc_type.call() goes through a Python-controlled __new__, so its result can be
any object; the downcast was unwrapped. Report it as a TypeError instead.

Assisted-by: Claude

* sequence: use a fallible reservation for sequence repetition

The guard only rejects a repeat whose per-element size crosses MAX_MEMORY_SIZE,
so (1,) * (10**12) still reached Vec::with_capacity and aborted in the allocator.
Reserve fallibly and surface a MemoryError.

Assisted-by: Claude

* collections: reject an oversized deque repetition with MemoryError

deque * sys.maxsize reached the allocator and aborted with a capacity overflow.
Apply the MAX_MEMORY_SIZE guard the other sequences already carry.

Assisted-by: Claude

* itertools: raise OverflowError for an out-of-range r argument

combinations/combinations_with_replacement/permutations narrowed r with
to_usize().unwrap(), so r=2**64 panicked instead of raising.

Assisted-by: Claude

* math: stream the generic sumprod path instead of collecting both iterables

The big-int path collected each argument into a Vec before multiplying, so an
unbounded iterable exhausted memory. Advance both iterators in lockstep and
accumulate, reporting a length mismatch when only one is exhausted.

Assisted-by: Claude

* _imp: raise TypeError for a second positional argument to find_frozen

withdata is keyword-only and unimplemented; passing it positionally hit an
unimplemented!() and aborted.

Assisted-by: Claude

* _typing: check _idfunc arity before indexing args

_typing._idfunc() with no argument indexed args[0] out of bounds.

Assisted-by: Claude

* exceptions: require a sequence for the ExceptionGroup excs argument

The argument was collected before being validated, so an unbounded iterable
such as itertools.count() exhausted memory. Reject a non-sequence up front.

Assisted-by: Claude

* mmap: treat an inverted find/rfind range as empty

find(b"x", 5, 2) built a slice whose start exceeded its end and panicked.

Assisted-by: Claude

* collections: give deque and defaultdict a GC traverse

Neither type opted into traversal, so a reference cycle through a deque or a
defaultdict was never collected.

Assisted-by: Claude

* itertools: opt the iterator types into GC traverse

cycle and its siblings hold Python references but declared no traverse, so a
cycle built through one of them leaked.

Assisted-by: Claude

* _ctypes: mask an out-of-range int instead of panicking

c_char_p(2**64) and pointer item assignment called .expect() on the narrowing
conversion. Wrap the value to the target width, which is what the C
implementation stores.

Assisted-by: Claude

* hashlib: import _hashlib when a hash module is loaded

The hash object type is a static type owned by _hashlib; calling _md5.md5()
without _hashlib imported hit an uninitialized static type and panicked.

Assisted-by: Claude

* _csv: fall back to the built-in dialect defaults when none is registered

The dialect table is empty until csv.py registers 'excel', so _csv.reader([])
unwrapped a missing entry and panicked.

Assisted-by: Claude

* builtins: reject surrogates in compile()/eval() source instead of panicking

expect_str() panics on a str containing surrogates; convert with try_as_utf8
so eval(chr(0xd800)) raises.

Assisted-by: Claude

* _suggestions: require a list for _generate_suggestions candidates

The argument was collected before validation, so an unbounded iterable
exhausted memory.

Assisted-by: Claude

* lzma: size the filter chain before consuming it

filters= was collected into a Vec before the length check, so an unbounded
iterable exhausted memory. Take the length through the sequence protocol first.

Assisted-by: Claude

* classmethod: opt into GC traverse

staticmethod already declares traverse; classmethod did not, so a cycle through
the wrapped callable leaked.

Assisted-by: Claude

* posix: reject unbounded iterables in posix_spawn and setgroups

argv, setsigdef, setsigmask and setgroups bound an ArgIterable and collected it
before validating, so an infinite generator exhausted memory. Require a
list/tuple for argv, validate signals while streaming, and take setgroups
through the sequence protocol.

Assisted-by: Claude

* _ctypes: size Array slice assignment and _argtypes_ before collecting

Both eagerly collected their argument, so an unbounded iterable exhausted
memory before the length check ran.

Assisted-by: Claude

* sys: propagate the breakpointhook warning failure

warn() was unwrapped, so an unimportable $PYTHONBREAKPOINT under
-W error panicked instead of raising.

Assisted-by: Claude

* structseq: require the sequence argument when constructing a struct sequence

A no-argument construction produced an empty backing tuple, and reading any
named field then indexed out of bounds.

Assisted-by: Claude

* Guard the hash slot dispatch against unbounded recursion

`PyObject::hash` invoked the type's hash slot directly, so an element-wise
`__hash__` following a deeply nested object graph recursed one native frame
per level and overflowed the stack. Wrap the dispatch in `with_recursion`,
matching the repr and rich-compare dispatches in the same file, so
`hash(x)` on a nested tuple/GenericAlias/slice raises `RecursionError`.

Assisted-by: Claude

* genericalias: guard the __parameters__ walk against unbounded recursion

`make_parameters_from_slice` recursed into every list/tuple argument with
nothing counting the frames, so `list[L]` for a self-referential or deeply
nested `L` overflowed the native stack at subscript time. Wrap the descent
in `with_recursion`, which makes the walk fallible; `PyGenericAlias::new`,
`from_args` and `make_parameters` now return `PyResult` and every caller
propagates.

Assisted-by: Claude

* Fix the type confusion in PyAtomicRef's Debug impl

`PyAtomicRef<T>` stores a pointer to a `Py<T>`, as `Deref`, `load_raw`,
`swap` and `Drop` all read it, but `Debug` cast it to a bare `T` and
formatted the object header as payload bytes. For `PyFunction`, whose
`code: PyAtomicRef<PyCode>` has a pointer-chasing `Debug`, that
dereferenced header words and segfaulted.

Cast to `PyObject` instead, which is what `Drop` already does and which
also covers the `PyAtomicRef<PyObject>` and `PyAtomicRef<Option<T>>`
instantiations that have no `Py<T>`.

`_asyncio._enter_task` reached this through `{:?}` in its "Cannot enter
into task" message; format the two tasks with their Python repr, which is
what the message is meant to show.

Assisted-by: Claude

* _sre: disallow instantiating Match

`Match` inherited `object.__new__`, so `M.__new__(M)` produced an instance
whose `regs`/`string`/`pattern` were never filled in by a match run; the
mapping subscript path read them and dereferenced garbage. The type has no
public constructor, so mark it `DISALLOW_INSTANTIATION`, which makes
`M.__new__(M)` raise `TypeError: cannot create 're.Match' instances`.

Assisted-by: Claude

* utils: return the empty repr instead of asserting a non-empty collection

`collection_repr` took the first element with an `.expect()` justified by the
caller's preceding non-empty check. Another thread clearing the collection
between that check and the iteration made the iterator yield nothing and
panicked the worker. Fall back to the caller-supplied empty form, which is
the text those callers already produce for an empty collection.

Assisted-by: Claude

* itertools: advance cycle's index atomically

`cycle.__next__` did `fetch_add(1)` and then reset the index to 0 in a
separate store, so two threads replaying the saved items could both read an
index past the end of `saved` and panic on the slice access. Do the advance
and the wrap in one `fetch_update`.

Assisted-by: Claude

* _ctypes: reject a float argument to a foreign call without argtypes

`conv_param`, the conversion used when `argtypes` is not set, converted its
argument with `try_int`, which goes through `__int__` and so accepts a
float. `libc.strlen(1.5)` therefore passed 1 where the callee expects a
`char *` and the callee dereferenced it. Match `ConvParam`, which does a
`PyLong_Check` and converts nothing: take the branch only for an `int` (or
a subclass, so `True` still converts), and let a float fall through to
"Don't know how to convert parameter".

The branch below it converted a float to a C double, but `try_int` claimed
every float before it could run, so it was dead; `CArgValue::Double`
existed only for that branch and both go. Typed doubles are unaffected —
they travel as `CArgValue::Typed` with code 'd'.

Assisted-by: Claude

* Report the iterator itself from PyIter's traverse

`Traverse for PyIter<O>` delegated to the inherent `PyObject::traverse` of
the object it wraps, so it reported that iterator's referents instead of
the iterator. The iterator's own reference to those referents was then
never subtracted during the collector's reference-subtraction pass, the
referents kept a non-zero gc_refs, and every object reachable from them
was classified as a root.

Any cycle running through a type with a `PyIter` field therefore survived
collection: `map`, `filter`, `zip`, `enumerate`, `reversed` and the
`itertools` iterators all leaked, while the same cycle through a `list`,
`tuple` or `list_iterator` collected. Report the wrapped object, as the
`PyObjectRef`, `PyRef<T>` and `PyStackRef` impls do.

`itertools.tee` still leaks: its shared buffer is a `PyRc<PyItertoolsTeeData>`
rather than a Python object, so the collector cannot see through it.

Assisted-by: Claude

* Remove the obsolete expectedFailure on test_code_module.test_unicode_error

Compiling a source string containing a lone surrogate now raises
UnicodeEncodeError, so the test passes.

Assisted-by: Claude

* itertools: reserve the combination indices fallibly

`combinations` and `combinations_with_replacement` built their index vector
with an infallible allocation, so an `r` that passes the ssize_t check but
does not fit in memory aborted the process instead of raising MemoryError.

Assisted-by: Claude

* Apply the struct sequence constructor's dict argument

`structseq(sequence, dict)` discarded its second argument, so the hidden
fields past `n_sequence_fields` — `tm_zone`, `st_atime` and friends — were
always None when constructed directly or restored from a `(sequence, dict)`
pickle, and a non-dict second argument was accepted silently.

Take the dict, require it to be a dict, and fill the hidden slots the
sequence did not cover from it. A key that names a field the sequence
already supplied, or no field at all, is now a
"got duplicate or unexpected field name(s)" TypeError instead of being
dropped. Both arguments are bindable by name, as `sequence` and `dict`.

`os.stat_result` and `os.statvfs_result` did not accept a second argument
at all; they and `time.struct_time` now share the parsing.

Assisted-by: Claude

* _imp: report the argument count in find_frozen's arity error

Assisted-by: Claude

* Add regression tests for the reproduced crashers

One case per catalog entry, each asserting the behavior the fix produces:
recursion guards, the memory-unsafety sites, the overflow and unbounded
allocation guards, the eager-collection rejections, the unwrap sites, and
the cycles the collector now breaks. Every expected value was checked
against CPython 3.14.

Assisted-by: Claude

* Tolerate a changed-size RuntimeError in the set repr stress test

The mutator and reader threads race on purpose; a "changed size during
iteration" RuntimeError is a valid outcome of that race and should not fail
the test. The panic it guards against is not.

Assisted-by: Claude

* Move the crash regression tests into per-module snippets

crash_regressions.py collected every reproduced crasher in one file. Split it
into the snippet for the module each case exercises, and add stdlib_gc.py,
stdlib_asyncio.py, stdlib_lzma.py, stdlib_threading_set_repr.py and
stdlib_threading_itertools_cycle.py for the cases with no existing home.

The suite runs every snippet under the host CPython too, so the checks only
RustPython raises are guarded by sys.implementation.name: the hash and
__parameters__ recursion depth, and the deque repeat overflow. The float
ctypes argument accepts either TypeError or ctypes.ArgumentError.

Assisted-by: Claude
2026-08-14 00:57:10 +09:00

353 lines
10 KiB
Python

import _csv
import csv
import io
import sys
from testutils import assert_raises
for row in csv.reader(["one,two,three"]):
[one, two, three] = row
assert one == "one"
assert two == "two"
assert three == "three"
def f():
iter = ["one,two,three", "four,five,six"]
reader = csv.reader(iter)
[one, two, three] = next(reader)
[four, five, six] = next(reader)
assert one == "one"
assert two == "two"
assert three == "three"
assert four == "four"
assert five == "five"
assert six == "six"
f()
def test_delim():
iter = ["one|two|three", "four|five|six"]
reader = csv.reader(iter, delimiter="|")
[one, two, three] = next(reader)
[four, five, six] = next(reader)
assert one == "one"
assert two == "two"
assert three == "three"
assert four == "four"
assert five == "five"
assert six == "six"
with assert_raises(TypeError):
iter = ["one,,two,,three"]
csv.reader(iter, delimiter=",,")
test_delim()
def test_quote_strings_and_notnull_writer():
string_buf = io.StringIO()
csv.writer(string_buf, quoting=csv.QUOTE_STRINGS).writerow(["x", 1, None, ""])
assert string_buf.getvalue() == '"x",1,,""\r\n'
notnull_buf = io.StringIO()
csv.writer(notnull_buf, quoting=csv.QUOTE_NOTNULL).writerow(["x", 1, None, ""])
assert notnull_buf.getvalue() == '"x","1",,""\r\n'
for quoting in (csv.QUOTE_STRINGS, csv.QUOTE_NOTNULL):
buf = io.StringIO()
csv.writer(buf, quoting=quoting).writerow([None, None])
assert buf.getvalue() == ",\r\n"
with assert_raises(csv.Error):
csv.writer(io.StringIO(), quoting=quoting).writerow([None])
with assert_raises(TypeError):
csv.writer(io.StringIO(), quoting=quoting, quotechar=None)
test_quote_strings_and_notnull_writer()
def test_quote_none_writer_without_quotechar():
no_quotechar_buf = io.StringIO()
csv.writer(
no_quotechar_buf,
quoting=csv.QUOTE_NONE,
quotechar=None,
escapechar="\\",
).writerow(["a,b", 'x"y'])
assert no_quotechar_buf.getvalue() == 'a\\,b,x"y\r\n'
default_quotechar_buf = io.StringIO()
csv.writer(
default_quotechar_buf,
quoting=csv.QUOTE_NONE,
escapechar="\\",
).writerow(["a,b", 'x"y'])
assert default_quotechar_buf.getvalue() == 'a\\,b,x\\"y\r\n'
escapechar_buf = io.StringIO()
csv.writer(
escapechar_buf,
quoting=csv.QUOTE_NONE,
quotechar=None,
escapechar="\\",
).writerow(["a\\b"])
assert escapechar_buf.getvalue() == "a\\\\b\r\n"
linebreak_buf = io.StringIO()
csv.writer(
linebreak_buf,
quoting=csv.QUOTE_NONE,
quotechar=None,
escapechar="\\",
).writerow(["a\rb", "c\nd"])
assert linebreak_buf.getvalue() == "a\\\rb,c\\\nd\r\n"
with assert_raises(csv.Error):
csv.writer(io.StringIO(), quoting=csv.QUOTE_NONE, quotechar=None).writerow(
["a,b"]
)
with assert_raises(csv.Error):
csv.writer(
io.StringIO(),
quoting=csv.QUOTE_NONE,
quotechar=None,
escapechar="\\",
).writerow([None])
two_empty_buf = io.StringIO()
csv.writer(
two_empty_buf,
quoting=csv.QUOTE_NONE,
quotechar=None,
escapechar="\\",
).writerow([None, ""])
assert two_empty_buf.getvalue() == ",\r\n"
test_quote_none_writer_without_quotechar()
def test_quote_none_reader_skipinitialspace_escapechar():
reader = csv.reader(
["a, b,\\ c,d"],
quoting=csv.QUOTE_NONE,
escapechar="\\",
skipinitialspace=True,
)
assert list(reader) == [["a", "b", " c", "d"]]
test_quote_none_reader_skipinitialspace_escapechar()
def test_quote_minimal_writer_lineterminator():
# https://github.com/RustPython/RustPython/issues/8302
# QUOTE_MINIMAL must quote '\r' and '\n' regardless of the line terminator.
buf = io.StringIO()
writer = csv.writer(buf, lineterminator="!")
writer.writerow(["a", "b"])
writer.writerow([1, 2])
writer.writerow(["\r", "\n"])
assert buf.getvalue() == 'a,b!1,2!"\r","\n"!'
nul = io.StringIO()
csv.writer(nul, lineterminator="\0").writerow(["\r", "\n"])
assert nul.getvalue() == '"\r","\n"\0'
crlf = io.StringIO()
csv.writer(crlf, lineterminator="!").writerow(["\r\n"])
assert crlf.getvalue() == '"\r\n"!'
# the terminator character itself still triggers quoting
term = io.StringIO()
csv.writer(term, lineterminator="!").writerow(["a!b", "c"])
assert term.getvalue() == '"a!b",c!'
# default terminator behavior is unchanged
default = io.StringIO()
csv.writer(default).writerow(["\r", "\n"])
assert default.getvalue() == '"\r","\n"\r\n'
test_quote_minimal_writer_lineterminator()
def test_multichar_lineterminator():
# https://github.com/RustPython/RustPython/issues/8322
# The writer must store and emit a full multi-character line terminator.
for lineterminator in "\r\n", "\n", "\r", "!@#", "\0":
buf = io.StringIO()
writer = csv.writer(buf, lineterminator=lineterminator)
writer.writerow(["a", "b"])
writer.writerow([1, 2])
writer.writerow(["\r", "\n"])
assert buf.getvalue() == (
f'a,b{lineterminator}1,2{lineterminator}"\r","\n"{lineterminator}'
), (lineterminator, buf.getvalue())
# A field is quoted when it contains any byte of the terminator (QUOTE_MINIMAL).
for field, expected in [
("a@b", '"a@b",x!@#'),
("a!b", '"a!b",x!@#'),
("a#b", '"a#b",x!@#'),
("abc", "abc,x!@#"),
]:
buf = io.StringIO()
csv.writer(buf, lineterminator="!@#").writerow([field, "x"])
assert buf.getvalue() == expected, (field, buf.getvalue())
# The csv-core-backed QUOTE_ALL / QUOTE_NONNUMERIC paths emit the full
# terminator too, and keep the state machine correct across rows.
allq = io.StringIO()
writer = csv.writer(allq, lineterminator="!@#", quoting=csv.QUOTE_ALL)
writer.writerow(["a", "b"])
writer.writerow(["c", "d"])
assert allq.getvalue() == '"a","b"!@#"c","d"!@#', allq.getvalue()
nonnum = io.StringIO()
csv.writer(nonnum, lineterminator="!@#", quoting=csv.QUOTE_NONNUMERIC).writerow(
["a", 1]
)
assert nonnum.getvalue() == '"a",1!@#', nonnum.getvalue()
# A field that itself contains a line-break byte must be kept intact: the
# csv-core path drops only the trailing record terminator, not a byte from
# the field data.
embedded = io.StringIO()
csv.writer(embedded, lineterminator="!@#", quoting=csv.QUOTE_ALL).writerow(
["x\ny", "z"]
)
assert embedded.getvalue() == '"x\ny","z"!@#', embedded.getvalue()
# QUOTE_NONE escapes any byte of the terminator.
none = io.StringIO()
csv.writer(
none, lineterminator="!@#", quoting=csv.QUOTE_NONE, escapechar="\\"
).writerow(["a!b", "x"])
assert none.getvalue() == "a\\!b,x!@#", none.getvalue()
# register_dialect round-trips a multi-character terminator.
csv.register_dialect("multichar_lt", delimiter=",", lineterminator="!@#")
try:
reg = io.StringIO()
csv.writer(reg, dialect="multichar_lt").writerow(["a", "b"])
assert reg.getvalue() == "a,b!@#", reg.getvalue()
finally:
csv.unregister_dialect("multichar_lt")
# The dialect attribute reflects the full terminator.
assert (
csv.writer(io.StringIO(), lineterminator="!@#").dialect.lineterminator == "!@#"
)
# The reader ignores lineterminator (like CPython) and only splits on \r\n.
assert list(csv.reader(io.StringIO("a,b!@#c,d!@#"), lineterminator="!@#")) == [
["a", "b!@#c", "d!@#"]
]
assert list(csv.reader(io.StringIO("a,b\r\nc,d\r\n"), lineterminator="!@#")) == [
["a", "b"],
["c", "d"],
]
test_multichar_lineterminator()
def test_reject_non_ascii_lineterminator():
# CPython accepts non-ASCII line terminators; RustPython rejects them
# because the writer quotes and escapes byte by byte. Supporting them
# requires code-point-wise handling as part of full Unicode dialect support.
with assert_raises(csv.Error):
csv.writer(io.StringIO(), lineterminator="é")
with assert_raises(csv.Error):
csv.writer(io.StringIO(), lineterminator="\x85")
with assert_raises(csv.Error):
csv.writer(io.StringIO(), lineterminator="\ud800")
with assert_raises(csv.Error):
csv.writer(
io.StringIO(), lineterminator="é", quoting=csv.QUOTE_NONE, escapechar="\\"
)
with assert_raises(csv.Error):
csv.register_dialect("non_ascii_lt", lineterminator="é")
class NonAsciiDialect(csv.excel):
lineterminator = "é"
with assert_raises(csv.Error):
NonAsciiDialect()
buf = io.StringIO()
csv.writer(buf, lineterminator="!@#").writerow(["a", "b"])
assert buf.getvalue() == "a,b!@#"
if sys.implementation.name == "rustpython":
test_reject_non_ascii_lineterminator()
def test_empty_lineterminator():
class EmptyLineTerminator(csv.excel):
lineterminator = ""
keyword = io.StringIO()
csv.writer(keyword, lineterminator="").writerows([["a", "b"], ["c", "d"]])
assert keyword.getvalue() == "a,bc,d"
dialect = io.StringIO()
csv.writer(dialect, dialect=EmptyLineTerminator).writerows([["a", "b"], ["c", "d"]])
assert dialect.getvalue() == "a,bc,d"
source = "a,b\r\nc,d\n"
assert list(csv.reader(io.StringIO(source), lineterminator="")) == [
["a", "b"],
["c", "d"],
]
assert list(csv.reader(io.StringIO(source), dialect=EmptyLineTerminator)) == [
["a", "b"],
["c", "d"],
]
test_empty_lineterminator()
def test_quote_minimal_writer_empty_fields():
buf = io.StringIO()
writer = csv.writer(buf)
writer.writerow([""])
writer.writerow([None])
writer.writerow([])
writer.writerow(["", ""])
assert buf.getvalue() == '""\r\n""\r\n\r\n,\r\n'
test_quote_minimal_writer_empty_fields()
def test_reader_skipinitialspace_preserves_quoted_spaces():
reader = csv.reader(['a, "b, c", d'], skipinitialspace=True)
assert list(reader) == [["a", "b, c", "d"]]
test_reader_skipinitialspace_preserves_quoted_spaces()
# The reader is built with the default dialect, which it has to look up itself.
with assert_raises(StopIteration):
next(_csv.reader([]))