From dc6fa6cf62ca5360f069a0ceaefaea7d30f23c85 Mon Sep 17 00:00:00 2001 From: Jeong YunWon Date: Fri, 13 Mar 2020 08:33:53 +0900 Subject: [PATCH] Fix str.isascii --- Lib/test/test_unicode.py | 2 -- vm/src/obj/objstr.rs | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Lib/test/test_unicode.py b/Lib/test/test_unicode.py index 41e7b495c..99698fba9 100644 --- a/Lib/test/test_unicode.py +++ b/Lib/test/test_unicode.py @@ -679,8 +679,6 @@ class UnicodeTest(string_tests.CommonTest, self.assertFalse('\U0001F40D'.isalpha()) self.assertFalse('\U0001F46F'.isalpha()) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_isascii(self): super().test_isascii() self.assertFalse("\u20ac".isascii()) diff --git a/vm/src/obj/objstr.rs b/vm/src/obj/objstr.rs index 5e335e15c..3c60c4d70 100644 --- a/vm/src/obj/objstr.rs +++ b/vm/src/obj/objstr.rs @@ -795,7 +795,7 @@ impl PyString { #[pymethod] fn isascii(&self) -> bool { - !self.value.is_empty() && self.value.chars().all(|c| c.is_ascii()) + self.value.chars().all(|c| c.is_ascii()) } #[pymethod]