From aa40195d2422f91f686338e357978a9cecbcd92f Mon Sep 17 00:00:00 2001 From: jeffwang0516 Date: Fri, 21 Oct 2022 14:28:45 +0800 Subject: [PATCH] Remove expected failures for method related tests --- Lib/test/test_pickle.py | 20 -------------------- Lib/test/test_pickletools.py | 10 ---------- 2 files changed, 30 deletions(-) diff --git a/Lib/test/test_pickle.py b/Lib/test/test_pickle.py index 3312eb6e0..bc69f8cb6 100644 --- a/Lib/test/test_pickle.py +++ b/Lib/test/test_pickle.py @@ -95,11 +95,6 @@ class PyPicklerTests(AbstractPickleTests, unittest.TestCase): def test_buffers_error(self): # TODO: RUSTPYTHON, remove when this passes super().test_buffers_error() # TODO: RUSTPYTHON, remove when this passes - # TODO: RUSTPYTHON, TypeError: cannot pickle 'method' object - @unittest.expectedFailure - def test_c_methods(self): # TODO: RUSTPYTHON, remove when this passes - super().test_c_methods() # TODO: RUSTPYTHON, remove when this passes - # TODO: RUSTPYTHON, AssertionError @unittest.expectedFailure def test_complex_newobj_ex(self): # TODO: RUSTPYTHON, remove when this passes @@ -130,11 +125,6 @@ class PyPicklerTests(AbstractPickleTests, unittest.TestCase): def test_picklebuffer_error(self): # TODO: RUSTPYTHON, remove when this passes super().test_picklebuffer_error() # TODO: RUSTPYTHON, remove when this passes - # TODO: RUSTPYTHON, pickle.PicklingError - @unittest.expectedFailure - def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes - super().test_py_methods() # TODO: RUSTPYTHON, remove when this passes - def dumps(self, arg, proto=None, **kwargs): f = io.BytesIO() p = self.pickler(f, proto, **kwargs) @@ -171,11 +161,6 @@ class InMemoryPickleTests(AbstractPickleTests, AbstractUnpickleTests, def test_buffers_error(self): # TODO: RUSTPYTHON, remove when this passes super().test_buffers_error() # TODO: RUSTPYTHON, remove when this passes - # TODO: RUSTPYTHON, TypeError: cannot pickle 'method' object - @unittest.expectedFailure - def test_c_methods(self): # TODO: RUSTPYTHON, remove when this passes - super().test_c_methods() # TODO: RUSTPYTHON, remove when this passes - # TODO: RUSTPYTHON, AssertionError @unittest.expectedFailure def test_complex_newobj_ex(self): # TODO: RUSTPYTHON, remove when this passes @@ -216,11 +201,6 @@ class InMemoryPickleTests(AbstractPickleTests, AbstractUnpickleTests, def test_picklebuffer_error(self): # TODO: RUSTPYTHON, remove when this passes super().test_picklebuffer_error() # TODO: RUSTPYTHON, remove when this passes - # TODO: RUSTPYTHON, pickle.PicklingError - @unittest.expectedFailure - def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes - super().test_py_methods() # TODO: RUSTPYTHON, remove when this passes - def dumps(self, arg, protocol=None, **kwargs): return pickle.dumps(arg, protocol, **kwargs) diff --git a/Lib/test/test_pickletools.py b/Lib/test/test_pickletools.py index 1d7afb6e8..7dde4b17e 100644 --- a/Lib/test/test_pickletools.py +++ b/Lib/test/test_pickletools.py @@ -17,11 +17,6 @@ class OptimizedPickleTests(AbstractPickleTests, unittest.TestCase): def test_buffers_error(self): # TODO: RUSTPYTHON, remove when this passes super().test_buffers_error() - # TODO: RUSTPYTHON, TypeError: cannot pickle 'method' object - @unittest.expectedFailure - def test_c_methods(self): # TODO: RUSTPYTHON, remove when this passes - super().test_c_methods() - def test_compat_pickle(self): # TODO: RUSTPYTHON, remove when this passes super().test_compat_pickle() @@ -58,11 +53,6 @@ class OptimizedPickleTests(AbstractPickleTests, unittest.TestCase): def test_picklebuffer_error(self): # TODO: RUSTPYTHON, remove when this passes super().test_picklebuffer_error() - # TODO: RUSTPYTHON, pickle.PicklingError - @unittest.expectedFailure - def test_py_methods(self): # TODO: RUSTPYTHON, remove when this passes - super().test_py_methods() - def dumps(self, arg, proto=None, **kwargs): return pickletools.optimize(pickle.dumps(arg, proto, **kwargs))