From 8bfff805a9fbc477a3856f09197aea0ca29abf6d Mon Sep 17 00:00:00 2001 From: Peter Ye <46109467+yaxollum@users.noreply.github.com> Date: Wed, 28 Jul 2021 00:20:32 -0400 Subject: [PATCH] Fix builtins.__name__ --- extra_tests/snippets/builtins_module.py | 4 ++++ vm/src/builtins/make_module.rs | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/extra_tests/snippets/builtins_module.py b/extra_tests/snippets/builtins_module.py index 0f1544dc2..1b5b6bdde 100644 --- a/extra_tests/snippets/builtins_module.py +++ b/extra_tests/snippets/builtins_module.py @@ -5,6 +5,10 @@ assert '__builtins__' in globals() with assert_raises(AttributeError): __builtins__.__builtins__ +assert __builtins__.__name__ == "builtins" +import builtins +assert builtins.__name__ == "builtins" + __builtins__.x = 'new' assert x == 'new' # noqa: F821 diff --git a/vm/src/builtins/make_module.rs b/vm/src/builtins/make_module.rs index 15fad8a2e..566a66e71 100644 --- a/vm/src/builtins/make_module.rs +++ b/vm/src/builtins/make_module.rs @@ -894,8 +894,6 @@ pub fn make_module(vm: &VirtualMachine, module: PyObjectRef) { let debug_mode: bool = vm.state.settings.optimize == 0; extend_module!(vm, module, { "__debug__" => ctx.new_bool(debug_mode), - //set __name__ fixes: https://github.com/RustPython/RustPython/issues/146 - "__name__" => ctx.new_str(String::from("__main__")), "bool" => ctx.types.bool_type.clone(), "bytearray" => ctx.types.bytearray_type.clone(),