From 7fdbf53822e1d210c4a30afa52bc2fb3f35f53b2 Mon Sep 17 00:00:00 2001 From: Jeong Yunwon Date: Mon, 25 Jul 2022 07:09:54 +0900 Subject: [PATCH] update subprocess for windows --- Lib/subprocess.py | 3 ++- Lib/test/test_subprocess.py | 14 -------------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/Lib/subprocess.py b/Lib/subprocess.py index 7b75b9a51..2680a7360 100644 --- a/Lib/subprocess.py +++ b/Lib/subprocess.py @@ -207,7 +207,8 @@ if _mswindows: def __repr__(self): return "%s(%d)" % (self.__class__.__name__, int(self)) - __del__ = Close + # XXX: RustPython; OSError('The handle is invalid. (os error 6)') + # __del__ = Close else: # When select or poll has indicated that the file is writable, # we can write up to _PIPE_BUF bytes without risk of blocking. diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py index f4edbf586..bbcb2734a 100644 --- a/Lib/test/test_subprocess.py +++ b/Lib/test/test_subprocess.py @@ -3599,18 +3599,12 @@ class Win32ProcessTestCase(BaseTestCase): def test_terminate(self): self._kill_process('terminate') - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_send_signal_dead(self): self._kill_dead_process('send_signal', signal.SIGTERM) - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_kill_dead(self): self._kill_dead_process('kill') - # TODO: RUSTPYTHON - @unittest.expectedFailure def test_terminate_dead(self): self._kill_dead_process('terminate') @@ -3713,14 +3707,6 @@ class MiscTests(unittest.TestCase): possible_exports.add(name) self.assertEqual(exported, possible_exports - intentionally_excluded) - # TODO: RUSTPYTHON - if sys.platform == "win32": - test_call_keyboardinterrupt_no_kill = unittest.expectedFailure(test_call_keyboardinterrupt_no_kill) - - # TODO: RUSTPYTHON - if sys.platform == "win32": - test_run_keyboardinterrupt_no_kill = unittest.expectedFailure(test_run_keyboardinterrupt_no_kill) - # TODO: RUSTPYTHON if sys.platform == "win32": test_getoutput = unittest.expectedFailure(test_getoutput)