From 7fae55fa51097a4bfc0d7f234d2bda1cda90ba40 Mon Sep 17 00:00:00 2001 From: TheAnyKey Date: Wed, 10 Jun 2020 18:13:47 +0000 Subject: [PATCH] corrected and added comments --- Lib/test/test_named_expression.py | 2 +- pdc.sh | 18 +++++++++++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/Lib/test/test_named_expression.py b/Lib/test/test_named_expression.py index 70f491764..a22b0ec7f 100644 --- a/Lib/test/test_named_expression.py +++ b/Lib/test/test_named_expression.py @@ -166,7 +166,7 @@ class NamedExpressionInvalidTest(unittest.TestCase): with self.assertRaisesRegex(SyntaxError, msg): exec(f"lambda: {code}", {}) # Function scope - @unittest.expectedFailure # TODO RustPythonskip + @unittest.expectedFailure # TODO RustPython def test_named_expression_invalid_comprehension_iterable_expression(self): cases = [ ("Top level", "[i for i in (i := range(5))]"), diff --git a/pdc.sh b/pdc.sh index 59bfe4033..79beb0ae1 100755 --- a/pdc.sh +++ b/pdc.sh @@ -1,7 +1,23 @@ + +# Pre Delivery Check - or PDC for short - runs all build and check steps. +# The intension is to run all checks before delivering (or raising a PR or commiting or what ever you want to use it for). +# +# PDC executes all of the configured actions in the given order and reports which of them failed, +# without stopping in case of an fail. +# The actions in the given version are the RustPython CI steps plus a debug build in advance. +# So you can run all of the checks in advance with one command. +# +# If you want to customize it or adapt the checks, just add or remove it from/ to the ACTIONS + + +ACTIONS=("cargo build" "cargo build --release" "cargo fmt --all" "cargo clippy --all -- -Dwarnings" "cargo test --all" "cargo run --release -- -m test -v" "cd tests" "pytest" "cd ..") + +# Usually, there should be no need to adapt the remaining file, when adding or removing actions. + + RUSTPYTHONPATH=Lib export RUSTPYTHONPATH -ACTIONS=("cargo build" "cargo build --release" "cargo fmt --all" "cargo clippy --all -- -Dwarnings" "cargo test --all" "cargo run --release -- -m test -v" "cd tests" "pytest" "cd ..") ACT_RES=0 FAILS=()